| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Blinking caret frequency sets a repeating timer, before it was 0 which causes the timer to fire constantly.
Review URL: http://codereview.chromium.org/12416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::wstring for HTTP header fields
The HTTP specification guarantees that all fields in the header will be ASCII
and thus fit fine in a std::string. The GetHttpHeaders/SetHttpHeaders
interfaces use std::string values for HTTP headers. This patch fixes
GetHttpMethod(), SetHttpMethod(), GetHttpHeaderValue() and SetHttpHeaderValue()
and callers to use std::string as well.
Patch by James Robinson <jamesr@google.com>
R=darin
Review URL: http://codereview.chromium.org/12412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
surface in GdkSkia. Fixes linux test shell widget rendering.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to discard a bunch of code and plumbing related to
maintaining and passing around the tickmark vector.
WebKit now owns the drawing of the highlights for inactive matches and
we use the selection controller to draw the active highlight.
I also simplified the code by eliminating the separate FindNext
function, which has been merged into Find.
This change also requires minor changes to WebKit upstream (sold
seperately, void where prohibited).
It simply consists of adding one empty virtual paint function to
ScrollbarThemeComposite.h (paintTickmarks) and in
ScrollbarThemeComposite::paint call paintTickmarks().
This fixes/makes obsolete a slew of bugs:
BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599
... and a couple of external ones as well. Full list:
1326399 Find highlighting disappears on ThinkPad x60s
1241554 Find doesn't highlight word inside blinky tag
1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode
1070190 Find should begin searching from caret/selection
1023019 Find not highlighting correctly
984786 Find highlight drawing code causes ClearType text to look bad
893737 Find in page should search textareas
868599 Find in page tick marks incorrectly appear on nested scrollbars
298 Find-In-page should highlight elided entries
4389 Find-in-box is not highlighting all the instances of the search word
3908 Find in page highlighting and tickmarks are broken
Review URL: http://codereview.chromium.org/11364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same as the previous patch except it doesn't
change the WEBCORE_DIR variable. It needs the OBJ_ROOT in
the resolution path so .o files end up in Hammer/. I'll
fix the include paths in a follow up change.
TBR=sgk
Review URL: http://codereview.chromium.org/12411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
The patch missed all these deletes somehow.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's putting .o files next to .cpp files. I will debug offline
then resubmit.
TBR=sgk
Review URL: http://codereview.chromium.org/12610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also did a little cleanup in getPlugins. I found that there was a
WebPluginInfo struct declared within the WebCore namespace that was causing us
to need '::' in front of WebPluginInfo. I killed the erroneous declaration so
that the rest could be cleaned up. I also renamed getPlugins to plugins since
I think that is more consistent with how Apple names these kinds of methods.
There was some old, unused USE(JSC) code in ScriptController.cpp that I deleted.
R=erikkay
Review URL: http://codereview.chromium.org/12601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The document wrapper wasn't kept alive in the life time of the frame. This results issue 4532.
I don't how to create a test case yet, but verified that dromaeo test runs fine with this fix.
Review URL: http://codereview.chromium.org/11376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By reducing the number of include paths that are specified
as $WEBKIT_DIR/port, we reduce the number of paths that get
expanded by the addRepository functions. Instead, we only specify directories from $WEBKIT_DIR/port if we have header files in those directories. The down side is that if we add a header to port, we need to update the include paths.
Also, don't specify WebCore includes with OBJ_ROOT as the fallback repository so we save on -I expansion.
Remove $WEBKIT_PORT_DIR because it's the same as $PORT_DIR.
The change to glue/SConscript is to pick up webkit_version.h since glue is the only place that needs it.
Review URL: http://codereview.chromium.org/11598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Properly initialize ResourceLoaderBridge::ResponseInfo content_length. After a long journey, this value is used in WebCore::ProgressTracker::incrementProgress.
Review URL: http://codereview.chromium.org/11394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are very very close to matching Windows metrics for buttons.
- Sort RenderThemeGtk.h declarations in the same
order as RenderThemeWin.h
- Sort RenderThemeGtk.cpp implementations in the
same order as declared in the header.
- Put all internal static helpers together.
- Merge in some comments and code from RenderThemeWin.
- Drop incorrect button style methods, when really we want
the default behavior instead.
- Use 11px Times New Roman for the layout test mode
system font.
- Switch to Mist as the default layout test theme.
This matches Windows much better, with square
buttons, etc.
- Sort the font list in test_shell_gtk.
Review URL: http://codereview.chromium.org/11390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove setButtonPadding, it was a private method that had no callers.
Review URL: http://codereview.chromium.org/11391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Linux try to match it.
- Remove trailing whitespace and extra newlines.
- Reorder some declarations in the header to
better group similar methods.
- Drop unimplemented declaration of addIntrinsicMargins.
- Implement the empty RenderThemeWin constructor and
destructor in the header file.
- Reorder all implementations to match declaration order.
- Move the enums into the anonymous namespace.
- Don't indent in an anonymous namespace.
- Move all internal static helpers together.
Review URL: http://codereview.chromium.org/11596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
just a baby step in getting RenderThemeGtk to be more like RenderThemeWin.
- Remove some cosmetic differences from prototypes.
- Remove the unused systemFont(X, X) from GTK.
- Make supportsFocus have internal linkage, there is no
RenderTheme::supportsFocus. This matches GTK.
Review URL: http://codereview.chromium.org/11591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
After a recent merge, port/dom no longer exists. The Windows build was updated, but scons was left in a non-building state.
Review URL: http://codereview.chromium.org/11387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
forwarded to the skia ones.
Review URL: http://codereview.chromium.org/11588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the cairo surface in the canvas's GdkSkiaObjet that matches the canvas's matrix translation. Change rendering of some other widgets (buttons, entry fields, etc) that were being translated manually.
Review URL: http://codereview.chromium.org/11562
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list (for things to be ported) to the add-to-input file list.
These ended up on the wrong list because we had really confusing
logic down at the bottom of SConscript.port, with multiple lists
and redundant conditional checks. So refactor the bottom to
collect all platform-specific logic behind single checks for
the platform, rearrange and rename lists to (hopefully) make it
easier to identify what goes where, and add comments.
Review URL: http://codereview.chromium.org/11361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deleted.
Review URL: http://codereview.chromium.org/11370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In response to an invalidation, we call into WebKit to do layout.
On Windows, WM_PAINT is a virtual message so any extra Invalidates that come
up while it's doing layout are implicitly swallowed as soon as we actually do
drawing via BeginPaint.
Though GTK does know how to collapse multiple paint requests, it won't erase
paint requests from the future when we start drawing. So the solution is to
track whether we're currently handling a redraw, and during that if we get told
by WebKit that a region has become invalid, we still add that region to the
local dirty rect but *don't* enqueue yet another "do a paint" message.
Review URL: http://codereview.chromium.org/11371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
there. This leaves forwarding headers in base/gfx, which I'll clean up in a future pass.
Review URL: http://codereview.chromium.org/11808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although you cannot see the blood, sweat and tears on this changelist,
know that they are there.
We still aren't quite perfect, but it's better.
Review URL: http://codereview.chromium.org/11344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/11529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
include guards of the moved files, but nothing else.
Review URL: http://codereview.chromium.org/11568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the memory model here was wrong. This moves to the Cairo way of doing things. (An alternative would be to change NativeImagePtr from a raw pointer to a ref-counting pointer, like the Mac does. This would ape the Mac API, which is perhaps more future-proof, at the cost of needless refcounting complexity [since SkBitmap internally refs its pixel data already].)
BUG=4298
Review URL: http://codereview.chromium.org/11580
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r5847.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
affect other platforms.
Review URL: http://codereview.chromium.org/11357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as a result of change r5829 to fix silverlight windowless plugin issues.
One of the changes was to return int32 as the variant type wherever applicable. Firefox does the same and Silverlight does rely on this behavior. This is broken in webkit. I will be filing a bug against webkit.
The fix is to support int32 as an incoming NPVariant type in the layout test plugin.
TBR=jam
Review URL: http://codereview.chromium.org/11574
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scrollbars to not overlap the in-window resizer widget.
Review URL: http://codereview.chromium.org/11353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
some of these sneaked in.
BUG=2053
Review URL: http://codereview.chromium.org/11801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has been added to this CB.
Fix Silverlight windowless plugin painting issues. This fixes the
following
issues:-
1. http://code.google.com/p/chromium/issues/detail?id=4272
2. http://code.google.com/p/chromium/issues/detail?id=301 (Partially)
The fixes are as below:-
1. Silverlight in the NPP_HandleEvent call for WM_PAINT,
calls NPN_GetProperty for a bunch of properties like
pageXOffset, pageYOffset, etc. It expects these
properties to have integer types on return. We always
return double. Firefox returns integer for these
properties. Added a check in the conversion
to NPVariant function in v8 to check for whether the
value is an integer and return the intger type.
2. When the windowless plugin calls NPN_InvalidateRect we
ask the plugin to paint in the same call, which the
Silverlight plugin does not like. It relies
on the fact that browsers would initiate invalidation
asynchronously and eventually paint. This is a perfectly
legal assumption. The Flash plugin does work if we
synchronously ask it to paint. However other plugins
could have similar issues. I verified with
worldofwarcraft.com to see if the async paint
has any sideeffects and there were none.
3.If the Silverlight plugin is not visible initially as on
msdn.microsoft.com, it does not paint. This occurs
because the plugin expects proper paints to
come from the browser. It does not invalidate itself in
UpdateGeometry as Flash. The plugin widget on msdn is not
dynamic. It does call NPN_InvalidateRect
initially when it is not visible. We don't send the call
to the renderer as the plugin is not visible. To workaround
this we now track the damaged rect even if the rect does not
intersect the clipping rect of the plugin. In a geometry update
if the plugin is visible, we send over the accumulated damaged rect
to the renderer.
The Silverlight plugin instance on msdn.microsoft.com does not work correctly
even with these fixes. However it paints correctly.
R=jam
Bug=4272,301
Review URL: http://codereview.chromium.org/11569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
normal browsing.
Review URL: http://codereview.chromium.org/11566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hadn't been added to the config) and extend use of LOAD= into submodules:
* Add a ChromeLoadSConscriptModules() method that encapsulates the
conditional logic, and makes things more readable by specifying
component names as keyword arguments, not hard-coding the logic
as a series of if-tests.
* Put the ChromeLoadSConscriptModules() logic in a Tool module in
site_scons/site_tools, so it doesn't clutter up
build/SConscript.main directly.
* Move env.WantSystemLib() calls into the individual *.scons files,
so we call them each time (or not, based one LOAD=) and the config
itself just returns if the system library is requested and we
don't need to build anything locally.
* Move the settings where a library name changes based on whether or
not the system lib is being used into the using_*.scons files,
so they're available to clients independently of whether or not the
component's *.scons configuration is loaded.
* While here: rename the affected third_party SConscript files:
third_party/libjpeg/SConscript => third_party/libjpeg/libjpeg.scons
third_party/libxml/SConscript => third_party/libxml/libxml.scons
third_party/libxslt/SConscript => third_party/libxslt/libxslt.scons
* While here: move the Chrome{Program,SharedLibrary}() etc. builder
definitions from build/SConscript.main to a new too
Ad the ChromeLoadSConscriptModules() logic in a Tool module,
to remove more clutter from build/SConscript.main.
Review URL: http://codereview.chromium.org/11430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5818 0039d316-1c4b-4281-b951-d872f2087c98
|