| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/16603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
animation methods to layout test controller.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
eventually do.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changed slightly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/16218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pauseTransitionAtTimeOnElementWithId to layout test controller so that
we can pass a couple of additional tests.
BUG=5801
TEST=none
Review URL: http://codereview.chromium.org/16216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The KeyboardCodes.h removal is to delete an unused file. The Mac build was already using the KeyboardCodes.h file from platform/chromium.
R=dglazkov
Review URL: http://codereview.chromium.org/16215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/16425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderThemeChromiumWin (for now)
R=darin
Review URL: http://codereview.chromium.org/16211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rebaseline button-default-title and control-clip. These
are form control differences.
Also move all the <input type=search> tests into a single
block with a bug.
Review URL: http://codereview.chromium.org/14878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change to webkit_glue::InitializeForTesting is to make it possible to just run the multipart tests using --gtest_filter.
R=tony
BUG=5786
Review URL: http://codereview.chromium.org/16420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MediaPlayerPrivateChromium.
TBR=dglazkov
Review URL: http://codereview.chromium.org/16419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/dom/Window/window-custom-prototype. This needs to be
rebaselined as the test checks for a specific exception string. V8
returns 'Cyclic' where as KJS returns 'cyclic.'
BUG=5725
TEST=none; this is a layout test change only.
Review URL: http://codereview.chromium.org/15096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/16801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Kill a gtest include in UniscribeHelper.h.
2. Kill a webkit_glue:: type used in MediaPlayerPrivateChromium.h
3. Remove the dummy MediaPlayerPrivateChromium.cpp, which has been superceded by webkit/glue/media_player_private_impl.cc
4. Cleanup some webkit style errors.
R=dglazkov
Review URL: http://codereview.chromium.org/16404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/16601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move files from platform/graphics into platform/animation and
platform/graphics/transforms and update include path
* Add stubs for two new methods in FrameLoaderClient
* Re-baseline one new layout test for Windows and add two to tests_fixable.
Review URL: http://codereview.chromium.org/14917
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eseidel
Review URL: http://codereview.chromium.org/16403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13770
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe this is not needed:
if (windowHeight == 0)
windowHeight = min(getRowHeight(-1), kMaxHeight);
windowHeight is dependent on the number of items within the popup, if you have
no items within the popup, it returns 0. I don't understand why we need to do
"min(getRowHeight(-1), kMaxHeight)" when its 0, that doesn't make sense to me.
Since getRowHeight gets the height of that item@index, everyone knows there are
no item for index -1 (hence crash).
Patch by Mohamed Mansour
R=darin
BUG=4334 (http://crbug.com/4334)
TEST=<select></select>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Introduce plaform/chromium/ChromiumUtilsWin and extend ChromiumBridge to access wrappers for uxtheme calls.
R=dglazkov
Review URL: http://codereview.chromium.org/15101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* get-set-properties: updated baseline that had been outdated by webkit change r39097
* document-open-return-value: changed document.open() to return this rather than null as per https://bugs.webkit.org/show_bug.cgi?id=14968
Review URL: http://codereview.chromium.org/14877
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
these pass on windows, dunno what's wrong.
TBR=eroman
Review URL: http://codereview.chromium.org/15094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I know why these ones are failing, just haven't finalized the right thing.
Review URL: http://codereview.chromium.org/14905
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to output the path data incorrectly (missing spaces between
numbers) and checked in baselines with the wrong output. Remove
the wrong output and either mark the test as passing or add a
comment to the tests_fixable list.
Review URL: http://codereview.chromium.org/14910
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
match WebKit style.
R=brettw
Review URL: http://codereview.chromium.org/15058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/13214
Review URL: http://codereview.chromium.org/14884
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of the .tiff version. Point testShell at the resources folder rather than the source tree for loading resources on Mac. Move ImageMac.cpp into the chromium port and give it a new name.
Review URL: http://codereview.chromium.org/14893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/14895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Firefox and IE here.
Review URL: http://codereview.chromium.org/14891
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
map.
Review URL: http://codereview.chromium.org/15074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(project files still to come). To wit:
* Solution file configuration is in *_sln.scons files (base\base_sln.scons,
chrome\chrome_sln.scons).
* Individual Project file configuration is in the the .scons file for
the relevant target (base\base_unittests.scons,
third_party\libxml\libxml.scons, etc.)--that is, where their file
lists will live.
* MSVSProject() calls are currently placeholders that establish
the existence of Project Nodes (and Project dependencies) but don't yet
have actual Project configuration information (file lists, .vsprops, etc.).
* Configuraiton is very manual. In particular, the entries in the .sln
file will be written out in exactly the order specified in the
configuration(s). The current ordering is taken from our existing
.sln files, so we can generate virtually the same configurations
on output.
* Generated solution files are nearly byte-for-byte identical
with our existing .sln files, modulo:
* net\dump_cache has a WebsiteProperties sections (making that
configurable per project isn't important right now);
* sandbox\sandbox.sln was missing a dependency of base.vcproj on
on debug_message.vcproj (present in other .sln files)
* webkit\webkit.sln was missing dependencies of WebCore.vcproj on
libxml_config.vcproj and libxslt_config.vcproj (present in
chrome.sln);
* add a handful of other miscellaneous missing dependencies on various
.vcproj definitions in chrome.sln (present in other .sln files).
* remove stats_viewer.csproj from chrome.sln (sorry, mbelshe),
which was complicating the solution configuration with unnecessary
(for us) "Mixed Platform" types;
* All MSVSFolder(), MSVSProject() and MSVSSolution() calls have
hard-wired guid= values taken from our existing configuration,
so we can: 1) verify generation of working configs; 2) minimize
diffs when checking in generated .sln files. We can remove
these in the future in favor of extracting them from existing
.sln files if we wish.
* Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution()
wrappers to chromium_builders.py, that gate the underlying call to
the env.MSVS*() builders based on whether env.Bit('msvs') is set
(i.e., we're in --mode=msvs).
* Remove platform-specific gating of to-be-ported .scons files that we
now need to load on any platform to generate coheren MSVS files.
Move the env.Bit('windows') tests for actually building their
executables into the individual .scons files.
Review URL: http://codereview.chromium.org/14472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Guess these slipped through. The new baselines not only pass but also look a lot closer to the windows baselines (i.e., only some font glyph differences).
Review URL: http://codereview.chromium.org/14880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
controller.
Fixes one new layout test.
Review URL: http://codereview.chromium.org/14871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new baseline for basic-shadows.html, it passes the fuzzer.
Update beforeSelectorOnCodeElement.html which crashes on the
buildbot.
TBR=evan
Review URL: http://codereview.chromium.org/14872
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
empty text-field:
- presses the up/down arrow key
- left-clicks it
The other browsers have that feature.
BUG=5130
TEST=See bug.
Review URL: http://codereview.chromium.org/14852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/14869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7268 0039d316-1c4b-4281-b951-d872f2087c98
|