| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
staying put for now, because they're all trivial and identical.
Review URL: http://codereview.chromium.org/1925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=1669
Re. Finding: When the SelectionController in WebKit doesn't give us a proper selection for the match found or a proper bounding box for the same we would not be able to set the Active tickmark nor mark that frame as a frame that contains the active tickmark. The latter causes the crash on Google Reader described in issue 1669 and also the crash with Malayalam unicode content found internally (bug 1341577). In the case of Reader, the Selection returned is not empty, but has a start and end set to 0.
When fixing this I noticed that if the first match we find specifies "-webkit-user-select: none" then no further matches will be found on the page. This is because we were changing the flag |found| to false in Find which causes the scoping effort to not start. What we should do instead is set the active rect to a default rect so that the scoping effort knows that we don't know what the active rect is. It will then mark the first match found on the page as active and continue scoping.
To recap on how Find works (since I know it has been a while since you looked at this problem):
Find will try to find the first match from a given point in the page. When something is found it will stop the find operation and start the scoping effort in the background for each frame. Scoping starts from the top of the frame, finds all matches and builds the tickmark vector per frame - in the process marking which tickmark is active. FindNext used to rely on the Scoping to mark the active frame, but now it is done in Find instead.
BUG=1341577
Review URL: http://codereview.chromium.org/1847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I will pursue making this change upstream as well,
but as best I can tell, this function is dead code upstream
and should just be deleted.
Review URL: http://codereview.chromium.org/1880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
with webkit_version.h. Remove duplicate file from glue target.
Review URL: http://codereview.chromium.org/1713
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The cause was that the DOM binding code didn't treat HTMLAppletElement as a plugin element.
I couldn't add a layout test because it requires Java plugin installed to run.
Review URL: http://codereview.chromium.org/1900
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1707
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1704
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1702
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Redo the fix of issue 1357667. Previous fix does not address all cases (HTMLLinkElement.sheet).
It works by create a hidden reference from JS wrapper of StyleSheet object to its owner node.
This is down when creating the JS wrapper object.
Add a test for HTMLLinkElement that crashes both Chrome and Safari 3.1.2.
Review URL: http://codereview.chromium.org/1678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1894
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1701
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header.
Review URL: http://codereview.chromium.org/1857
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make sure that customized properties set on window.location and window.navigator survive
GC. Matches Safari and Firefox's behaviors.
Review URL: http://codereview.chromium.org/1884
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1872
Patch from James Vega <vega.james@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is an issue with the shockwave game not loading.
The plugin issues a number of geturlnotify requests. Some of these requests
come in with response headers without the content length. We would pass in -1
in the NPStream passed down to the plugin. As the end field in the NPStream
structure is an unsigned integer, the plugin would expect more data to arrive
and hence the issue.
The fix is to emulate Safari behavior and set the end field to 0 if the length
is -1.
Bug=643
Review URL: http://codereview.chromium.org/1676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
by gcc 4.2:
warning: 'C' has a field 'C::m_' whose type uses the anonymous namespace
warning: missing braces around initializer for 'S'
error: extra qualification 'C::' on member 'm'
Review URL: http://codereview.chromium.org/1675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
temporary boostraping measure.
Review URL: http://codereview.chromium.org/1854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1818
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
conversions.
Review URL: http://codereview.chromium.org/253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1832
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1643
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Removes currently-broken targets from webkit.xcodeproj (port, glue).
Adds an All target to project files with multiple targets (googleurl.xcodeproj).
Brings our xcconfigs to lzma_sdk.xcodeproj (formerly 7z_C.xcodeproj).
Review URL: http://codereview.chromium.org/2001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which does the right thing based on whatever platform we're
compiling for, along with changing the hardcoded "stdext::",
which is a MSVC++ism to use base::hash_{map,set}.
B=1869
Review URL: http://codereview.chromium.org/1629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
related to non-virtual destructors in classes having virtual methods
BUG=1859
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This occurs on YouTube when the user moves the slider to advance the video. Flash is doing this to inform the browser that it should cancel the existing stream. Without handling this error, we end up downloading the video multiple times from multiple offsets. After the user moves the slider 6 times, we will end up having saturated the maximum of 6 connections per host, and then YouTube video playback will appear to be wedged.
R=joshia
Review URL: http://codereview.chromium.org/1622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This picks up the "in" operator fix that was made in branches/v8_bleeding@117.
$ svn log -r 102:138 http://v8.googlecode.com/svn/trunk
------------------------------------------------------------------------
r138 | ager@chromium.org | 2008-09-04 06:52:27 -0700 (Thu, 04 Sep 2008) | 10 lines
Added support for running tests on the ARM simulator.
Fixed bug in the 'in' operator where negative indices were not treated correctly.
Fixed build issues on gcc-4.3.1.
Changed Date.prototype.toLocaleTimeString to not print the timezone part of the time.
Renamed debug.h to v8-debug.h to reduce the risk of name conflicts with user code.
------------------------------------------------------------------------
Review URL: http://codereview.chromium.org/1602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Fix include path used for wtf target: need to put JavaScriptCore/kjs before
generated/WebCore in order for the wtf target to pick up the correct
config.h (this was the source of the WTF_CHANGES confusion)
Review URL: http://codereview.chromium.org/1801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1816 0039d316-1c4b-4281-b951-d872f2087c98
|