| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
windows."
This reverts commit 9c23aa9006918e7091742e1826181db081a16a65.
TBR=evan
Review URL: http://codereview.chromium.org/101020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The code still crashes when trying to play a video, but this will allow debugging.
Review URL: http://codereview.chromium.org/100195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for file download via context-menu.
For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later.
Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu).
If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage).
This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following:
1. RFC 2047
2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage.
3. %-escaped UTF-8.
In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests.
BUG=1148
TEST=net unit test: NetUtilTest.GetFileNameFromCD
NetUtilTest.GetSuggestedFilename
unittest : DownloadManagerTest.TestDownloadFilename
Review URL: http://codereview.chromium.org/83002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rest of the WebKit API, which is single threaded. Also a bunch of small fixes to make layout tests pass: the dll was being unloaded while its functions were still queued to be dispatched, and a string allocated in the dll was being GC'd in test shell.
BUG=11011
Review URL: http://codereview.chromium.org/102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin's windowproc, otherwise if it ends up dispatching another message to itself we'll hit the NOTREACHED at the beginning of the function.
Review URL: http://codereview.chromium.org/99267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically:
1) In webkit.gyp and test_shell.gyp, convert the rules to actions because of different grd outputs (localized grd files have locale in the .pak filename).
2) In chrome, make two targets each with a custom rule. One target is for localized resources, the other for non-localized resources. This is like the current windows build.
Review URL: http://codereview.chromium.org/100174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11263
TEST=Go to any page and then click on a link to navigate to a new page.
Review URL: http://codereview.chromium.org/99263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(https://bugs.webkit.org/show_bug.cgi?id=25347).TBR=yurys
Review URL: http://codereview.chromium.org/99274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
happening, so it seems unlikely that this is a reference counting
problem.
BUG=9746
Review URL: http://codereview.chromium.org/100247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
issue by adding the style declaration wrappers to the object groups of
the elements they belong to.
Review URL: http://codereview.chromium.org/100204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=11264
Integer 0 and -1 have special meaning in HashMap<int, ...>, both cannot be used as key.
Specially filter out these two keys.
Review URL: http://codereview.chromium.org/100242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3285.
A NPObject can be called as a construct if it implements NPN_Construct, and NOT implements
NPN_InvokeDefault. Otherwise, NPN_InvokeDefault is called even when the object is called
as a constructor.
Review URL: http://codereview.chromium.org/56167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally marked mac/linux as crash when I really wanted to mark win
BUG=11264
TBR=dglazkov
Review URL: http://codereview.chromium.org/100239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=11264
TBR=dglazkov
Review URL: http://codereview.chromium.org/100235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Activex shim for media player along with their associated extensions.
This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source
URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime
and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the
mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin
from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message.
With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player
handling it in Chrome.
I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it.
Added plugin tests for the mp3 and mpe extensions.
Bug=11054
Review URL: http://codereview.chromium.org/100180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/43092.
R=levin
BUG=10898
TEST=0
Review URL: http://codereview.chromium.org/100227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebKit gurus, please review the change carefully, WTF::HashMap interface is not well documented, so I have implement
customized hash functions and HashTraits in order to use StringKey as the hash key.
Review URL: http://codereview.chromium.org/100069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
test_shell on linux/mac.
Review URL: http://codereview.chromium.org/100216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used for gears file drag & drop in chrome, define the values of
the drop effect overrides to match the gears definitions.
BUG=7995
Original patch by Noel Gordon via:
http://codereview.chromium.org/99231
Review URL: http://codereview.chromium.org/102016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
of Windows file & string manipulation, enable plugin tests on the Mac.
Review URL: http://codereview.chromium.org/102014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
2. Function actual parameters are not shown in the call stack panel because they are alredy displayed in the scopes panel.
Review URL: http://codereview.chromium.org/99185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, "Alt" key will set both alt and meta is on (issue 2215).
But Alt-Gr is used to insert alternate character.
BUG=10846
Review URL: http://codereview.chromium.org/99216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On translate.google.com, it fails to show balloon, because of JavaScript
exception in following code:
p=a.getClientRects(); ... p[0].top // p[0] is undefined!
Current v8 binding misses indexed access method in ClientRectList.
CSSOM View Module draft says
http://dev.w3.org/csswg/cssom-view/#clientrectlist
In ECMAScript implimentations, objects that implement the ClientRectList
interface must also have a [[GET]] method that, when invoked with a number,
acts like the item() method would when invoked with that argument.
BUG=10697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>.
In WebKit, EditorClient::handleKeyboardEvent in
WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drops such events.
On Mac, it emits key events with ASCII text and meta is on for Command-<x>.
These key events should not emit text insert event.
Alt key would be used to insert alternative character, so we should let through.
Ctrl-Alt combination may equal to AltGr key, which is also used to insert
alternative character.
In summary, we can't think of a scenario where you'd use control(w/o alt) or
meta to do insertion of a ASCII character.
BUG=10846,11070,11165
Review URL: http://codereview.chromium.org/99209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also rebaseline another SVG test since eseidel says our result looks ok.
Review URL: http://codereview.chromium.org/100187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
still pass on my machine.
TBR=evan
Review URL: http://codereview.chromium.org/100185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
activeDocumentLoader's url, not the document's current URL.
BUG=10924
Review URL: http://codereview.chromium.org/92090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10353,10400
Review URL: http://codereview.chromium.org/99158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between debugging sessions.
Review URL: http://codereview.chromium.org/100159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Split inject.js into injected object and the dispatch.
2. Surround utility function call with try/catch, pass potential exception all way to the client.
3. Fix user and user agent scripts detection
4. Introduce toggleStyle
5. Remove __defineGetter__ from the styles code: make things simple
6. Beautify code.
Review URL: http://codereview.chromium.org/99184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
external V8 strings.
We seem to be occasionally losing the data for our external strings.
The current hypothesis is that there is a reference counting bug in
WebCore somewhere which is leading to premature deletion of the string
data. This change is an attempt to verify that this is in fact the
case. By artificially increasing the ref count on the strings, we
should reduce the likelihood of accidental deletion because of ref
counting being slightly off. If we can confirm that this removes most
of the crashes, we know that the problem is WebCore ref counting
related.
BUG=9746
Review URL: http://codereview.chromium.org/99174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14837 0039d316-1c4b-4281-b951-d872f2087c98
|