| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
routing id directly. This simplifies the renderer code and also allow this code to be used in worker processes, where we don't have a frame.
Review URL: http://codereview.chromium.org/46026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Our old baseline was wrong. We now on par with the mac
expected output (only differ in font metrics).
Review URL: http://codereview.chromium.org/48020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DevToolsAgent now implements WebDevToolsAgentDelegate, DevToolsClient covers WebDevToolsClientDelegate.
WebDevToolsAgent instance is being created by the WebView early in the init code and belongs to it. WebView exposes interface for accessing the agent; it also extends its delegate interface to pass WebDevToolsAgentDelegate into it.
Note that there is no call overhead unless particular sub-agents are enabled in the WebDevToolsAgent.
WebDevToolsClient instance is being created externally by the DevToolsClient.
Review URL: http://codereview.chromium.org/46032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(note: this change now requires a P4 to build. It's easy to back it
out for older processors, but they shouldn't be used to run
layout-tests.)
We are seeing issues where the opt build ends up with very slightly
different colours in layout tests than the debug build. This is
probably due to floating point rounding differences.
All floating-point computations on x87 happens in 80-bit precision.
Because the C and C++ language standards allow the compiler to keep
the floating-point values in higher precision than what's specified in
the source and doing so is more efficient than constantly rounding up
to 64-bit or 32-bit precision as specified in the source, the
compiler, especially in the optimized mode, tries very hard to keep
values in x87 floating-point stack (in 80-bit precision) as long as
possible. This has important side effects, that the real value used in
computation may change depending on how the compiler did the
optimization - that is, the value kept in 80-bit is different than the
value rounded down to 64-bit or 32-bit. There are possible compiler
options to make this behavior consistent (e.g. -ffloat-store would
keep all floating-values in the memory, thus force them to be rounded
to its original precision) but they have significant runtime
performance penalty.
-mfpmath=sse -msse2 makes the compiler use SSE instructions which keep
floating-point values in SSE registers in its native precision (32-bit
for single precision, and 64-bit for double precision values). This
means the floating-point value used during computation does not change
depending on how the compiler optimized the code, since the value is
always kept in its specified precision.
Internal performace tests of these options shows that it's not a clear
performance win or loss across the board.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We will pull this out again once the dev channel release has been cut.
We need to get this in the dev channel release to have the new
infrastructure tested in the real world.
Review URL: http://codereview.chromium.org/42234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the process of being upstreamed and don't crash. patternRegions.svg
was listed as crashing, but I believe this comment was wrong as it
hasn't crashed in the last 20 runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Except transform-absolute-in-positioned-container.html which was fixed with r11135 on Windows (and Mac also).
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/48002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also add back anchor-toString-expected.txt.
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/42222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update test_fixable with some linux failures.
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/46102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Part 2. Same comments as before, but it was broken up
in order to do the code review upload.
Review URL: http://codereview.chromium.org/46100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Part 3. Same comments as before, but it was broken up
in order to do the code review upload.
Review URL: http://codereview.chromium.org/46101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit\tools\webcore_unit_tests\TransparencyWin_unittest.cpp
were necessary due to http://trac.webkit.org/changeset/41692
LayoutTests\editing\pasteboard\paste-blockquote-into-blockquote-4.html
LayoutTests\editing\pasteboard\paste-blockquote-into-blockquote.html
were rebaselined due to http://trac.webkit.org/changeset/41677
chrome\fast\dom\Window\window-lookup-precedence.html
was rebaselined due to http://trac.webkit.org/changeset/41671
Many layout tests were rebaselined due to the skia change in
http://trac.webkit.org/changeset/41683
Review URL: http://codereview.chromium.org/46099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42213
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/42213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Layout tests changes (and baselines):
* LayoutTests/fast/css/font-face-default-font.html
Fixed by aa upstream. The change was in the test itself.
* LayoutTests/fast/replaced/width100percent-searchfield.html
Fixed by levin upstream -- the themeChromiumWin.css change.
* LayoutTests/fast/forms/input-appearance-height.html
* LayoutTests/fast/repaint/search-field-cancel.html
Rebase needed due to themeChromiumWin.css change
* LayoutTests/fast/layers/normal-flow-hit-test.html
A slightly different font seems to be used in chromium which
casued some pixel differences in this test.
* LayoutTests/fast/forms/placeholder-pseudo-style.html
* LayoutTests/fast/forms/search-placeholder-value-changed.html
New tests which needed chromium baselines due to differences
in the search input box display.
* LayoutTests/fast/forms/placeholder-set-value.html
Differences in fonts and search input boxes were the cause
for the chromium baseline.
Review URL: http://codereview.chromium.org/46071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a text-field, even if the text-field is not empty.
BUG=6437
TEST=Open a form with several fields. Start entering text in a text field to bring-up the autocomplete popup. Click somewhere else (so the popup is closed). Click again in the text-field (at the end). On the 2nd click the autocomplete popup should show.
Review URL: http://codereview.chromium.org/42198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR.
Review URL: http://codereview.chromium.org/46070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Ours looks more correct according to me, brettw
- The difference was only on the red shadows, ours is now more graual, 6 color steps instead of 4 steps
Review URL: http://codereview.chromium.org/45008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"try multiple commits" feature.
Review URL: http://codereview.chromium.org/46062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In response to Dean's comment on http://codereview.chromium.org/39105,
I redid that patch to put the X munging into the plugin implementation. This
won't work for multiproc, but it's near the correct place and many things will
need to be changed for multiproc.
Review URL: http://codereview.chromium.org/42056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the
feeds in the document and notify the browser to
display the RSS icon in the toolbar. You can
click on the icon, but it will just navigate to
the first feed on the page, which (unless it has
been designed to be browser friendly) will just
dump XML as text on the user.
For this reason I have disabled the code that
makes the RSS icon appear and intend to enable
it when we have a good landing page to display
the XML.
Review URL: http://codereview.chromium.org/46055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is the fix of tweaks to the GYP files needed to build test_shell.
Review URL: http://codereview.chromium.org/42179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The current result looks more correct than Safari and the previous results.
I have checked the results against Batik.
Review URL: http://codereview.chromium.org/46049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Chrome uses a black rectangle instead. It's not clear what to do here, so defer this test for now.
Review URL: http://codereview.chromium.org/42064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Added entry to ResourceResponseHead so that it contains
either a base::PlatformFile (OS_WIN) or
base::FileDescriptor (OS_POSIX) for passing the file
handle from browser to renderer process.
2. Also added IPC messages for reporting download progress
and ACK message for it. ResourceLoaderBridge::Peer::OnDownloadProgress
is added so that the peer is notified of the download
progress in the renderer process.
3. Load flag to kick start the resource loading for media
files. LOAD_MEDIA_RESOURCE is added so that
ResourceDispatcherHost knows how to use a different
ResourceHandler for handling media resource request.
Review URL: http://codereview.chromium.org/27168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I snagged the wrong rev last time.
Reverting back to 11622, which had the comment:
---------------
r11622 | ager@chromium.org | 2009-03-12 23:53:03 -0700 (Thu, 12 Mar 2009) | 6 lines
Update V8 to version 1.1.1.
Contains a couple of layout tests rebaselines.
This time contains an updated gyp file for the mac build.
Review URL: http://codereview.chromium.org/43134
---------------
This also includes the other file change in 11624:
---------------
r11624 | ager@chromium.org | 2009-03-13 02:17:01 -0700 (Fri, 13 Mar 2009) | 6 li
nes
Update V8 to fix an assertion that does not hold.
Add test that tests arbitrary limits on expressions that can be
handled without stack overflows to the test list. I have filed a bug
report and Kevin is investigating.
Review URL: http://codereview.chromium.org/46029
---------------
trb=darin,ager
Review URL: http://codereview.chromium.org/46048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to ~400.
Review URL: http://codereview.chromium.org/46039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reverting for now. Will try again later
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
really silly to have them be separate classes.
I chose to eliminate WebDocumentLoaderImpl in favor of WebDataSourceImpl since
the interface that the outside world sees is named WebDataSource.
R=dglazkov
Review URL: http://codereview.chromium.org/46028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove NAMED_PROPERTY_SETTER interceptor for HTMLDocument.
Review URL: http://codereview.chromium.org/42157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Objective-C names in our libwebcore.a by giving our Objective-C WebCore
classes alternate names.
Review URL: http://codereview.chromium.org/43094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
intersect;
- Implement tests for DevToolsRpc
- Do not import PlatformString in headers
Review URL: http://codereview.chromium.org/43141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
overflow test.
TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/46031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add test that tests arbitrary limits on expressions that can be
handled without stack overflows to the test list. I have filed a bug
report and Kevin is investigating.
Review URL: http://codereview.chromium.org/46029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Both pass for windows when given a new baseline which maybe all
they need for these OSes as well.
Review URL: http://codereview.chromium.org/46027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Contains a couple of layout tests rebaselines.
This time contains an updated gyp file for the mac build.
Review URL: http://codereview.chromium.org/43134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit\port\bindings\v8, webkit\build files
These are all adjustments to use the recently upstreamed V8Events files.
percent-top-value-with-relative-position-expected
This is a new test that has the same result in chromium but uses a slightly
different font to display it, so pixels and coordinates were also different.
search-field-cancel-expected
This is a new test that verifies the visual aspects of the search field.
Since chromium doesn't implement this field in a special way, chromium's
results are expected to be different.
Review URL: http://codereview.chromium.org/42163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe it fails because we are not painting after a load has completed in a frame as DumpRenderTree does.
I am still not sure though why it passes on Linux/Mac.
I put my findings in http://crbug.com/8729.
Review URL: http://codereview.chromium.org/42160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
|