| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apache-needing test.
TBR=tkent
TEST=none
BUG=10353
BUG=11795
Review URL: http://codereview.chromium.org/552197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable socket late binding. The mac valgrind errors happened due to threading bugs in test_shell_tests. The ui thread would TearDown() the test object, which deleted the TestURLRequestContext, which eventually deletes the TCPClientSocketPool, which deletes its ConnectJobs. However, those ConnectJobs might be running simultaneously on the io thread. Therefore, we have a race condition. This change fixes that.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/549093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/554102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thursday or so).
BUG=3244
BUG=10305
TEST=svg/custom/mask-excessive-malloc.svg
TEST=svg/custom/use-instanceRoot-as-event-target.xhtml
R=jorlow@chromium.org
Review URL: http://codereview.chromium.org/555119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
font differences between Vista and Win 7).
BUG=none
TEST=svg/W3C-SVG-1.1/masking-intro-01-f.svg
TEST=fast/text/atsui-spacing-features.html
TEST=fast/text/cg-vs-atsui.html
TEST=svg/W3C-SVG-1.1/filters-conv-01-f.svg
TEST=svg/text/text-fonts-01-t.svg
TEST=svg/text/text-intro-05-t.svg
R=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/555122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=33287
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/556045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
command buffer code compiled into DLLs. Other platforms use the pthreads API. This is because the __declspec(thread) approach does not on some platforms, including Windows XP and Mac.
This is used for thread local pointers to the GL and PGL contexts. This unfortunate because the PGL and GL APIs do not generally explicitly reference a context. The current context is set with a call to pglMakeCurrent.
An unfortunate consequence is that now in Pepper plugins, every call to a GL function will call TlsGetValue to get the thread's current context, which could have performance issues.
I can't use base::ThreadLocalPointer because this code is compiled into an untrusted NaCl module and we don't want Chromium dependencies.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/553050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/551170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpranke
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/549179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/558004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect this will be a flaky test.
TBR=victorw
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/553121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/552191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=none
BUG=33045
Review URL: http://codereview.chromium.org/556044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=none
BUG=33045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=not anymore!
Review URL: http://codereview.chromium.org/554088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28062
Review URL: http://codereview.chromium.org/549173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change images where copied inline in IPC messages on non-Windows platforms. Copying an oversized image would cause the IPC system to bork and crash the renderer.
Changes in this CL:
* All platforms use a unified mechanism to copy images using shared memory.
* Introduced a new IPC message so the renderer can allocated a shared memory segment on OS X.
* On OS X tried to keep as few copies of the image data in memory as possible.
BUG=26822
TEST=1)On all platforms: navigate to a webpage, right click on an image and copy. Then try pasting into an image editor. 2)Repro steps in bug should no longer crash the Renderer on Mac/Linux
Review URL: http://codereview.chromium.org/552129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows Debug.
Test seems to pass continuously on Mac -> remove from test_expectations.txt.
(see http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=tables/mozilla/bugs/bug28341.html)
BUG=32231
TEST=tables/mozilla/bugs/bug28341.html
Review URL: http://codereview.chromium.org/557015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I forgot changing the test result for "LayoutTests/editing/pasteboard/paste-xml.xhtml" since my r37241 also fixes its output image.
TBR=dglazkov
BUG=none
Review URL: http://codereview.chromium.org/555128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a MockSpellCheck class, a mock implementation of our SpellCheck class, to test_shell so we can render dotted-underlines to misspelled words.
Unfortunately, this class is currently enabled only on Mac since it needs rebaselines on Windows and Linux.
BUG=11577,23497
TEST=run run_webkit_tests.sh on Mac
Review URL: http://codereview.chromium.org/493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r53844, and we don't need to do rebaseline for it.
BUG=10353
TEST=LayoutTests/fast/forms/textarea-rows-cols.html
Review URL: http://codereview.chromium.org/557013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/554085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run_webkit_tests doesn't complain about missing tests
R=jorlow@chromium.org
Review URL: http://codereview.chromium.org/553112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33195
TBR=darin
Review URL: http://codereview.chromium.org/555117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9962
Review URL: http://codereview.chromium.org/557008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31846
TEST=None (automated tests will follow once the event-faking infrastructure is in place on the Mac)
Review URL: http://codereview.chromium.org/555107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32996
TEST=Mouseover and drag should work correctly in Google Earth and Flash 10.1.
Review URL: http://codereview.chromium.org/551154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This matches Mozilla, which uses ~/.mozilla/plugins.
BUG=22261
TEST=watch an strace, see that it hits the appropriate dir when loading plugins
Review URL: http://codereview.chromium.org/553102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with PEP-8 in preparation for upstreaming this code to webkit.org.
This change was done by running the pep8_names.py script I wrote (
attached to https://bugs.webkit.org/show_bug.cgi?id=31498) with the following
command-line parameters:
% ./pep8_names.py -i --acronym WebKit --acronym LigHTTPd --acronym WDiff \
--acronym BuildBot *.py */*.py
The code was then reformatted to fit the 79-character line limit.
BUG=23099
TEST=none
R=levin@chromium.org
Review URL: http://codereview.chromium.org/553089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test does not specify platform option.
This is a temp solution for rebaselining tool. Need to remove the check once we have more reliable Win7 and Vista builtbot.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/553101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
side of patch]
BUG=25831
TEST=none
Review URL: http://codereview.chromium.org/554004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/552161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/555100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=awalker
Review URL: http://codereview.chromium.org/553094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=awalker
Review URL: http://codereview.chromium.org/551151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/552151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that main page script is present when the tab is shown.
BUG=33107
TBR=pfeldman
Review URL: http://codereview.chromium.org/553086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33045
TBR=darin
Review URL: http://codereview.chromium.org/555095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A portability issue of select-item-background-clip.html was fixed by
WebKit 53820. So, doing rebaseline for it. Expectation images for
Windwos and Linux now have clipped purple boxes correctly.
BUG=10353
TEST=These are tests.
Review URL: http://codereview.chromium.org/546143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When https://bugs.webkit.org/show_bug.cgi?id=33865#c2 comes downstream
this patch will need to get landed as well to remove the failure
expectations for the test.
BUG=32408
TEST=svg/custom/stroke-width-click.svg
TBR=gdk
Review URL: http://codereview.chromium.org/551147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restore the pre-reorganization order of these calls, since they make more sense this way.
Probably not actually the cause of bug 32749, but it's *possible* that events were getting in at the wrong time and causing the plugin to behave badly.
BUG=32749
TEST=none
Review URL: http://codereview.chromium.org/556015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
TEST=none
BUG=32695
Review URL: http://codereview.chromium.org/552145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
TEST=none
BUG=32950
BUG=32929
BUG=32951
Review URL: http://codereview.chromium.org/554068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is CL 36399 that was reverted in 36969 because it caused an ICE on the official builders.
This adds a workaround for the ICE.
Review URL: http://codereview.chromium.org/546136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpranke
TEST=rebaseline.bat works again!
BUG=none
Review URL: http://codereview.chromium.org/555086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prepare for flames
TEST=none
BUG=non
Review URL: http://codereview.chromium.org/552138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkitpy/layout_tests/layout_package/http_server.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/553074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37047 0039d316-1c4b-4281-b951-d872f2087c98
|