| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18969,18970
TEST=none
Review URL: http://codereview.chromium.org/164356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added TIMEOUT to one video test that I missed in r23407.
Also, added some temporary exceptions to test_expectations.txt
while I investigate and fix or file appropriate bugs.
TEST=None
BUG=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/165515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that Tab2OutOfTabStrip is failing consistently after this change.
BUG=None
TEST=None
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/164543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47214 remove timeout handling
that was happening within the test and now it uses relies on
the normal code path. In other words, these were timing out before
but now test shell knows they are timing out.
BUG=None, These tests already had bug on them.
TEST=None
Review URL: http://codereview.chromium.org/165509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reduce a dependency on ATL.
BUG=5023
TEST=Uninstall flash. Visit hulu.com and install the flash plugin.
Review URL: http://codereview.chromium.org/165469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The layout test failures happened on other platforms too.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(take two, this caused layout test failures which I missed the first time.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InspectorController::clearConsole call.
Landing for pfeldman@chromium.org
TBR=mnaganov
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/165498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
these changes so the only effect is to confuse potential test failure reviewers.
One other bad PNG was checked in, src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png , but it was checked in with a checksum and I am hoping dglazkov will handle it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10463,10760
TEST=none
Review URL: http://codereview.chromium.org/165491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
operations on an absolute path. This causes the script to infinite loop. Fix by doing them on a relative path instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
image one. The differences look OK to me.
TBR=sidchat
BUG=10463
TEST=none
Review URL: http://codereview.chromium.org/165487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not an invariant. I thought it was when writing the test, but after some perusal of the decoders and thought, I think the GIF and ICO decoders both can legitimately fail this condition sometimes.
BUG=19263
TEST=none
Review URL: http://codereview.chromium.org/164506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=www.crbug.com/10463
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and later removed in rev 19669. From the original commit message:
Rev 12100 changed the way that we spool and render printed output, most notably
introducing use of the PrintContext class. The existing
PrintContext::spoolPage() method applies a webkit scaling factor before
rendering output to the graphics context. ChromePrintContext::spoolPage() (in
webframe_impl.cc), which is used by chromium instead of
PrintContext::spoolPage(), does not apply this scaling factor, but instead
eventually returns the scaling factor via WebFrame::PrintPage(). This is a
problem for the Chromium Embedded Framework (CEF) because, unlike chromium, the
CEF renders directly to the printer device context. It is therefore important
for CEF that we retrieve and apply the webkit scaling factor before calling
PrintPage(). In order to support this capability the following adds a
WebFrame::GetPrintPageShrink() method.
Patch by Marshall Greenblatt
R=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18988
TEST=None, since this is currently redundant with the plugin whitelist
Review URL: http://codereview.chromium.org/164487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/164450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On the Mac, Flash appears to cache the CGContextRef provided in NPP_SetWindow until the next NPP_SetWindow call, so we need to call it sometime before the next plugin paint. This allows us to call NPP_SetWindow before telling the plugin to paint, but not from the Paint function itself (where it could have bad side-effects).
BUG=18894,18980
TEST=Switch to HQ on a YouTube video; Flash should not crash.
Review URL: http://codereview.chromium.org/165344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test_expectations for some others.
BUG=8635,10281,10435,10463
TEST=none
Review URL: http://codereview.chromium.org/164455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appearent reason.
[ RUN ] ICOImageDecoderTest.ChunkedDecoding
C:\b\slave\chromium-rel-xp\build\src\webkit\tools\test_shell\image_decoder_unittest.cc(158): error: Expected: (static_cast<WebCore::RGBA32Buffer*>(0)) != (decoder->frameBufferAtIndex(0)), actual: (null) vs (null)
C:\b\slave\chromium-rel-xp\build\src\webkit\data\ico_decoder\1bit.ico
[ FAILED ] ICOImageDecoderTest.ChunkedDecoding (16 ms)
BUG=19263
TEST=none
TBR=hbono
Review URL: http://codereview.chromium.org/165458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add dummy expectations for tests under investigation to allow
the layout tests to be able to be skipped (and not fail due to
missing expectations).
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/165450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which just appeared with the latest roll of webkit (on Linux)
Add temporary exceptions to test_expectations.txt
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/164471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"ICOImageDecoderTest.ChunkedDecoding" started failing since this change.
Review URL: http://codereview.chromium.org/164468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/164467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change checks if the modifier flag is a WebInputEvent::MetaKey flag to switch the scroll granularity when a user types a up/down key.
Editor::Commands ("MoveToBeginningOfDocument" and "MoveToEndOfDocument") works only in an editable control, such as <textarea>. On the other hand, this WebViewImpl::ScrollViewWithKeyboard() is for scrolling a page.
BUG=18844 "Apple (command) key + down arrow is not working"
TEST=Type command+down keys in a web page which contains a scroll bar, and verify Chrome scrolls the page to its end.
Review URL: http://codereview.chromium.org/164309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18677
We do range request for <video> and <audio>, we used
to destroy the ResourceLoaderBridge right after we
cancel the request. But it turns out that this would
leave an excessive amount of warnings in the renderer
and also leaking of URLRequest in the browser.
By refcounting BufferedResourceLoader (the container
of ResourceLoaderBridge) that does resource loading
for <video>, we can then destroy the
ResourceLoaderBridge after request has completed.
Review URL: http://codereview.chromium.org/164361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new method HasEnded() was added to renderer interfaces. Renderers return true when they have both received and rendered an end-of-stream buffer. For audio this translates to sending the very last buffer to the hardware. For video this translates to displaying a black frame after the very last frame has been displayed.
Renderers can notify the pipeline that the value of HasEnded() has changed to true via FilterHost::NotifyEnded(). Instead of tracking which renderers have called NotifyEnded(), the pipeline uses the notification to poll every renderer. The ended callback will only be executed once every renderer returns true for HasEnded(). This has a nice benefit of being able to ignore extra NotifyEnded() calls if we already determine the pipeline has ended.
With the changes to WebMediaPlayerImpl, we should now properly support both the ended event and looping.
BUG=16768,17970,18433,18846
TEST=media_unittests, media layout tests, ended event, timeupdate should stop firing, looping should work, seeking after video ends
Review URL: http://codereview.chromium.org/164403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change causes us to match the behavior of Windows and Linux, and it also
better conforms to the API (closeWidgetSoon) which does not expect things to be
synchronously closed.
Note: I do not believe it is important to null out shell_, so I deleted that
line. The other platforms are similar.
R=smorgan
BUG=19205
TEST=covered by existing layout tests
Review URL: http://codereview.chromium.org/164431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and Chromium's definitions of LOG. This is necessary after WebKit r47092
exposed its LOG in a few more places.
BUG=0
TEST=WebKit Canaries come back to life
Review URL: http://codereview.chromium.org/164421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled, but the run-time flag is disabled.
1) Added a new class WebApplicationCacheHost and a factory method on WebKitClient.
2) Provide an implementation of WebCore's ApplicationCachHost class that calls out to chrome thru the new WebKit API.
3) Added new files to gyp and turned on the compile-time ENABLE(OFFLINE_WEB_APPLICATIONS) flag.
4) Turned on the compile-time flag for v8 bindings in build-generated-files.sh
4) Disabled the run-time appliation_cache_enabled settings in the test shell for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This feature is better implemented as an extension rather than being put into
the absolute-core UI.
Review URL: http://codereview.chromium.org/164301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cross-platform file that is not used for CG.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17400
Review URL: http://codereview.chromium.org/164318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac, when trying to connect to 255.255.255.255, we get an EACCES error. I
don't think it is correct for me to map that to ERR_ADDRESS_INVALID or
ERR_ADDRESS_UNREACHABLE, so I'm going to map it to ERR_ACCESS_DENIED. This
means that I need to rebaseline the chromium-mac results for these tests.
I think it is okay to have platform specific behavior here. I kind of prefer
that the error codes we show are more closely in sync with the operating
system. That way it may be easier for a sophisticated user to make sense of
our error codes.
R=wtc
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/164114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
reports (flakyness, failures) from the buildbot.
Review URL: http://codereview.chromium.org/165343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code to actually turn it on is still commented out (and will remain so
until the rebaselining tool works as well).
BUG=none
R=pam@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/165337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
throughto preferences and webcore settings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifying this option will output a CSV-delimited table of layout test
files and the platform directories where their results are located.
Refactor path_utils.ExpectedFilename() into a separate routine to split
the results files into top-of-platform dir + relative path accordingly.
BUG=none
R=pam@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/164299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and proyxservice.This dependency comes from the parent URLRequest, and is used as a container for per-request profiling data.This change is strictly a no-op refactor -- the parameter is unused, and LoadLog does nothing.BUG=http://crbug.com/14478TEST=none -- just needs to compile and pass existing tests.DESIGN=<http://docs.google.com/Doc?id=dfhcnb2v_21gbtrcpr3&hl=en>
Review URL: http://codereview.chromium.org/126303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* use full paths in includes
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
like this in the WebKit API.
The only consumer was TestShell. It was using this method to replace its
TestWebViewDelegate instance. Instead, with this change, it has a manual Reset
method. To avoid duplication with the constructor, Reset uses operator=().
This required a couple changes:
1- Remove DISALLOW_COPY_AND_ASSIGN from WebViewDelegate. Anyways, that didn't
make sense since you cannot 'copy' a class with pure virtual methods.
2- Change scoped_ptr members of TestWebViewDelegate to linked_ptr. The extra
overhead of the linked_ptr seems warranted in this case.
I also changed TestWebViewDelegate to not be reference counted since it wasn't
necessary.
Finally, to get this to work on Linux, I needed to revise the shutdown paths
for WebWidgetHost. The problem is that the code wants to support destroying a
WebWidgetHost directly by having its destructor called or indirectly by having
a "destroy" signal handler notice destruction of the GtkWidget. This actually
mirrors the Windows version as well, and so just like the Windows version I
added a level of indirection to get from the GtkWidget to the WebWidgetHost.
However, I only apply this indirection to the "destroy" signal handler.
R=tony
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15217, 4363, 9798, 18978
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/164292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
subclass. There's no reason for these to be virtual since they can only be
called by a subclass.
R=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by viettrungluu.
BUG=http://crbug.com/18796
TEST=On a Mac with an fn key, give the web page keyboard focus and press the fn
key.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/165321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23073 0039d316-1c4b-4281-b951-d872f2087c98
|