| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the currently loaded site. We are careful in this patch to
continue to allow dropping URLs in text fields within the app
window, and behavior for normal browser windows remains as
before.
There is a slight glitch when dragging a to an app window on the
border of the window. Even though it is very brief, it is still
disturbing.
BUG=7171
TEST=Open Chrome (1), load google.com. Open Chrome (2), load
yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both
allowed). Create an app shortcut from 1, drag a link from 1 to
2 (allowed) and a link from 2 to 1 (denied). Verify that link
scan be dragged to the omnibox and to text fields.
Patch by Chase Phillips <chase@chromium.org> via
http://codereview.chromium.org/119298
Review URL: http://codereview.chromium.org/121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
line --auto-spell-correct, "IMB" should not change to "IBM"
Review URL: http://codereview.chromium.org/119210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bug filed; crbug.com/13786
Review URL: http://codereview.chromium.org/119446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nirnimesh
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=pkasting
Review URL: http://codereview.chromium.org/119430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
may break issuing request for same resource several times(e.g. when resource tracking is getting turned on).
ToolsAgentNativeDelegateImpl is recreated to clear request cache each time front-end is reset.
Review URL: http://codereview.chromium.org/118495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
download the plugin
src URL in a background task. The tests fail because the plugin instance is torn down before
the task executes.
The fix is to revoke tasks executing on the current WebPluginImpl instance when it is torn down.
TBR=jam
Bug=12993
Review URL: http://codereview.chromium.org/119410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a delayed task as the Flash plugin hangs if it starts receiving data before receiving valid plugin geometry.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=12993
Bug=12993
TEST=Navigate to google.com/finance and open the tickers in background tabs. They should not cause the browser to hang.
Review URL: http://codereview.chromium.org/118452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after the merge. Looks like TestShell is inserting
one fewer line-break than DRT.
TBR to green the tree.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-. Change the line ending
TBR=darin
BUG=none
TEST=rebaselining tool should not change the case of baseline name and path
Review URL: http://codereview.chromium.org/118478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r44503:
Chromium Linux ignored the background color on <select>s. Rather
than encode magic colours, we start with a base color (specified
via CSS) and derive the other colors from it. Thus, setting the
CSS background-color now correctly changes the colour of the
control.
https://bugs.webkit.org/show_bug.cgi?id=26030
TBR=tony
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committing for ryosuke.niwa@gmail.com.
TEST=none
BUG=13485
R=jparent
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
results. We can stop skipping this once the expected results are checked
in upstream.
BUG=none
TEST=none
TBR=deanm
Review URL: http://codereview.chromium.org/119403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=covered by layout test
BUG=none
TBR=ukai
Review URL: http://codereview.chromium.org/118472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=eroman
Review URL: http://codereview.chromium.org/118466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=agl
Review URL: http://codereview.chromium.org/118464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1- WorkerThread::create() now takes a WorkerLoaderProxy parameter, which I
implemented in a stub fashion on WebWorkerImpl. I'm sure the WebWorker guys
will fix this up properly.
2- Removed expirationDate and setExpirationDate members of WebURLResponse
consistent with their removal from WebCore::ResourceResponseBase. The
corresponding logic for computing cache eviction time is now part of WebCore.
3- Added wtf/DateMath.{h,cpp} to the build.
TEST=covered by existing tests, I hope!
BUG=none
R=eroman
Review URL: http://codereview.chromium.org/119387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves our ResourceHandle to webkit/api/src/ResourceHandle.cpp
from webkit/glue/resource_handle_impl.cc. A portion of
resource_handle_impl.cc was moved into weburlloader_impl.{h,cc},
which now contains our implementation of WebURLLoader.
The annoying parts of this CL involve WebPluginImpl. I had to
convert it over to using WebURLLoader instead of ResourceHandle
so that MultipartResourceDelegate can be shared.
There is some complexity in WebURLRequest / WebURLResponse to
make it cheap to wrap a ResourceRequest / ResourceResponse. I
think this is worth it since there is a lot of conversion between
the two types.
Originally reviewed here:
http://codereview.chromium.org/113928
BUG=10038
TEST=covered by existing tests
R=dglazkov
Review URL: http://codereview.chromium.org/118438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
InspectorController.addResourceSourceToFrame to asynchronous we can get rid of our implementation of SourceView.setupSourceFrameIfNeeded.
Review URL: http://codereview.chromium.org/118428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object.
Because initialization of a context can now instantiate a document
wrapper, we have to be careful if the context initialization happens
when attempting to create that very same document wrapper. We
therefore make sure that the context is initialized before checking if
a node already has a wrapper.
Review URL: http://codereview.chromium.org/118430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetWindowPos in setParent for the sake of layout tests.
TBR=ananta
Bug=12993
Review URL: http://codereview.chromium.org/119344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note: the full fix to the bug also needs Ananta's change at http://codereview.chromium.org/119200
Bug=12993
Review URL: http://codereview.chromium.org/118359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a background tab.
From what I can tell this bug always existed in Chrome.
The flash plugin gets instantiated and gets initial geometry updates during initialization. We download the plugin url after the geometry update. After these geometry updates the webkit layout timer runs and the plugin gets additional geometry updates. However these don't get sent over to the flash plugin instance in the plugin process as the geometry updates for windowed plugins are only flushed during paint, which does not happen in this case. The flash plugin ends up receiving data before geometry update and ends up behaving in a wierd fashion, i.e. not peeking for messages, etc.
The fact that this is a windowed plugin results in the browser ui thread also getting hung until the plugin gets out of this state.
The fix for the geometry update issue is to remove the deferred geometry update stuff. This only exists
for windowed plugins anyway. The geometry update IPC is a plain routed message and it should not be a big
overhead to send these IPCs to the plugin process.
I found that while this change fixes the basic issue, we still see some hangs in the flash plugin because of it receiving
data before the valid geometry update kicks in. John is working on a fix where we never have to call setFrameRect ourselves
and always honor the setFrameRect calls made by Webkit. This issue can be marked as fixed once both fixes get checked in.
This fixes http://code.google.com/p/chromium/issues/detail?id=12993
Bug=12993
TEST=Open google finance and Ctrl Click on the tickers in the page like Basic Materials, etc.
Review URL: http://codereview.chromium.org/119200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One test not timing out on Mac; mark it as SLOW as it is on other platforms.
BUG=http://www.crbug.com/10055
BUG=http://www.crbug.com/11812
BUG=http://www.crbug.com/12860
BUG=http://www.crbug.com/12882
TEST=Less redness == more goodness
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"expected to fail", but have passed on the buildbots for a while.
BUG=http://www.crbug.com/10438
BUG=http://www.crbug.com/10457
BUG=http://www.crbug.com/10055
BUG=http://www.crbug.com/11064
BUG=http://www.crbug.com/11613
BUG=http://www.crbug.com/12860
BUG=http://www.crbug.com/12881
BUG=http://www.crbug.com/13417
TEST=green buildbots == teh awesome
Review URL: http://codereview.chromium.org/119320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
targets, to avoid -l[Uu]rlmon.lib duplication in link lines.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Works on Windows and Linux. On Mac V8's sampling doesn't work with Chromium due to an unknown reason.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/119307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
access.
Review URL: http://codereview.chromium.org/118381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains:
- A couple of compilation time improvements.
- Optimized interceptor access for certain situations.
- Fix for one GCC 4.4 compilation problem.
- A new API function needed for caching of the document wrapper on the
global object.
- A minor change to the eval implementation to follow other JavaScript
implementations more closely.
Review URL: http://codereview.chromium.org/119305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser tests are an alternative to UI tests.
They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes).
In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/115896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none
Review URL: http://codereview.chromium.org/118206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Needs the first part of https://bugs.webkit.org/show_bug.cgi?id=26148 to be checked in and pulled down before a commit.
Review URL: http://codereview.chromium.org/118211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of these are due to evanm's fix in http://codereview.chromium.org/119197,
which removed some flakiness in the GTK flavour of test_shell. The
rest was a skia fix landed in http://code.google.com/p/skia/source/detail?r=198
BUG=http://crbug.com/12002
BUG=http://crbug.com/12004
BUG=http://crbug.com/13218
TEST=Check that expected layout tests pass.
Review URL: http://codereview.chromium.org/118309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add one new layout test to test_expectations.txt
LayoutTests/editing/execCommand/convert-style-elements-to-spans.html = FAIL
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rationale: as V8 can't be reset for the process, it means that profiling logs are permanent from the viewpoint of a DevTools instance. Thus, we don't need to reset Profiles panel UI as opposed to WebKit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarking from within Chrome. Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.
These are controlled under a new commandline option
"--enable-benchmarking"
BUG=6754
TEST=none
Review URL: http://codereview.chromium.org/119191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=12860,12881,12882
TEST=pass 5 failed/crashed layout tests and one new layout test
Review URL: http://codereview.chromium.org/119236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop
really exposed the bug. It would be preferable to just wait
until the content area was properly sized, but I kept running
into corner cases trying to get that to work.
BUG=13364
TEST=more layout tests should pass
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've looked through old/new images and it looks to me they are all correctly passing tests and the difference is the recently updated scrollbar rendering, as described in bug http://code.google.com/p/chromium/issues/detail?id=13313.
BUG=13313, 13314
TEST=none
Review URL: http://codereview.chromium.org/118257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98
It broke linux test_shell_tests.
Review URL: http://codereview.chromium.org/119203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop really exposed the
bug.
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Roll DEPS for WebKit. Also, fixed layout test from 13305 upstream, removing it from expectations.
BUG=13305 (fixed)
TEST=none
Review URL: http://codereview.chromium.org/118251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13251
Review URL: http://codereview.chromium.org/118236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17637 0039d316-1c4b-4281-b951-d872f2087c98
|