| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't work
The fix consists of 2 parts:
The 1st part is in WebKit/WebCore/platform/chromium/PopupMenuChromimu.cpp. The patch is in https://bugs.webkit.org/show_bug.cgi?id=25899.
The 2nd part is in webkit/glue/webwidget_impl.cc:
Adding WebInputEvent::Char event type handling in WebWidgetImpl::HandleInputEvent(). The comment should be self-explained.
BUG=http://crbug.com/8052
TEST=In a HTML containing <select> tag and Hebrew character options, open the Hebrew select element, type a Hebrew letter which is the first letter of one option, that option should be selected.
Review URL: http://codereview.chromium.org/113712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=wtc
BUG=None
TEST=It compiles! It must work.
Review URL: http://codereview.chromium.org/115702
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the new WebKit API, it seems best if WebRequest is just a wrapper for
WebCore::ResourceRequest since in most contexts that's what we need it to
be.
The solution here is to introduce a LoadHistoryState method on WebFrame that
can be used to navigate to a session history item.
BUG=10038
TEST=covered by existing back/forward navigation tests.
R=brettw
Review URL: http://codereview.chromium.org/113758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Reenables fetching of settings from gconf.
-Moves all gconf access to happen from the UI thread only, (where
the default glib main loop runs).
-Adds support for gconf notifications, avoiding having to poll the settings.
-Fixes a small initialization glitch in the unittest. Plus minor code style tweaks.
-Permanently removes gdk and glib threading initialization calls that
were previously disabled.
-Slight reorganization of ProxyService creation to pass down the IO
thread MessageLoop.
BUG=11111
TEST=none
Review URL: http://codereview.chromium.org/113043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11766
Review URL: http://codereview.chromium.org/115655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/js/global-function-resolve.html
added by webkit 44016
LayoutTests/http/tests/mime/accept-all-text-types.html
modified by webkit 43991
LayoutTests/http/tests/local/drag-over-remote-content.html
LayoutTests/http/tests/security/drag-over-remote-content-iframe.html
added by webkit 44010, 44027
TBR=paul
BUG=12477
TEST=4 new failure tests
Review URL: http://codereview.chromium.org/115694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4 regressions on buildbot
new tests
LayoutTests/fast/js/global-function-resolv.html = FAIL
LayoutTests/http/tests/local/drag-over-remote-content.html = FAIL
LayoutTests/http/tests/security/drag-over-remote-content-iframe.html = FAIL
fails
LayoutTests/http/tests/mime/accept-all-text-types.html = FAIL
For webkit_revision 44029, webkit/webkit.gyp updated
http://codereview.chromium.org/115619
Add third_party/WebKit/WebCore/css/mediaControlsChromium.css in webkit/webkit.gyp
TBR=paul
BUG=0
TEST=4 regressions on buildbot
Review URL: http://codereview.chromium.org/115690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115685
Patch from Antoine Labour <piman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
communication between WebPlugin and WebPluginDelegate, to use a cross-platform
message based on WebInputEvent.
BUG=8202
TEST=A lot of manual testing on Linux and Windows, with Flash plugins and a
custom plugin that dumps events on Linux.
Review URL: http://codereview.chromium.org/115330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The virtual key code for mac popup menus was not set properly
so HTML select menus, when dismissed by hitting escape or
clicking outside of the popup menu area, were not shut down
cleanly.
WebInputEventFactory requires the charactersIgnoringModifiers
field of the NSEvent to be set to VK_ESCAPE (0x1b) for the
dimiss to work.
The key event type also needs to be a key down (NSKeyDown)
since PopupListBox::handleKeyEvent ignores the key up.
Review URL: http://codereview.chromium.org/115618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/29375
http://crbug.com/2215
Review URL: http://codereview.chromium.org/113716
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
by the change to eliminate WebRequest::Get/SetExtraData.
R=brettw
Review URL: http://codereview.chromium.org/113694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Use Utf8ToUtf16 conversion instead.
Review URL: http://codereview.chromium.org/113706
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12350
TEST=LayoutTests/fast/forms/select-style.html
Review URL: http://codereview.chromium.org/113699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113693
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unsupported events may cause additional troubles. E.g. ScriptCollected event handling crashes on call to GetEventContext(this should be fixed on v8 side).
Review URL: http://codereview.chromium.org/113695
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream change https://bugs.webkit.org/show_bug.cgi?id=25742 modified the
test.
Original patch by tyoshino@google.com.
(see http://codereview.chromium.org/115623)
r=levin
BUG=12350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
handling the event.
Review URL: http://codereview.chromium.org/113629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove fail expectations
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
BUG=11909
TEST=no additional test regressions
Review URL: http://codereview.chromium.org/115622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a DidCreateDataSource method to WebViewDelegate,
which the embedder uses to know if their LoadRequest
resulted in a navigation. The embedder then associates the
ExtraData with the WebDataSource at that point. The
WebDataSource then proceeds to be treated as the provisional
data source, possibly failing or being committed. We then
inspect WebFrame::GetDataSource in DidCommitLoadForFrame to
recover the ExtraData.
We have to take care to handle reference fragment
navigations since those do not result in a new WebDataSource
being created. So, in DidChangeLocationWithinPage, we
update the ExtraData associated with the WebDataSource
returned by WebFrame::GetDataSource.
One thing that is important to note: In
DidCommitLoadForFrame, we would previously always inspect
the value of GetDataSource returned from the main frame
instead of looking at the frame passed to
DidCommitLoadForFrame. This explains why WebFrameImpl::
LoadRequest needed to cached ExtraData on the current
WebDataSource, and I think doing so is awkward and wrong.
My change is to always store the ExtraData on the first
WebDataSource to be created as a result of LoadRequest.
Then in DidCommitLoadForFrame, I always inspect the
ExtraData from the given WebFrame. This means that for
history navigations that only navigate a subframe, we'll end
up with ExtraData associated with the WebDataSource of a
subframe. I think this is OK even though the old code was
trying to avoid this scenario. See the DCHECK removed in
RenderView::UpdateURL.
BUG=11423
R=brettw
Review URL: http://codereview.chromium.org/115575
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa
TEST=This will eventually be covered by layout tests once I change the upstream code to use this API.
Review URL: http://codereview.chromium.org/113672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and expose the names to webkit.
Review URL: http://codereview.chromium.org/113665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12361
TEST=none, this change only notes that a newly added test is failing.
Review URL: http://codereview.chromium.org/113676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12274
Review URL: http://codereview.chromium.org/113607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=levin
BUG=3319
TEST=no test regressions
Review URL: http://codereview.chromium.org/113372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test expectation has updates for new failures along with
bugs that list the change that caused the failures.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/115594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uploaded the following images:
muted: webkit\glue\resources\media_sound_none.png
not muted: webkit\glue\resources\media_sound_full.png
play: webkit\glue\resources\media_play.png
pause: webkit\glue\resources\media_pause.png
Review URL: http://codereview.chromium.org/113668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=levin
Review URL: http://codereview.chromium.org/113663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add failures for recurring layout tests failures.
This reverts part of r16498 which removed one of these test but the test
is failing consistently now.
BUG=http://crbug.com/12002, http://crbug.com/12340, http://crbug.com/12341
TEST=none needed. Just test expectations update.
Review URL: http://codereview.chromium.org/115585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/113651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20%28webkit.org%29
This is the same code that was there upstream before these methods
became pure virtual.
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
formal ones they will be available in the arguments array as elements without names. We shouldn't show such properties in the scope variables panel.
Review URL: http://codereview.chromium.org/113630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a NULL SVGElement which makes no sense.
BUG=12105
Review URL: http://codereview.chromium.org/113627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only tests that are newly failing are new tests added for WCSS
which are also skipped by desktop platforms (osx, windws, etc.)
upstream as well.
BUG=12310
TEST=no additional test regressions.
Review URL: http://codereview.chromium.org/113624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore::multipleFileUploadText() is already declared in LocalizeStrings.h, and
implemented and used in other platforms.
This patch won't change Chromium's behavior for now. We need to change
WebCore/platform/chromium/FileChooserChromium.cpp to use this string.
Patch by Kent Tamura (tkent@google.com)
R=darin
BUG=8740
Review URL: http://codereview.chromium.org/113620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least).
Review URL: http://codereview.chromium.org/115553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to avoid using WebKitClient outside the main thread.
Review URL: http://codereview.chromium.org/115103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager.
Review URL: http://codereview.chromium.org/115374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Scripting in the browser. This should be pretty well covered by other testing.
BUG=http://crbug.com/12063
Review URL: http://codereview.chromium.org/115542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Take advantage of new String::createUninitialized() call in webkit.
This allows us to have one malloc node per string, without an
extra copy of the characters
2) Take advantage of new V8 behavior, to return NULL from
GetExternalStringResource() if it hasn't been externalized,
speeding up our usage by not requiring us to call isExternal
3) Check if string type is an integer. If it is, don't call into V8 to
get string...instead do it in C++, caching previous integer strings less
than 100.
Also removed unnecessary test for IsEmpty() as the called function also
tests for it.
Review URL: http://codereview.chromium.org/115517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12262
Review URL: http://codereview.chromium.org/113599
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the plugin. This ensures that the plugin will always be instantiated with the correct mime type at all times.
Added plugin tests to cover this case where in the embed tag is specified with a URL but without a mime type.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=8973
Bug=8973
Test :- Added a plugin test for this case.
Review URL: http://codereview.chromium.org/113326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12254
TBR=dglazkov
Review URL: http://codereview.chromium.org/113593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115518
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaving this on produces warnings with newer gccs.
In https://bugs.webkit.org/show_bug.cgi?id=25864, Darin Adler says, regarding
leaving strict aliasing rules on: "I would expect many, many problems in
WebCore. Not just warnings, but actual code generation problems."
BUG=9104
Review URL: http://codereview.chromium.org/115520
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16389 0039d316-1c4b-4281-b951-d872f2087c98
|