summaryrefslogtreecommitdiffstats
path: root/webkit
Commit message (Collapse)AuthorAgeFilesLines
* Make Flip4Mac handling version-specificstuartmorgan@chromium.org2010-12-131-8/+14
| | | | | | | | | BUG=52661 TEST=Flip4Mac 2.3.6+ should show up in chrome://plugins and stay enabled once enabled. Flip4Mac 2.3.[0-5] should not show up. Review URL: http://codereview.chromium.org/5684003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69010 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-133-9/+12
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to URLRequestFileJob.tfarina@chromium.org2010-12-121-2/+2
| | | | | | | | | BUG=64263 TEST=trybots Review URL: http://codereview.chromium.org/5755004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68959 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-114-34/+40
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestJob URLRequestJob;tfarina@chromium.org2010-12-1112-37/+39
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-114-40/+34
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Silence another failurepkasting@chromium.org2010-12-111-1/+2
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68931 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily silence a failurepkasting@chromium.org2010-12-111-0/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68926 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a plugin taking a whole iframe from messing with the page's zoom level.jam@chromium.org2010-12-101-0/+7
| | | | | | | BUG=65395 Review URL: http://codereview.chromium.org/5774001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68868 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression introduced with the change to marshal custom HCURSOR's set ↵ananta@chromium.org2010-12-101-1/+2
| | | | | | | | | | | | | | | | by windowless plugins. This caused the cursor type to not get set correctly. Fixes bug http://code.google.com/p/chromium/issues/detail?id=66105 BUG=66105 TEST=As described in the bug. TBR=jam Review URL: http://codereview.chromium.org/5775001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68803 0039d316-1c4b-4281-b951-d872f2087c98
* Add a newline to make Linux happybrettw@google.com2010-12-091-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68784 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to write simple unit tests for the pepper implementation. ↵brettw@google.com2010-12-0911-2/+623
| | | | | | | | | | | | This adds a mock plugin delegate that does nothing, and a helper unit test base class that sets up a dummy plugin instance and module for use in writing tests. This implements some basic tests on the resource tracker and fixes a bug I found! TEST=this is BUG=none Review URL: http://codereview.chromium.org/5685002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68781 0039d316-1c4b-4281-b951-d872f2087c98
* appcache: document that the manifest parsing algorithm is fixedevan@chromium.org2010-12-091-0/+7
| | | | | | | | | | | Otherwise, people (like me) will attempt to "moderize" this code and discover that it's fine the way it is. :~( TEST=compiles (just adding a comment) Review URL: http://codereview.chromium.org/5742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68775 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the right bug number for a failure.pkasting@chromium.org2010-12-091-1/+1
| | | | | | | | BUG=64371 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68760 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that custom cursors set by windowless flash plugins get marshaled ↵ananta@chromium.org2010-12-092-23/+35
| | | | | | | | | | | | | | | | | correctly back to the renderer and eventually to the browser. We rely on the HCURSOR getting marshaled across on windows. However this regressed when code to validate the custom cursor info was added in the WebCursor deserialization routines. Fixes bug http://code.google.com/p/chromium/issues/list?cursor=39436 BUG=39436 TEST=Covered by new custom cursor deserialization unit test. Review URL: http://codereview.chromium.org/5686001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68759 0039d316-1c4b-4281-b951-d872f2087c98
* Start deinlining non-empty virtual methods. (This will be automatically checkederg@google.com2010-12-092-1/+6
| | | | | | | | | | | for in the future.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5574006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68746 0039d316-1c4b-4281-b951-d872f2087c98
* Merge PluginGroups for Adobe Readerjkummerow@chromium.org2010-12-094-152/+289
| | | | | | | | | | | This patch introduces general support in PluginGroup for multiple version ranges with one minimum secure version each, to be used e.g. for multiple major versions currently supported by their manufacturer. BUG=65207 TEST=test_shell_tests: PluginGroupTest* Review URL: http://codereview.chromium.org/5621006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68726 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a useful context menu for the blocked plug-in frame:cevans@chromium.org2010-12-092-0/+16
| | | | | | | | | | | | | - Offers option to run plugin (clickjack-proof). - Offers option to hide blocking placeholder. - Retains Inspect Element; it's also useful to see the <embed>. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/5639004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68719 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-0830-50/+106
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-082-3/+6
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Make webkit/glue/plugins no longer depend on ppapi/proxy directly. This causesbrettw@chromium.org2010-12-085-169/+149
| | | | | | | | | | | | | things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68567 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix leak in PluginList by actually calling Shutdown().thestig@chromium.org2010-12-081-1/+2
| | | | | | | | | BUG=none TEST=Valgrind goes green this time. TBR=bauerb Review URL: http://codereview.chromium.org/5574005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68550 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code from headers to implementation.erg@google.com2010-12-072-0/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix leak in plugin group code.thestig@chromium.org2010-12-071-7/+20
| | | | | | | | BUG=none TEST=Memory tree goes green. Review URL: http://codereview.chromium.org/5529007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68513 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up downstream test expectations.victorw@chromium.org2010-12-071-7/+0
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68491 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68482 - Make webkit/glue/plugins no longer depend on ppapi/proxy ↵brettw@chromium.org2010-12-075-149/+169
| | | | | | | | | | | | | | | | | | | directly. This causes things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing Review URL: http://codereview.chromium.org/5592005 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/5616004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68486 0039d316-1c4b-4281-b951-d872f2087c98
* Make webkit/glue/plugins no longer depend on ppapi/proxy directly. This causesbrettw@chromium.org2010-12-075-169/+149
| | | | | | | | | | | | | | things that use webkit but otherwise don't need IPC to include the IPC directory. This patch moves the set-up of the proxy into the renderer. I also did a lot of clean-up of the initialization and it seems much nicer now. BUG=63684 TEST=manual PPAPI proxy testing Review URL: http://codereview.chromium.org/5592005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68482 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up PluginGroup and related code.jkummerow@chromium.org2010-12-075-231/+321
| | | | | | | | | | | To avoid data races, do not pass pointers to PluginGroup around. Instead, create copies as plain objects. BUG=61210 TEST=existing unit tests still work; TSan no longer reports the race (see bug) Review URL: http://codereview.chromium.org/5516004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68471 0039d316-1c4b-4281-b951-d872f2087c98
* Fix webkit URLRequestJob subtypes to handle Kill() correctly.willchan@chromium.org2010-12-077-29/+48
| | | | | | | | | | | Kill() should prevent calling back into the delegate. So we cancel pending callbacks. BUG=63692 TEST=existing Review URL: http://codereview.chromium.org/5545003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68445 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73372:73408victorw@chromium.org2010-12-071-0/+2
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68415 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete ↵kinuko@chromium.org2010-12-071-149/+0
| | | | | | | | | | | webkit/tools/layout_tests/webkitpy/layout_tests/test_output_xml_to_json.py BUG=41405 TEST=green bot Review URL: http://codereview.chromium.org/5598007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68412 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the "dangerous download" algorithm as follows. Original patch by ↵pkasting@chromium.org2010-12-063-3/+8
| | | | | | | | | | | | | | | | | | | | Pierre-Antoine LaFayette (see http://codereview.chromium.org/1403001/ ), r=me,brettw,aa. Downloads are considered dangerous if: a) The file is dangerous just by sitting on the drive, without needing to be clicked on e.g. dll, xbap b) The file is executable and the download was not user initiated. c) They are an extension that is not from the gallery We have defined a user initiated download as 3 possible cases: a) A user enters a URL into the address bar that is a file b) A user left clicks on a URL that is a file c) A user right clicks and does "Save As" on a URL that is a file. BUG=9044 TEST=Open a page with a download link to a dangerous file that is not an extension, e.g. an .exe file, and left click on the link. The download should proceed without a prompt. Review URL: http://codereview.chromium.org/5603008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68406 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-0617-463/+1003
| | | | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363). One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
* Use stopped_on_render_loop_ to prevent further work from executing in ↵scherkus@chromium.org2010-12-062-17/+5
| | | | | | | | | | | | | BufferedDataSource. Previously we were using it as a DCHECK but we would fail gracefully. Now that stopped_on_render_loop_ is set via Abort() (i.e., catastrophic failure), we need to use it as a singal to make sure all work on the render loop does indeed stop. BUG=16751 TEST=http/tests/media should stop crashing Review URL: http://codereview.chromium.org/5603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68363 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup downstream test expectations file.victorw@chromium.org2010-12-061-3/+0
| | | | | | | | | TBR=yutak TESt=none BUG=65404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68357 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number in test expectationsvictorw@chromium.org2010-12-041-2/+2
| | | | | | | | | TBR=yutak BUG=65404 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68281 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two failed layout tests while investigating.victorw@chromium.org2010-12-041-0/+3
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68276 0039d316-1c4b-4281-b951-d872f2087c98
* Allow data URLs to trigger downloads, as they do in Firefox.darin@chromium.org2010-12-031-1/+27
| | | | | | | | | | | | | | | | | | | | Unfortunately, many of our tests rely on being able to use WebURLLoader to load data: URLs when there is no ResourceLoaderBridge implementation. In those tests, we would crash if we try to use the ResourceLoaderBridge. To workaround that, and because it probably a good optimization anyways, I decided to check if the data URL has a supported MIME type, and if it does, then I let it load directly as before. Since data URLs may be very large, I modified DataURL::Parse to skip parsing the 'data' section of the URL if the corresponding out param is null. R=tony BUG=38546 TEST=none (I would like to add a download test, but they are all disabled or flaky.) Review URL: http://codereview.chromium.org/5542001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68212 0039d316-1c4b-4281-b951-d872f2087c98
* glue: use string16 in place of wstring for Unicode textevan@chromium.org2010-12-037-37/+39
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5591004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68208 0039d316-1c4b-4281-b951-d872f2087c98
* wstrings: convert CppVariant and CppBoundClass to not use wstringevan@chromium.org2010-12-039-34/+29
| | | | | | | | | | | | | | | Confusingly, we had a ToString() that returned a UTF-8 string and a ToStringVector() that returned wstrings. Since CppVariant is a small wrapper around NPVariant I made them both use UTF-8; it simplified most of the users anyway (which only dealt with ASCII anyway). BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5631002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68187 0039d316-1c4b-4281-b951-d872f2087c98
* Delete FileSystem API data when uninstalling extensions.kinuko@chromium.org2010-12-033-7/+31
| | | | | | | | | BUG=63700 TEST=load an extension that keeps writing to file system and unload it. See if the origin data under the profile is deleted. Review URL: http://codereview.chromium.org/5272010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68143 0039d316-1c4b-4281-b951-d872f2087c98
* Turn GPU accelerated features (WebGL, compositing, accelerated 2d canvas) ↵jamesr@chromium.org2010-12-031-1/+1
| | | | | | | | | | | | | off for background pages We don't support turning compositing on for a background page currently and it doesn't seem necessary. This disables all GPU-requiring features for background pages for now. When we have valid use cases we can re-enable features as needed. BUG=64512 TEST=load extension that uses 3d CSS in a background page and verify that there is no browser crash or GPU process created on startup Review URL: http://codereview.chromium.org/5369008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68130 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73207:73212victorw@chromium.org2010-12-031-4/+0
| | | | | | | | | | | | Also clean up downstream test expectations, they were added upstream http://trac.webkit.org/changeset/73212 TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader ↵scherkus@chromium.org2010-12-0317-1003/+463
| | | | | | | | | | | | | | | | | | | | instead of a MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/5619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 73140:73207victorw@chromium.org2010-12-031-0/+5
| | | | | | | | | TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68116 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MediaFilter and MediaFilterCollection to Filter and FilterCollection, ↵scherkus@chromium.org2010-12-037-14/+16
| | | | | | | | | | | respectively. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DrawGlyphs call have the proper const arguments, and make the proxiedbrettw@chromium.org2010-12-023-9/+9
| | | | | | | | | | | version of this API synchronous. Otherwise, the caller may end up trying to draw over the text that isn't there yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/5555004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68108 0039d316-1c4b-4281-b951-d872f2087c98
* Have about:plugins point to the latest Flash and Reader versions.panayiotis@google.com2010-12-021-3/+3
| | | | | | | | | BUG=65170 TEST=unit_tests Review URL: http://codereview.chromium.org/5619001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68107 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring BufferedDataSource to work with WebURLLoader instead of a ↵scherkus@chromium.org2010-12-0217-463/+1003
| | | | | | | | | | | | | | | | | MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup downstream suppressions.antonm@chromium.org2010-12-021-4/+0
| | | | | | | | It's been moved upstream with http://trac.webkit.org/changeset/73050 Review URL: http://codereview.chromium.org/5539004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68070 0039d316-1c4b-4281-b951-d872f2087c98