| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=3953
Bug=3953
Review URL: http://codereview.chromium.org/20087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from tests_fixable.
Me and you keep going back and forth on this test. Did you mean to add it back?
Here's what I said last time around (sometime yesterday):
Removes the test
LayoutTests/transitions/transition-end-event-nested.html from
tests_fixable. I upstreamed some changes to timeout in this test that
should hopefully make is always pass. I prematurely turned this on
yesterday before we pulled down the change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/20086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing.
Updated few DEPS file with reasonable rules.
To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed.
Review URL: http://codereview.chromium.org/21025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bots.
Review URL: http://codereview.chromium.org/20085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
All code fix ups were due to r40508 which "Track redirects in global history."
Review URL: http://codereview.chromium.org/20077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a workaround for Issue 6971 "Chrome crashes if Javascript dynamically clears an input field while user attempts to type Korean into that field."
To prevent this crash, this code verifies if the parent nodes of an IME composition node exist and are editable before updating the composition node.
This change also changes an Editor::completeComposition() call to an Editor::setComposition() call to emulate the behavior of Safari. It seems Safari calls the Editor::setComposition() function when it cancels an ongoing composition.
Review URL: http://codereview.chromium.org/19619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebPluginImpl::TearDownPluginInstance.
This function gets called during plugin destruction and during plugin reinitialization. It looks like this crash occurs when the reinitialization fails and the plugin widget
is being destroyed.
This fixes http://code.google.com/p/chromium/issues/detail?id=7405
Review URL: http://codereview.chromium.org/21069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
was trying to rebaseline these tests.
TBR=dsh
Review URL: http://codereview.chromium.org/21072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/usr/local/google/home/shess/chromium/chromium-svn-submit/src/webkit/tools/layFollowup from http://codereview.chromium.org/18738
Went through looking for Mac-specific CRASH tests, and ran them with
and without the above change. These were the ones which went from
crashing w/out the change to not-crashing with the change. Since the
change fixed a race condition, I also replicated the crash for these
ones w/in gdb, and the crash point was consistent with the above fix.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/23007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests are being rebaselined. Four of those the text output matches, so the
expected text is being removed completely to fallback to Windows. The images
are off as follows:
LayoutTests/fast/block/margin-collapse/103.html:
Select boxes and scrollbars are different but that's all.
LayoutTests/fast/block/positioning/047.html:
Left arrow is draw a little differently and scrollbars are different.
LayoutTests/fast/css/line-height-font-order.html:
The character for "4" has an extra dot. Looks fine.
LayoutTests/tables/mozilla/bugs/bug2886-2.html:
A couple dots mismatch in the "N", "e", "2" and "4" but it all looks fine.
These ones the diffs are a little more dramatic, but they look fine.
LayoutTests/svg/W3C-SVG-1.1/text-fonts-01-t.svg:
Fonts are still a little off but look fine.
LayoutTests/svg/text/text-fonts-01-t.svg:
Indistinguishable by the naked eye. Linux looks fine.
A few tests that should not have been rebaselined are reverted to failing.
These include tests that are very ugly (eg, without anti-aliasing). The
baselines were removed and not replaced.
This is triggered by r9120 which fixed a bug and caused some incorrectly
rebaselined tests to "fail" again.
Review URL: http://codereview.chromium.org/20056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
last one.
Review URL: http://codereview.chromium.org/20065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of a wstring. Convert the linux data pack files to
pack message strings as utf16 instead of utf8.
Review URL: http://codereview.chromium.org/20060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
function local to the win implementation as it's only being used on win.
Review URL: http://codereview.chromium.org/20061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is needed by plugins, as explained in the comment above the new code.
Review URL: http://codereview.chromium.org/20053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/transitions/transition-end-event-nested.html from
tests_fixable. I upstreamed some changes to timeout in this test that
should hopefully make is always pass. I prematurely turned this on
yesterday before we pulled down the change.
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/21059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/21056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to platform-specific types in the implementation files and change variable names to match the header. Based on cl 8783 by Evan Martin.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We still crash when you navigate away from the page.
(PS: the plan is to unfork the _gtk.cc file once it gets closer to what we want, so you don't need to look at that too closely. I just wanted to check in what I have since it's getting big.)
Review URL: http://codereview.chromium.org/19413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For sure, we don't intend to support them on Linux/Win and perhaps it's a
good idea to be consistent although we can support them by building
platform/text/mac.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
should be left to the text edit to proceed.
BUG=4874
Review URL: http://codereview.chromium.org/20046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Note: this CL was previously committed and reverted because it broke the sandbox integration module.
Review URL: http://codereview.chromium.org/21032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add entries for 8 Indian languages to grd files (<translations> section)
* Change the default spellcheck language for new languages to en-US for now. They'll be switched back to
the UI language when we have spell check dictionaries for them
* Add entries for 8 languages to installer's string offset table.
This change will go in after http://codereview.chromium.org/19545 goes in with DEPS file for ICU updated.
BUG=4473
Review URL: http://codereview.chromium.org/19761
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/editing/spelling/spelling-linebreak.html as it relies on
showing spelling errors, which we've decided to defer for now.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/20050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
associated with. This is wrong, its font should be independent of the edit field.
TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font.
BUG=7372,6326
Review URL: http://codereview.chromium.org/20030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
included the fix for char-encoding.html.
fast/encoding/char-encoding.html should pass on all platforms.
fast/encoding/char-encoding-mac.html should be ignored on Linux and Windows.
Review URL: http://codereview.chromium.org/18700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
make sure that we take another look if we fail it when they enable it
again.
Annotate test with description and bug number.
Review URL: http://codereview.chromium.org/21043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
specific to the JSC profiler and the current approach to profiling with V8 will not make these tests pass.
Review URL: http://codereview.chromium.org/21016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
flaky. I'll try to check them in again but in smaller chunks tomorrow.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/21039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(fix from craig.schlenter@gmail.com)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(fixed by 40464:40500 webkit merge).
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/20034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest
Review URL: http://codereview.chromium.org/20015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
couldn't find the correct font. Now the font is perfect, but the listbox
controls are different. This is expected, so I'm rebaselining the pixel
test. The text diff is still off by one number, so I'm leaving that alone
until we figure it out.
Review URL: http://codereview.chromium.org/23001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke the build.
Review URL: http://codereview.chromium.org/20029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Review URL: http://codereview.chromium.org/21018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the way the rotated border is drawn, compared to the existing baseline. This probably happens due to slight difference in the way Skia anti-aliases lines.
Review URL: http://codereview.chromium.org/19519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DocumentMarker with the same start- and endOffset,
which AddMarker in WebKit will ignore. As a result,
our marker vector is empty and we try to access
the element with index -1.
Also added a check to avoid a NOTREACHED in debug
build, which can happen under normal circumstances
(when you navigate away from a page when a search
is in progress).
BUG=http://crbug.com/7250
TEST=We don't have reproduction steps for the
crash but if we stop seeing this on our crash
server we'll know that it is fixed.
Review URL: http://codereview.chromium.org/20028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous change was causing image baselines to be treated as
text only diffs so images were being copied into the chromium-win
dir by accident. Fix this by reverting the change from test_type_base.py
and applying it to text_diff.py instead.
Review URL: http://codereview.chromium.org/20021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we can override the via custom_vars in .gclient on the bots
and official builds updates the merge script appropriately.
Also updates checkdeps to be Var-aware.
Review URL: http://codereview.chromium.org/19508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests_fixable.
I upstreamed a change that should make this always pass.
BUG=none
TEST=none
TBR=finnur
Review URL: http://codereview.chromium.org/21022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
failing layout tests to pass.
Review URL: http://codereview.chromium.org/19544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9083 0039d316-1c4b-4281-b951-d872f2087c98
|