| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
There's a one line difference where we fail because in V8
typeof(CSSStyleDeclaration) != typeof(rules2.item(0).style).
BUG=13154
Review URL: http://codereview.chromium.org/13154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
load when the plugin calls NPN_RequestRead. I was looking at the wrong
stream implementation in Firefox :(
Bug=5009
TBR=jam
Review URL: http://codereview.chromium.org/13212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This slipped in via a TBR build fix change (13209)
TBR=tony
Review URL: http://codereview.chromium.org/13185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
builders just need a clobber when this is checked in.
I also fixed the SConscript and deleted the old CSS files.
Review URL: http://codereview.chromium.org/13146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/13209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
TBR = patrick
Review URL: http://codereview.chromium.org/13208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each line in tests_fixable:
if the platforms list is missing THEN
ignore it
if the platforms list is [LINUX] AND
the test passed the most recent builder run THEN
delete it
if the platforms list includes LINUX AND
the test passed the most recent builder run AND
the platforms list does not include WIN THEN
remove LINUX from the platforms list
Review URL: http://codereview.chromium.org/13180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Revision 6439 broke the build. I'm reverting it. Please monitor the build after submitting code
Review URL: http://codereview.chromium.org/13181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for a don wrapper type.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
now have the object prototype as their implicit prototype, rather than
the function prototype.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses a debugger API in V8 which can look at the JavaScript execution stack and find the line number and source URL for the top stack frame. The JavaScript functions required for this are added to a new utility context created in V8Proxy. This context is created as a singleton (on demand) as it has no dependency in the page currently running.
I will not submit this change until V8 version 0.4.5 is used in Chrome as this change depends on a new V8 debugger API added to that version.
The change also requires a second step to udate the WebKit DEPS.
BUG=2960
Review URL: http://codereview.chromium.org/12804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a the Hebrew translation missing a bunch of strings.
TBR=mal
Review URL: http://codereview.chromium.org/12976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12973
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setSelectTrailingWhitespaceEnabled" because of layout test regressions.
This reverts commit r6404.
Review URL: http://codereview.chromium.org/13155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in the test shell. This causes us to pass at least 2 more tests.
Review URL: http://codereview.chromium.org/12933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This lets us set different expecations for the release and debug.
Also, update a test with these expectations.
Review URL: http://codereview.chromium.org/12955
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPN_RequestRead to initiate seekable byte range requests on the stream. While the contract on the plugins part is not fully clear from the mozilla docs, this is what Firefox does.
This also improves performance greatly as the manual data stream already has most of the data which the plugin requests anyway. I verified this with large PDF files around 14-15MB. We are twice as faster with this fix.
This fixes http://code.google.com/p/chromium/issues/detail?id=5009, which is an issue with the PDF file not loading at times. The problem also occurs at times in Firefox when we set breakpoints and thus slow down the operation.
The Reader plugin displays its UI in child windows on a separate thread in the plugin process. These are parented to the plugin window which lives on the plugin thread. The plugin thread unfortunately is treated as an IO thread by
the plugin and it uses the SendMessage API to send messages to the plugin thread and back. If the plugin fails to receive data for the PDF file in a reasonable time,
it just destroys the PDF window hierarchy causing this issue.
Handing the data off the manual data stream along with the byte range data speeds up the whole operation and thus avoids this issue to a great extent.
Bug=5009
R=jam
Review URL: http://codereview.chromium.org/12960
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the user doesn't have wdiff installed, we just write an
error message in place of the diff.
Review URL: http://codereview.chromium.org/13147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Equivalent to the mac change in svn diff -r38682:38683 http://svn.webkit.org/repository/webkit/trunk/LayoutTests/platform/mac/editing/deleting/5168598-expected.txt)
Review URL: http://codereview.chromium.org/12966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12956
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/13144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FilePaths. Re-enable relevant posix unit tests.
Review URL: http://codereview.chromium.org/12893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bug: https://bugs.webkit.org/show_bug.cgi?id=22051
Review URL: http://codereview.chromium.org/10424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
page does not hold references to DOM objects.
This should reduce noise of reporting leaked nodes.
Review URL: http://codereview.chromium.org/12936
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames.
Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden).
Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it.
I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious).
Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test.
Review URL: http://codereview.chromium.org/13130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
builder green.
Review URL: http://codereview.chromium.org/13136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a layout test mode flag in some places, and an interactive flag in others. It was especially confusing since interactive = !layout_test_mode.
This should make it much easier to grep for difference between layout test mode and normal "interactive" mode.
Review URL: http://codereview.chromium.org/12940
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causing some slight font differences between layout test mode and interactive mode.
Review URL: http://codereview.chromium.org/12941
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ASSERT is invalid in the new position and it is causing layout test
failures in debug mode.
TBR=feng
Review URL: http://codereview.chromium.org/13123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes Evan's change to use char instead of wchar_t for counter
names.
Also, because of changes to the regexp parser, we need to rebaseline a
couple of tests mainly because of error message changes. Most of the
tests were already rebaselined because of differences in error
messages.
Review URL: http://codereview.chromium.org/12902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
update underlying gdk window during paint operation.
Review URL: http://codereview.chromium.org/13082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR = tony
Review URL: http://codereview.chromium.org/12932
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to push the calculation of the x-height into Skia. For one of
the layout tests, it assumes that 2.5ex of Ahem is exactly 32px.
Previously we calculated the x-height of Ahem to be 13px, so 2.5*13 was
33px.
Now we use the 26.6 fixed point number from freetype's hinter and turn
that directly into a floating point value (x-height is the only WebKit
metric which is a floating point value).
This lets us pass LayoutTests/css2.1/t1507-c526-font-sz-02-b-a.html
(although the Windows baseline is wrong)
Review URL: http://codereview.chromium.org/13112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6344 0039d316-1c4b-4281-b951-d872f2087c98
|