| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves our ResourceHandle to webkit/api/src/ResourceHandle.cpp
from webkit/glue/resource_handle_impl.cc. A portion of
resource_handle_impl.cc was moved into weburlloader_impl.{h,cc},
which now contains our implementation of WebURLLoader.
The annoying parts of this CL involve WebPluginImpl. I had to
convert it over to using WebURLLoader instead of ResourceHandle
so that MultipartResourceDelegate can be shared.
There is some complexity in WebURLRequest / WebURLResponse to
make it cheap to wrap a ResourceRequest / ResourceResponse. I
think this is worth it since there is a lot of conversion between
the two types.
Originally reviewed here:
http://codereview.chromium.org/113928
BUG=10038
TEST=covered by existing tests
R=dglazkov
Review URL: http://codereview.chromium.org/118438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
InspectorController.addResourceSourceToFrame to asynchronous we can get rid of our implementation of SourceView.setupSourceFrameIfNeeded.
Review URL: http://codereview.chromium.org/118428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object.
Because initialization of a context can now instantiate a document
wrapper, we have to be careful if the context initialization happens
when attempting to create that very same document wrapper. We
therefore make sure that the context is initialized before checking if
a node already has a wrapper.
Review URL: http://codereview.chromium.org/118430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetWindowPos in setParent for the sake of layout tests.
TBR=ananta
Bug=12993
Review URL: http://codereview.chromium.org/119344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note: the full fix to the bug also needs Ananta's change at http://codereview.chromium.org/119200
Bug=12993
Review URL: http://codereview.chromium.org/118359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a background tab.
From what I can tell this bug always existed in Chrome.
The flash plugin gets instantiated and gets initial geometry updates during initialization. We download the plugin url after the geometry update. After these geometry updates the webkit layout timer runs and the plugin gets additional geometry updates. However these don't get sent over to the flash plugin instance in the plugin process as the geometry updates for windowed plugins are only flushed during paint, which does not happen in this case. The flash plugin ends up receiving data before geometry update and ends up behaving in a wierd fashion, i.e. not peeking for messages, etc.
The fact that this is a windowed plugin results in the browser ui thread also getting hung until the plugin gets out of this state.
The fix for the geometry update issue is to remove the deferred geometry update stuff. This only exists
for windowed plugins anyway. The geometry update IPC is a plain routed message and it should not be a big
overhead to send these IPCs to the plugin process.
I found that while this change fixes the basic issue, we still see some hangs in the flash plugin because of it receiving
data before the valid geometry update kicks in. John is working on a fix where we never have to call setFrameRect ourselves
and always honor the setFrameRect calls made by Webkit. This issue can be marked as fixed once both fixes get checked in.
This fixes http://code.google.com/p/chromium/issues/detail?id=12993
Bug=12993
TEST=Open google finance and Ctrl Click on the tickers in the page like Basic Materials, etc.
Review URL: http://codereview.chromium.org/119200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One test not timing out on Mac; mark it as SLOW as it is on other platforms.
BUG=http://www.crbug.com/10055
BUG=http://www.crbug.com/11812
BUG=http://www.crbug.com/12860
BUG=http://www.crbug.com/12882
TEST=Less redness == more goodness
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"expected to fail", but have passed on the buildbots for a while.
BUG=http://www.crbug.com/10438
BUG=http://www.crbug.com/10457
BUG=http://www.crbug.com/10055
BUG=http://www.crbug.com/11064
BUG=http://www.crbug.com/11613
BUG=http://www.crbug.com/12860
BUG=http://www.crbug.com/12881
BUG=http://www.crbug.com/13417
TEST=green buildbots == teh awesome
Review URL: http://codereview.chromium.org/119320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
targets, to avoid -l[Uu]rlmon.lib duplication in link lines.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Works on Windows and Linux. On Mac V8's sampling doesn't work with Chromium due to an unknown reason.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/119307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
access.
Review URL: http://codereview.chromium.org/118381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version contains:
- A couple of compilation time improvements.
- Optimized interceptor access for certain situations.
- Fix for one GCC 4.4 compilation problem.
- A new API function needed for caching of the document wrapper on the
global object.
- A minor change to the eval implementation to follow other JavaScript
implementations more closely.
Review URL: http://codereview.chromium.org/119305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser tests are an alternative to UI tests.
They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes).
In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/115896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none
Review URL: http://codereview.chromium.org/118206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Needs the first part of https://bugs.webkit.org/show_bug.cgi?id=26148 to be checked in and pulled down before a commit.
Review URL: http://codereview.chromium.org/118211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of these are due to evanm's fix in http://codereview.chromium.org/119197,
which removed some flakiness in the GTK flavour of test_shell. The
rest was a skia fix landed in http://code.google.com/p/skia/source/detail?r=198
BUG=http://crbug.com/12002
BUG=http://crbug.com/12004
BUG=http://crbug.com/13218
TEST=Check that expected layout tests pass.
Review URL: http://codereview.chromium.org/118309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add one new layout test to test_expectations.txt
LayoutTests/editing/execCommand/convert-style-elements-to-spans.html = FAIL
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rationale: as V8 can't be reset for the process, it means that profiling logs are permanent from the viewpoint of a DevTools instance. Thus, we don't need to reset Profiles panel UI as opposed to WebKit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
benchmarking from within Chrome. Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.
These are controlled under a new commandline option
"--enable-benchmarking"
BUG=6754
TEST=none
Review URL: http://codereview.chromium.org/119191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=12860,12881,12882
TEST=pass 5 failed/crashed layout tests and one new layout test
Review URL: http://codereview.chromium.org/119236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop
really exposed the bug. It would be preferable to just wait
until the content area was properly sized, but I kept running
into corner cases trying to get that to work.
BUG=13364
TEST=more layout tests should pass
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've looked through old/new images and it looks to me they are all correctly passing tests and the difference is the recently updated scrollbar rendering, as described in bug http://code.google.com/p/chromium/issues/detail?id=13313.
BUG=13313, 13314
TEST=none
Review URL: http://codereview.chromium.org/118257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98
It broke linux test_shell_tests.
Review URL: http://codereview.chromium.org/119203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop really exposed the
bug.
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Roll DEPS for WebKit. Also, fixed layout test from 13305 upstream, removing it from expectations.
BUG=13305 (fixed)
TEST=none
Review URL: http://codereview.chromium.org/118251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13251
Review URL: http://codereview.chromium.org/118236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flash plugin puts up a context
menu and we click on the browser window.
The Flash plugin at times sets focus to its hidden popup window with class name SWFlash_PlaceholderX
in the context of the TrackPopupMenu call. This causes the browser ui thread to receive a WM_ACTIVATEAPP
message indicating that another top level window has become active, which causes this issue. This also
happens in Firefox at times. However in Firefox the popup lives on the ui thread and hence the sideeffect
is that no window has keyboard focus.
Our workaround/fix for this scenario is to identify when this occurs and send over a raw mousedown/mouseup
event via SendInput to the last focus window.
Fixes http://code.google.com/p/chromium/issues/detail?id=8988
Bug=8988
Review URL: http://codereview.chromium.org/119049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=benm@google.com
TEST=no layout test regressions.
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables:
- links to source code from call graph tree;
- focusing and exlusion of functions;
- search (but it seems not fully-functional in WebKit Inspector for now).
Also moved to profiler_processor WebKit-specific code from V8/tools/profile_view.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I noticed this from a GCC warning:
webkit/glue/inspector_client_impl.cc:267: warning: cannot pass objects of non-POD type `class WebCore::String' through `...'; call will abort at runtime
Review URL: http://codereview.chromium.org/119166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed Mac build (needed to remove a file that was removed upstream).
Added expected Linux layout tests failures from the first landing attempt.
Removing the chromium-specific snapshot for list-wrapping-image-crash-expected.html test because the test was incorrectly added upstream.
Will fix it upstream and then re-enable in Chromium.
Original code review: http://codereview.chromium.org/118215
TBR=ukai
BUG=13305, 13313, 13314 (layout tests - reenable, rebaseline)
TEST=none
Review URL: http://codereview.chromium.org/119156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no compile or layout test failures.
There is a change (http://trac.webkit.org/changeset/44401) here which will likely break quite a few Linux layout tests. The plan is to run the build, then add all the tests with REBASELINE keyword into test_expectations.txt for automated rebaselining.
Review URL: http://codereview.chromium.org/118215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A change which needs some WebKit patches that haven't been merged yet
slipped into my last patch.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC
Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.
This add support for:
* An "SBX_D" environment variable in the renderers which is used to
signal the end of dynamic linking so that the chroot can be
enforced.
* A sandbox_host process, running outside the sandbox, to deal with
fontconfig requests from the renderers. See the wiki page for
the reasoning behind making it a separate process.
* A new, custom SkFontHost for Skia. Because this is Chrome
specific, it will live outside the upstream Skia tree. This
FontHost can be configured either to drive fontconfig directly
(for the browser process and for any unsandboxed renderers) or to
use an IPC system. Since the same SkFontHost has to be linked into
both the browser and renderer (they are the same binary), this
switch has to be made at run time.
Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.
http://codereview.chromium.org/112074
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
script context is empty.
R=mbelshe
BUG=13266
TEST=gmail shouldn't crash anymore.
Review URL: http://codereview.chromium.org/119109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://www.crbug.com/13267
Review URL: http://codereview.chromium.org/119102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://www.crbug.com/13267
TBR=tony
Review URL: http://codereview.chromium.org/114077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method is used to invalidate the scrollbar which causes it to
repaint. Enable this code to run on linux too.
BUG=11706
Review URL: http://codereview.chromium.org/118089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115972
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves two plugin instances with second instance making
sync calls to the renderer while the first one is still servicing
an incoming sync request.
Our logic to unblock the renderer during the sync call fails
since the 'in_dispatch_' counter is maintained per plugin channel
(each plugin instance uses its own separate channel). Making
'in_dispatch_' counter static member of PluginChannelBase fixes this
deadlock.
Added a new NPAPI UI test for this scenario.
BUG=12624
TEST=MultipleInstancesSyncCalls
Review URL: http://codereview.chromium.org/119052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also adds more explicit #includes for needed things.
Review URL: http://codereview.chromium.org/118162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17474 0039d316-1c4b-4281-b951-d872f2087c98
|