| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of WebKitClient (replacing WebWidgetDelegate from glue).
The ripple effects of this change are rather large, but most
of the impact is mechanical.
The more interesting changes include:
1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't
matter at all to RenderWidget or RenderView, but it did cause some changes to
be made to TestWebViewDelegate. Now, it is not possible to share a delegate
implementation for both the WebView and a popup menu, so I have a second
instance of the delegate owned by TestShell for use with popup menus.
2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting
to be a pretty large change, so I stopped short of deleting WindowOpenDisposition.
That way the Chrome side can remain mostly unmodified. I then added a mapping
function to convert from WebNavigationPolicy to WindowOpenDisposition.
3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and
there is now an enum to specify the composition command (WebCompositionCommand).
4- I added IPC serialization for WebCompositionCommand and WebTextDirection,
which cleaned up some code that was just using ints in IPC messages.
R=jam
BUG=16234
TEST=none
Review URL: http://codereview.chromium.org/149620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to "The Mighty Hoppy" for requesting a browser crash investigation.
BUG=NONE
TEST=GlueSerializeTest.BadMessagesTest
TBR=cpu
Review URL: http://codereview.chromium.org/149738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r20839. It broke many builds.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium SQLite VFS.BUG=noneTEST=none
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes unit tests for AudioRendererBase and VideoRendererBase.
I had to rollback my first attempt at this change. Original review: http://codereview.chromium.org/155469
BUG=16014,16031
TEST=media_unittests, layout tests
Review URL: http://codereview.chromium.org/155608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
File "webkit/tools/layout_tests/layout_package/test_shell_thread.py", line 155, in run
["--time-out-ms=" + self._test_info.timeout, self._test_info.uri])
TypeError: cannot concatenate 'str' and 'int' objects
introduced in http://codereview.chromium.org/67198
and affecting the valgrind layout_tests buildbot.
Review URL: http://codereview.chromium.org/149638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove #! on scripts that are never run standalone.
- Use /usr/bin/env python rather /usr/bin/python than to make freebsd happy
(see e.g. http://fubar.geek.nz/blog/2005/07/21/rant-on-using-bash-for-scripts/ )
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15880
TEST=none
Review URL: http://codereview.chromium.org/149722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
TBR=ericroman
Review URL: http://codereview.chromium.org/149720
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Moving from flaking to failing.
BUG=16850
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell had a javascript function that transformed file:/// URLs to point
to the top of the old LayoutTests tree (src/webkit/data/LayoutTests). I have
modified it to point to the new one (src/third_party/WebKit/LayoutTests).
BUG=https://crbug.com/16865
R=victorw
TEST=LayoutTests/fast/loader/local-css-from-local-html.html
Review URL: http://codereview.chromium.org/149713
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149707
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Extract HostResolver to an interface.
The existing concrete implementation is now named HostResolverImpl. This makes it possible to create mocks with more complex behavior (i.e. choose via rules if response will be sync vs async).
(2) Transform HostMapper into HostResolverProc.
Conceptually HostResolverProc maps a hostname to a socket address, whereas HostMapper mapped a hostname to another hostname (so you were still at the mercy of the system's host resolver). With HostResolverProc you can specify the exact AddressList, making it possible to run tests requiring IPv6 socketaddrs on systems (like WinXP) that don't actually support it.
(3) Add a MockHostResolver implementation of HostResolver.
This replaces the [ScopedHostMapper + RuleBasedHostMapper + HostResolver] combo. It is less clunky and a bit more expressive.
BUG=http://crbug.com/16452
R=willchan
TEST=existing
Review URL: http://codereview.chromium.org/149511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds one exclusion so that I can fix the file list upstream. Then I'll get rid of a bunch of unnecessary exceptions in this file.
TEST=none
BUG=16254
Review URL: http://codereview.chromium.org/149699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green builds
Review URL: http://codereview.chromium.org/155587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=MediaLeakTest.VideoBear
Review URL: http://codereview.chromium.org/155484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that stores archived layouttest results.
Also fix the mac directory name.
TEST=rebaselining tool
BUG=none
Review URL: http://codereview.chromium.org/149653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove temporary change now that webkit DEPS roll landed.
TEST=no
BUG=16228
Review URL: http://codereview.chromium.org/149655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=layout tests
BUG=10462,13105
Review URL: http://codereview.chromium.org/149645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for now.
BUG=none
TEST=Green canaries
TBR=dglazkov
Review URL: http://codereview.chromium.org/149679
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebMediaPlayerImpl::Proxy.
This forces clients to check Pipeline::GetError() instead of using a simple true/false check for success. Also the bool parameter wasn't being used for Seek() and Stop() callbacks, further hinting at its removal.
BUG=16009
TEST=media_unittests pass, layout tests pass
Review URL: http://codereview.chromium.org/149584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the try bots.
BUG=16779
TEST=clobber builds of test_shell should not have unexpected failures
Review URL: http://codereview.chromium.org/155551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.
This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.
TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin
Review URL: http://codereview.chromium.org/155517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems pointless, but for debugging purposes internally we
use the page title as an annotation on OS-level windows which helps
track them down when looking at a list of all windows. For
reasons too complicated for me to care about this doesn't work when
a page lacks a title, hence this fix.
Review URL: http://codereview.chromium.org/149642
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/http/tests/xmlhttprequest/cross-origin-no-authorization.html
BUG=16754
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/149651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disabled as flakey (not related to roll).
BUG=16676,16754
TEST=none
TBR=jorlow
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.
This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.
TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin
Review URL: http://codereview.chromium.org/155517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to new bug 16730.
BUG=15780
TEST=several
Review URL: http://codereview.chromium.org/149633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=re-enabled passing layout tests
BUG=15780
Review URL: http://codereview.chromium.org/155512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds registration of content scripts, parented to a frame's
context. When a frame's context goes away, we unregister it and any content
script contexts for it.
There's a corresponding webkit change that lets us know when a content script
context is created. Filed upstream as
https://bugs.webkit.org/show_bug.cgi?id=27104.
BUG=16228
TEST=install an extension with a content script that communicates with a parent
process. Messages should be sendable both ways.
Review URL: http://codereview.chromium.org/155309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Middle clicking on an anchor tag that points to an
in-doc fragment should result in a new background
tab being opened. Before this change, we were
overriding this behavior to cause a middle click to
behave like a left click. This patch allows middle
clicks to function similar to the behavior seen in
Firefox and Safari.
No change in behavior should be seen by users for left
clicks on anchor tags that refer to in-doc fragments.
While testing, I see at times issues due to scrolling
within the tab to the correct fragment identifier or
start of the page. This has already been identified in
issues such as 9319, so I'm ignoring that for now.
BUG=2913
TEST=Load Wikipedia, visit a page with many subheadings,
left click on a subheading, verify the current page
scrolls to the correct heading. Click back, verify you
are taken back to your original position. Middle click
on the same subheading, verify a new tab is loaded in
the background that is scrolled to the correct heading.
Review URL: http://codereview.chromium.org/155522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=createImageElement2 layout test
BUG=15977
Review URL: http://codereview.chromium.org/155533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fontconfig will return fonts which are unreadable to the current
process if the system cache contains them.
BUG=16715
http://codereview.chromium.org/149628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
merge 44202:44252.
TBR=dglazkov
TEST=layout test
BUG=12881
Review URL: http://codereview.chromium.org/155452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16742
TEST=none
Review URL: http://codereview.chromium.org/149634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the test was made platform-independent in change 20646, but I missed deleting
this file in the linux directory
BUG=https://crbug.com/16241
REVIEWER=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/155529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16502
TEST=setting defaultPlaybackRate before the media starts playing should be respected when play() is called
Review URL: http://codereview.chromium.org/155404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test runs just under 10 seconds (the default timeout value) on a
fast machine; on a slow machine (or in a VM like my XP VM) it can take
closer to 15-20 seconds and hence timeout.
BUG=https://crbug.org/16240
R=dglazkov
TEST=none
Review URL: http://codereview.chromium.org/149431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20647 0039d316-1c4b-4281-b951-d872f2087c98
|