| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used for gears file drag & drop in chrome, assign a drag id (identity) to
each drag and drop session.
Send the identity to the renderer WebViewImpl in drag enter notifications,
provide a getter method.
BUG=7995
Original patch by noel.gordon@gmail.com in:
http://codereview.chromium.org/28108/show
Review URL: http://codereview.chromium.org/28158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/28166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
complains without it.
TBR=mark
Review URL: http://codereview.chromium.org/27188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new WebKitClientImpl class is added to webkit/glue that consumers can use to
help implement WebKitClient. In the future, consumers will likely subclass
WebKitClientImpl. For now, that is not necessary.
Since a WebImage may not hold a SkBitmap, I needed to modify
ScopedClipboardWriterGlue to not deal in SkBitmaps. So, I just added a
WriteBitmapFromPixels method in place of the WriteBitmap method. That method
is actually named the same as the one from the base class, which is perhaps
kind of nice since the purpose of ScopedClipboardWriterGlue is to override the
default way of sending an image to the clipboard!
R=dglazkov
Review URL: http://codereview.chromium.org/28119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(LayoutTests/fast/forms/listbox-deselect-scroll.html,
LayoutTests/fast/forms/listbox-selection-2.html and
LayoutTests/fast/forms/select-item-background-clip.html). They are
failing for two reasons:
. One is using meta instead of control. This is upstreamed as
https://bugs.webkit.org/show_bug.cgi?id=24161 .
. The second is we end up using a small scroll bar size, but measure
as though we used a regular scroll bar size. There are actually two
bugs here, one is we shouldn't be using small, but regular. Secondly
we measure against the wrong size. Both are upstreamed as
https://bugs.webkit.org/show_bug.cgi?id=24171.
Neither of these are important for current release, so I'm DEFERing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/28148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
results.
TBR=ojan
Review URL: http://codereview.chromium.org/28155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit 1dbbeb791d5a9ae0740afb5d7eb57710c93b7f38.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
just adding/removing files, no changes to glue code
Review URL: http://codereview.chromium.org/27164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was driving me nuts, so I just fixed it.
We now behave more or less like Firefox.
Review URL: http://codereview.chromium.org/28140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
be displayed in the wrong place when shown in a sub-frame.
BUG=8072
TEST=See bug.
Review URL: http://codereview.chromium.org/28141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds accelerators to all the menu items that had them on windows.
- Adds accelerators to back (Alt+left), forward (Alt+right), reload
(Ctr+R) and focus the URL box (Ctr+L).
Review URL: http://codereview.chromium.org/28105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different, and the corners are antialised in a darker shade, giving it the appearance that the corners are not rounded compared to the baseline.
Review URL: http://codereview.chromium.org/28133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or resized.
TEST=Bring up an autofill popup in a form, move the browser. The autofill popup should be closed.
BUG=7401
R=ben
Review URL: http://codereview.chromium.org/28126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This fixes issue 6173. The pan cursor icons had their
hotspots set to the upper left corner, which was causing
them to be drawn offset down and to the right. Set the
hotspot to (16,16).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See https://bugs.webkit.org/show_bug.cgi?id=20342
Review URL: http://codereview.chromium.org/28055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.appspot.com/21071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While explicitly looking for layout test crashes I came
across a few layout tests marked as PASS CRASH, which
are associated with bugs that have since been fixed
and the test doesn't seem to be crashing any longer.
Those tests can therefore be removed from the list.
Review URL: http://codereview.chromium.org/27123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
StopLoading. This is problematic because StopLayout may end up
changing state in the layout test controller (the frozen status of the
WorkQueue in this case). I've changed it to reset the status after
invoking StopLoading.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/27109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* rearrange some IFDEFs
* trim whitespace on suggest name
Also fix a relatively new bug in DomSerializer.
Review URL: http://codereview.chromium.org/27106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_LBUTTONUP, etc. However
we need to reset the popup stack in a timer, as Flash typically brings up these windows in a posted
0x401 message. This is on the same lines as the webkit plugin implementation.
This fixes http://code.google.com/p/chromium/issues/detail?id=7850
Bug=7850
Review URL: http://codereview.chromium.org/29004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes some linux/mac issues that were pending and fix up the scons build to
expect the file in the grit subdir.
BUG=7537
Review URL: http://codereview.chromium.org/28035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I noticed we have a bunch of tests that have
been passing for a while, some of those are
new tests that failed as they got merged in,
but are now passing on some/all platforms.
Review URL: http://codereview.chromium.org/27104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Differs from windows baseline only in the scrollbar.
TBR=dglazkov
Review URL: http://codereview.chromium.org/27101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is a new upstream test added in r41153:
http://trac.webkit.org/changeset/41153
we match except for font metrics and scrollbars.
TBR=dglazkov
Review URL: http://codereview.chromium.org/28086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
3 bidi-linebreak tests were recently added and are passing (just need baseline due to font differences).
stroking-decorations looks like it can be baselined now. Was always failing before, is now failing because we compare against the mac (font differences).
I also removed a few failures notices from a recent merge, that are now passing.
Review URL: http://codereview.chromium.org/28082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Add platform specific chromiumclipboard files.
- Some methods got renamed in renderlayer, so change some method names in our glue code.
Review URL: http://codereview.chromium.org/27096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
border, and one point in the body, which looks very minor on close inspection, and I think its OK to rebaseline.
Review URL: http://codereview.chromium.org/28074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/28047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mark
Review URL: http://codereview.chromium.org/28038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Cache Gestalt's value since it opens files.
* Do a little cleanup in sys_info while I'm there and add a unit test.
* Label some methods as not being threadsafe on OSX/POSIX.
Review URL: http://codereview.chromium.org/27088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/27076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
If an exception occours in some of the code used to locate the line number of the source on the top stack frame an empty handle will be returned and using Int32Value on it will cause a crash. As of now I have not been able to find a case where an exception to happens though.
BUG=7912
Review URL: http://codereview.chromium.org/28024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
these two tests are failing on the windows build bot
TBR=eseidel
Review URL: http://codereview.chromium.org/27078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsView, since it's part of the "chrome".
Design Doc: http://dev.chromium.org/developers/design-documents/find-bar
Things done:
- Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed.
- Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view.
- Moved find control methods to WebContents.
- Added recent find result state to WebContents.
- Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered.
- Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc.
- Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs.
- Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab.
- view.h: Don't lay out child views again if they have a layout manager, it already updated them.
TEST=Find box should work as before.
BUG=3245
Review URL: http://codereview.chromium.org/27025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better).
Review URL: http://codereview.chromium.org/27054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
too), but
updating DEPS seems to have hosed Mac, so I'm reverting.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/28037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dragging images:
. It's possible for the extension to be empty, resulting in a bad file
name, for example, 'foo.' or just '.'.
. We weren't restricting the size of the file to MAX_PATH.
. We weren't removing characters that are invalid for file system names.
It's possible to put this code up in OSExchangeData rather than
here, but it feels best to centralize it here so that we don't have to
worry about bad file names leaking into other code.
I tried hard to write a layout test for this, but it seems we don't
really use the file name in test shell so that I couldn't get
coverage.
BUG=7023
TEST=none
Review URL: http://codereview.chromium.org/20504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
edge anti-aliased in a slightly different shade. The rest looks fine.
Review URL: http://codereview.chromium.org/28032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=tony
Review URL: http://codereview.chromium.org/28030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a passing test as passing.
In r10137 I took out the wrong test.
Review URL: http://codereview.chromium.org/27044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10192 0039d316-1c4b-4281-b951-d872f2087c98
|