| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
LayoutTests/editing/text-iterator/basic-iteration.html to point to a specific bug, rather than a generic merge bug. Also moves all editing tests that are failing due to unimplemented test shell features into one section of the expectations file.
TEST=none
BUG=23285,11322
Review URL: http://codereview.chromium.org/235049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21841,23306
TEST=none
Review URL: http://codereview.chromium.org/245038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make valgrind happy, this CL changes WebKeyboardEvent::isSystemKey and WebMouseWheelEvent::scrollByPage to int type to make sure the size of WebKeyboardEvent and WebMouseWheelEvent align to a factor of 4 bytes strictly.
BUG=22857: Uninitialized memory sent via IPC from RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent()
TEST=Run chrome with valgrind and input something or scroll the mouse wheel in a web page, valgrind should not complain uninitialized memory anymore.
Review URL: http://codereview.chromium.org/235038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/235048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other formats because when pasting, we want to make sure the image
has priority.
This method appears to only be called from the image context menu
and when viewing an image only in a tab and using copy (ctrl+c or from
the page menu). In both of these cases, if the user wants the URL,
they can use the context menu "copy image url" to get the URL.
BUG=21593
Review URL: http://codereview.chromium.org/254006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16779
TEST=layout tests
After a long rewriting of media layout tests, we are able to enable them
again. This change will leave us abotu 19 (out of 98) real failures.
Review URL: http://codereview.chromium.org/249007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
complete the WebKit bug fix https://bugs.webkit.org/show_bug.cgi?id=29109.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
slate when converting the hash parameters to the currentState object.
Review URL: http://codereview.chromium.org/242038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add some layout tests for me to investigate (likely just a rebaseline).
BUG=None
TEST=None
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/251018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled in the build. Change ENABLE_3D_CANVAS to 1 in
src/third_party/WebKit/WebKit/chromium/features.gypi and regenerate
project files to compile. Current code is Windows-specific and
requires the sandbox to be disabled. Follow-on work will add ports to
other platforms and eventually work with the sandbox enabled.
This CL follows https://bugs.webkit.org/show_bug.cgi?id=29664 .
BUG=http://code.google.com/p/chromium/issues/detail?id=21852
TEST=none (runs preexisting WebGL layout tests; more coming)
Review URL: http://codereview.chromium.org/219001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324
Review URL: http://codereview.chromium.org/153002
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/235042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/48759.
TBR=abarth
TEST=none
BUG=17523
Review URL: http://codereview.chromium.org/249019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix division by zero if running only 1 WONTFIX test.
2) Do not add to the missing list if a test missing the result is marked as WONTFIX.
Also update the test_expectation list:
1) Remove SKIP for one test so that we can rebaseline it later.
2) Remove a qt test that was skipped previously because its missing result.
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/246013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser crash that triggers ~100 times a day:
`anonymous namespace'::PureCall()
_invalid_parameter_noinfo
std::vector<unsigned char,std::allocator<unsigned char> >::operator[](unsigned int)
WebCursor::GetCursor(HINSTANCE__ *)
RenderWidgetHostViewWin::UpdateCursorIfOverSelf()
RenderWidgetHostViewWin::UpdateCursor(WebCursor const &)
I was unable to reproduce myself, so I don't know if the bad cursor came from
the web or from the Windows "external cursor" concept. Accordingly:
- Do not accept 0-sized cursors from the renderer.
- Do not access array[0] on an empty array as per other call sites in the
cursor code.
Thanks to The Mighty Hoppy for triggering this via means unknown!
BUG=NONE
TEST=NONE (unable to reproduce)
Review URL: http://codereview.chromium.org/251008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
off the appropriate archive directory. This allows us to not lose the
layout tests results history one one of the bots is clobbered.
A small change is needed to the buildbots to pass in the --build-name flag
before we'll be able to actually grab the results of archive location.
Review URL: http://codereview.chromium.org/246014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=LayoutTests/fast/loader/*
BUG=8407
Review URL: http://codereview.chromium.org/243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the list.
BUG:9798
Review URL: http://codereview.chromium.org/248018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it fails too often on linux.
Also disable LayoutTests/transitions/transition-end-event-left.htmt
It looks like all the transition-end-event-* are flaky.
BUG:9798
Review URL: http://codereview.chromium.org/248015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add failure for newly added test for me to investigate.
TBR=senorblanco@chromium.org
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/242023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling right up to the next breakage.
Adding new breakages that I need to investigate.
TBR=senorblanco@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/251006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/244017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/244014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change to this file was wrong, the new values for expectations are
'TEXT', 'IMAGE', and 'IMAGE+TEXT' ('BOTH' is not a valid value).
R=ojan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/245019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the text output, tests that fail due to differences in the image output,
and tests that fail both.
This adds the additional failure types 'IMAGE', 'TEXT', and 'BOTH' to
test_expectations.txt. Tests that are marked 'FAIL' should eventually be
migrated to one of the above three, but for now FAIL means that any of the
three types might happen.
Note that we do not distinguish between a text diff and a simplified text
diff; 'TEXT' will cover either or both types of failures.
BUG=none
TEST=none
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/235016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The div is taller on Linux, looks like by about 1px per line.
Matchin Windows font metrics in RTL = :(.
BUG=11122
Review URL: http://codereview.chromium.org/235032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TrackMouseFoo functions were added to match Windows, but
we're obviously passing all these layout tests without 'em
and the body of the function is empty.
BUG=9523
Review URL: http://codereview.chromium.org/235031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Completely rewrite the way we figure out which expectations apply to which
platform. This approach is ~30% faster and now we can cache the results, so
subsequent calls to processTestRunsForBuilder are two orders of magnitude
faster. Also, this fixes a number of bugs where we would incorrectly deal with
fallback for a given platform. For example:
LINUX = LayoutTests/accessibility = PASS FAIL
MAC = LayoutTests/accessibility/foo.html = CRASH
Before, even on the linux view, we'd think that linux had no expectations for
this test.
-Consolidate invalid key logging. There's a bunch of logging that happens
at the beginning now. The logging is useful, so I'm not totally sure how to
avoid the noise.
-Allow for comma or space separated lists in the list of tests for the
individual tests view. This allows for copy pasting from the list of tests
that have never failed into the test input box.
-Fix bug where we couldn't get back to the builder view from the individual
tests view.
-Once we've loaded the current builder's view, asynchronously call
processTestRunsForBuilder for all the other builders. This makes other actions
like going to a different builder or clicking on an individual test much faster.
-Add support for WIN-XP and WIN-VISTA modifiers.
Review URL: http://codereview.chromium.org/219024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21841
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/235026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expectations include failures, and we pass everything
BUG=10859
BUG=10861
TEST=green layout bots
Review URL: http://codereview.chromium.org/231009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a temporary failure for a newly added test.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/242005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/48701 (xhr-related changes)
http://trac.webkit.org/changeset/48690 (chromium-only test migration)
http://trac.webkit.org/changeset/48699 (chromium-only test migration)
R=jparent
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/246002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21841
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/246008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9798,10475,22014
TEST=green is good
TBR=dglazkov
Review URL: http://codereview.chromium.org/248002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is kinda like yelling, right?
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/241002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/246001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
plaintext onto a clipboard in Chromium. The method is declared upstream, in a patch associated with
https://bugs.webkit.org/show_bug.cgi?id=29634
Review URL: http://codereview.chromium.org/211052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=UI test and valgrind test pass
TBR=markus
Review URL: http://codereview.chromium.org/222031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we have to be careful to consistently round in the same direction.
Timeout checks usually check if Now() is less or equal to a deadline in order
to determine if a timeout has occurred. This correctly handles the case where
actual sleep times are equal or longer than requested sleep times.
But if we round down when setting the sleep delay, this can result in
unnecessary and expensive looping. Make sure, we always round up when converting
to a format with less precision.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10476
TEST=NONE
TBR=dglazkov
Review URL: http://codereview.chromium.org/239005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Match the new interfaces used for StorageNamespace in WebKit.
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/219038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of vista bot which is not stable now.
TBR=dpranke
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/224013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous version of the code assumed that \r\n (CRLF) will always be used.
The FTP spec is extremely imprecise about the LISTing format.
TEST=See bug.
BUG=22879
Review URL: http://codereview.chromium.org/238001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. Downstreamed building webkit/extension/v8/*.cc files, which were built by upstream webcore by mistake. Now glue will build them.
I tested that even though webcore still builds them, there are no errors if glue also builds them.
2. Added webkit_chromium_port variable to build/common.gypi which is turned off by default. Currently, nothing uses it but the chrome port will need it.
Review URL: http://codereview.chromium.org/220026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22926
TEST=still builds
Review URL: http://codereview.chromium.org/231020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12282
TEST=green layout bots
Review URL: http://codereview.chromium.org/222015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thomasvl
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/238002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27095 0039d316-1c4b-4281-b951-d872f2087c98
|