| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
in the way the rotated border is drawn, compared to the existing baseline. This probably happens due to slight difference in the way Skia anti-aliases lines.
Review URL: http://codereview.chromium.org/19519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DocumentMarker with the same start- and endOffset,
which AddMarker in WebKit will ignore. As a result,
our marker vector is empty and we try to access
the element with index -1.
Also added a check to avoid a NOTREACHED in debug
build, which can happen under normal circumstances
(when you navigate away from a page when a search
is in progress).
BUG=http://crbug.com/7250
TEST=We don't have reproduction steps for the
crash but if we stop seeing this on our crash
server we'll know that it is fixed.
Review URL: http://codereview.chromium.org/20028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous change was causing image baselines to be treated as
text only diffs so images were being copied into the chromium-win
dir by accident. Fix this by reverting the change from test_type_base.py
and applying it to text_diff.py instead.
Review URL: http://codereview.chromium.org/20021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we can override the via custom_vars in .gclient on the bots
and official builds updates the merge script appropriately.
Also updates checkdeps to be Var-aware.
Review URL: http://codereview.chromium.org/19508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests_fixable.
I upstreamed a change that should make this always pass.
BUG=none
TEST=none
TBR=finnur
Review URL: http://codereview.chromium.org/21022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
failing layout tests to pass.
Review URL: http://codereview.chromium.org/19544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
failing (have been passing for a while now).
Review URL: http://codereview.chromium.org/19801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- make more methods const
- remove unneeded #includes
BUG=7210
Review URL: http://codereview.chromium.org/19535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
And the failures for MAC were duplicates.
TBR=ojan
Review URL: http://codereview.chromium.org/20016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The death of FrameLoaderClient.cpp correspond with
<http://trac.webkit.org/changeset/40435>
* The custom V8 binding for V8HTMLFormElement::submit() corresponds with
<http://trac.webkit.org/changeset/40424>
* Changes to FrameLoader::loadFrameRequestWithFormAndValues() and
FrameLoadTypeRedirectWithLockedHistory correspond with
<http://trac.webkit.org/changeset/40432>
* No action was taken for the disable-web-security change
<http://trac.webkit.org/changeset/40449>, defaults to enabled.
* Frame::isFrameSet() moving to Document::isFrameSet corresponds with
<http://trac.webkit.org/changeset/40443>
* Frame::sendResizeEvent() moved to EventHandler::sendResizeEvent()
<http://trac.webkit.org/changeset/40444>
* Not sure which webkit change added RenderObjectChildList.cpp.
=======================
Rebaselined the following layout tests to reflect upstream changes:
=======================
* LayoutTests/fast/table/form-with-table-style.html
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/table/form-with-table-style-expected.png?rev=40457
* LayoutTests/fast/table/insert-row-before-form.html
http://trac.webkit.org/changeset/40456/trunk/LayoutTests/platform/mac/fast/table/insert-row-before-form-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/fast/table/insert-row-before-form-expected.txt
* LayoutTests/tables/mozilla/bugs/bug4527.html
http://trac.webkit.org/changeset/40458/trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt
* LayoutTests/tables/mozilla/bugs/bug96343.html
http://trac.webkit.org/changeset/40458/trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug96343-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug96343-expected.txt
* LayoutTests/tables/mozilla_expected_failures/bugs/bug1725.html
http://trac.webkit.org/changeset/40459/trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt?old=30635&old_path=trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
* LayoutTests/tables/mozilla_expected_failures/other/test4.html
http://trac.webkit.org/changeset/40460/trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt?old=34683&old_path=trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
* LayoutTests/editing/deleting/deletionUI-single-instance-actual.png
http://trac.webkit.org/changeset/40454/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt?old=32226&old_path=trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt
Review URL: http://codereview.chromium.org/21007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tests_fixable.
TBR=maruel
Review URL: http://codereview.chromium.org/21012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
are the same as the Windows resulsts.
Review URL: http://codereview.chromium.org/20013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Changed WebMediaPlayerDelegateImpl to contains a PipelineImpl object rather keeping a pointer to Pipeline interface. Also added code for task coordination between pipeline thread and main thread.
Review URL: http://codereview.chromium.org/19481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
unit tests. Add stacking_order.* (needed for linking).
Review URL: http://codereview.chromium.org/19769
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(No code change - got permission from tc to check this in)
Review URL: http://codereview.chromium.org/19514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
marking one tests that's been crashing on the mac build bots.
Review URL: http://codereview.chromium.org/19543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser.
Review URL: http://codereview.chromium.org/14142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows-specific and have plugin_impl.h include the
correct version based on the platform.
jam: primary
evan: FYI
Review URL: http://codereview.chromium.org/19727
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
numberOfActiveAnimations has been implemented.
Review URL: http://codereview.chromium.org/19730
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in http://src.chromium.org/viewvc/chrome?view=rev&revision=8968
Review URL: http://codereview.chromium.org/19722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pam
Review URL: http://codereview.chromium.org/19720
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we can override the via custom_vars in .gclient on the bots
and official builds.
Also pulls JavaScriptCore from webkit.org and updates
the merge script appropriately.
This is blocked on http://code.google.com/p/gclient/source/detail?r=41
being checked in an pushed.
Review URL: http://codereview.chromium.org/19690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
few Layout tests passing.
Review URL: http://codereview.chromium.org/19490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onload-navigation-iframe.html
onload-navigation-iframe-timeout.html
The tests submit a form to about:blank.
They fail because there is no ? at the end of about:blank when we land to the new page.
This is because the GURL implementation treats about:blank as a path URL and sets no query for it.
Note: the test diff files are in my home dir under the layoutest_onload dir.
Review URL: http://codereview.chromium.org/19492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/19505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Updated one flaky tests w/ crash status also since it's happened a few times last
24 hours.
Review URL: http://codereview.chromium.org/19708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
identical to the Windows expectations (and Linux falls back to Windows
results).
Review URL: http://codereview.chromium.org/19500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In theory these baselines can be shared between all platforms, but
we don't have a common dir. To reduce the amount of duplicate
work, have run_webkit_tests put the file in the right places.
Review URL: http://codereview.chromium.org/19688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/19489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as passing. It's passed the last 10 or so times on debug and release.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/19686
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the ignored list. Here's what I believe is happening:
// This test has hover effects that change the font size. This test also
// moves the mouse around, resulting in a layout that dances around.
// Depending upon when the snapshot is taken we get different results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it fails because of font size differences.
Review URL: http://codereview.chromium.org/19478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome_dll (we use the methods in renderer_glue.cc instead).
Review URL: http://codereview.chromium.org/19678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer. Based on the crash dump, the crash occurs in the windows message filter hook, used for tracking whether the plugin enters a modal loop. The global plugin instance pointer gets reset to NULL in the windowed plugin wndproc and HandleEvent. If these events occur in nested order, then it is quite possible for the plugin instance pointer to get set to NULL incorrectly.
Added a check for whether this pointer is NULL in the message filter hook along with a NOTREACHED statement.
We maintain a local global stack to ensure that the plugin instance pointer gets set/reset correctly.
The bug is http://code.google.com/p/chromium/issues/detail?id=6703
The other issue being fixed is to set the modal_loop_pump_messages_event coming in from the plugin
in WebPluginDelegateProxy correctly. This caused the plugin to not receive events when it enters a modal loop like a context menu.
Bug=6703
Review URL: http://codereview.chromium.org/19444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get loaded correctly.
Review URL: http://codereview.chromium.org/19676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8912 0039d316-1c4b-4281-b951-d872f2087c98
|