summaryrefslogtreecommitdiffstats
path: root/win8/viewer
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, ↵thestig2014-09-101-1/+1
| | | | | | | | | | chromecast/, cloud_print/, mojo/, and win8/ TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/559743002 Cr-Commit-Position: refs/heads/master@{#294139}
* Decouple IPC::MessageFilter from IPC::Channelmorrita@chromium.org2014-06-131-1/+1
| | | | | | | | | | | | | This change gets rid of Channel dependency from MessageFilter so that it depends only on IPC::Sender. TEST=none BUG=377980 R=jam@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/324143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276939 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC::Channel polymorphicmorrita@chromium.org2014-06-061-2/+2
| | | | | | | | | | | | | | This change makes each platform specific ChannelImpl into a subclass of Channel: ChannelPosix, ChannelWin, ChannelNacl. delegated functions are now virtual. TEST=none BUG=377980 R=darin@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/310293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275505 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()morrita@chromium.org2014-06-051-5/+4
| | | | | | | | | | | | | | | | | | | This change replaces constructors with Create() methods of ChannelProxy and SyncChannel. This open the possibility to introduce polymorphism to these classes. This is a revision of r274310 (https://codereview.chromium.org/301973003/) in which I added bunch of Create*() method variants. The chagne was reverted. This change no longer does it and just keeps using Channel::Mode to specify the channel type. TEST=none BUG=377980 R=darin@chromium.org,jam@chromium.org Review URL: https://codereview.chromium.org/310853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275140 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 274310 "Introduce IPC::ChannelProxy::Create*() and IPC::S..."lambroslambrou@chromium.org2014-06-021-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke Windows compile: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=180 FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\remoting\host\win\remoting_core.wts_session_process_delegate.obj.rsp /c ..\..\remoting\host\win\wts_session_process_delegate.cc /Foobj\remoting\host\win\remoting_core.wts_session_process_delegate.obj /Fdobj\remoting\remoting_core.cc.pdb c:\b\build\slave\win_x64_builder\build\src\remoting\host\win\wts_session_process_delegate.cc(386) : error C2661: 'IPC::ChannelProxy::ChannelProxy' : no overloaded function takes 4 arguments ninja: build stopped: subcommand failed. > Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() > > This change hides constructors of these classes so that we can turn > them polymorphic classes. > > Note that having almost identical ChannelProxy::Init*() isn't great > and they will be replaced by a factory-like abstraction in coming > changes. > > TEST=none > R=darin,cpu > BUG=377980 > > Review URL: https://codereview.chromium.org/301973003 TBR=morrita@chromium.org Review URL: https://codereview.chromium.org/312553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274315 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*()morrita@chromium.org2014-06-021-3/+2
| | | | | | | | | | | | | | | | | This change hides constructors of these classes so that we can turn them polymorphic classes. Note that having almost identical ChannelProxy::Init*() isn't great and they will be replaced by a factory-like abstraction in coming changes. TEST=none R=darin,cpu BUG=377980 Review URL: https://codereview.chromium.org/301973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274310 0039d316-1c4b-4281-b951-d872f2087c98
* Promotes metro related functions to MetroViewerProcessHostsky@chromium.org2014-05-293-7/+340
| | | | | | | | | | | | | Since all these functions need the MetroViewerProcessHost it makes more sense to put them here. BUG=none TEST=none R=ananta@chromium.org Review URL: https://codereview.chromium.org/294043011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273418 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in RemoteWindowTreeHostWin::HandleActivateDesktopsky@chromium.org2014-05-211-1/+1
| | | | | | | | | | | | | | | Rather than route this through RemoteWindowTreeHostWin (which can now be NULL) I'm routing it through ChromeMetroViewerProcessHost. I'm also adding a NULL check as it may be possible in some code paths for the host to have been disconnected and therefor NULL. BUG=374766 TEST=none R=ananta@chromium.org Review URL: https://codereview.chromium.org/297713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271816 0039d316-1c4b-4281-b951-d872f2087c98
* Send the device scale factor from Windows 8 ASH during initialization via ↵ananta@chromium.org2014-05-131-1/+2
| | | | | | | | | | | | | | | | | | the MetroViewerHostMsg_SetTargetSurface IPC message. cpu, please review everything. sky, please review the ash/chrome/ui portions. I added a dependency on gfx in the metro_driver project for a subsequent change to send the correct device scale factor on Windows 8 as the metro API does not appear to work correctly causing text, etc to appear very small on high dpi monitors with scales above 125%. BUG=371219 R=cpu,sky Review URL: https://codereview.chromium.org/271543009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269993 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPC::MessageFilter and router to a separate filedmichael@chromium.org2014-04-252-2/+5
| | | | | | | | | | | | | | | There are no changes in implementation in this CL. This is in preparation for making IPC::Channel support filters on the Channel's thread. BUG=364241 TBR=cpu@chromium.org,nduca@chromium.org cpu: OWNERS for win8 nduca: OWNERS for components/tracing Review URL: https://codereview.chromium.org/245443005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266057 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd part of porting Chrome Ash to Windows 7ananta@chromium.org2014-04-181-10/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the Chrome side that 1- removes windows 8 specific checks 2- disconnects the fake window_tree_host_win 3- connects the remote_window_tree_host_win With this change you can now see the ash desktop but not interact with it since input events have not been enabled. Here is the second part https://codereview.chromium.org/211863003/ First part with rationale: https://codereview.chromium.org/199843004/ Note: this is a redo & rebase of https://codereview.chromium.org/227573007/ BUG=356475 TEST=none patch from issue 235683005 BUG= Review URL: https://codereview.chromium.org/235933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264680 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness on the win8 builder on the waterfall.ananta@chromium.org2014-03-252-9/+32
| | | | | | | | | | | | | | | | | | | | | There appear to be cases where in the metro viewer chrome process does not exit causing subsequent ash tests to fail. One of the errors we have seen in this context is E_APPLICATION_ACTIVATION_TIMED_OUT. Currently ash_unittests does not clean shutdown the viewer. It closes the channel and terminates the viewer process via TerminateProcess. That call could fail if the viewer process has a thread in the kernel stack which could lead to subsequent tests to fail. Fix is to attempt a clean shutdown of the viewer process. For this we maintain the message filter for the lifetime of the MetroViewerProcessHost class. We signal an event when the channel is actually closed in the hosting process which should ensure that the viewer exits cleanly and also wait for the viewer to die. This code only executes for tests. BUG=340422 R=cpu@chromium.org, scottmg@chromium.org, cpu Review URL: https://codereview.chromium.org/203273008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259080 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window_host* in aura to window_tree_host*.ben@chromium.org2014-02-141-1/+1
| | | | | | | | | | R=sky@chromium.org TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/160573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251379 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost to WindowTreeHostben@chromium.org2014-01-081-1/+1
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/126513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16s in win8/.dbeam@chromium.org2013-12-201-2/+2
| | | | | | | | | R=grt@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/119733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242114 0039d316-1c4b-4281-b951-d872f2087c98
* Make LaunchViewerAndWaitForConnection() always result in the viewer not ↵gab@chromium.org2013-12-114-9/+11
| | | | | | | | | | | | | | | trying to launch a browser process back. scottmg did the necessary plumbing to make this true for ash_unittests (via "test_open"), but it should be true for all users of this path (i.e., currently that's only ash_unittests and browser_tests --ash-browsertests). This CL also adds the 'metro_viewer_constants' target to avoid having to depend on the 'metro_viewer' target itself in various other targets. BUG=286205 TEST=No more pipe errors on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Aura%20Ash%20(1) Review URL: https://codereview.chromium.org/98853005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239992 0039d316-1c4b-4281-b951-d872f2087c98
* Update Ash Display when resizing Metro windowscottmg@chromium.org2013-12-042-0/+5
| | | | | | | | | | | | | | | On a window sizing event from the metro viewer, we were previously only updating the aura root window. We also need to update the ash DisplayManager data so that the wallpaper and docking behaviour work correctly when going e.g. from a portrait display to a landscape display. R=ananta@chromium.org, sky@chromium.org BUG=306629, 319051 Review URL: https://codereview.chromium.org/102783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 236048 "Rename RootWindowHost* to WindowTreeHost*"ben@chromium.org2013-11-201-1/+1
| | | | | | | | | | | | | | | > Rename RootWindowHost* to WindowTreeHost* > > TBR=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/76583003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/77203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost* to WindowTreeHost*ben@chromium.org2013-11-191-1/+1
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/76583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
* don't launch chrome.exe when running in metro test binaryscottmg@chromium.org2013-11-082-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | In ash_unittests, TestMetroViewerProcessHost launches the metro viewer, and the metro viewer is expected to connect back to it. By default though, it launches chrome because it normally needs to do that to have something to connect to. Normally, ash_unittests creates the pipe, so chrome.exe's pipe creation fails, and then chrome.exe shuts down when the viewer shuts down. If, however, chrome takes longer to start, then the ash_unittests test may finish, try to kill chrome.exes, then chrome.exe starts up and creates the host pipe, then the next ash_unittest test starts up, and fails because it will fail to create the pipe. To avoid this race, pass an argument to the viewer (normally "open", now in tests "test_open") that inhibits it from starting chrome.exe R=ananta@chromium.org TBR=sky@chromium.org BUG=303478,316012 Review URL: https://codereview.chromium.org/65623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233872 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in win8 for base/process changes.rsesek@chromium.org2013-07-241-1/+1
| | | | | | | | | BUG=242290 TBR=mad@chromium.org Review URL: https://chromiumcodereview.appspot.com/19672020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213503 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in webkit/, win8/.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18029013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209154 0039d316-1c4b-4281-b951-d872f2087c98
* Make the browser<-->metro_viewer IPC channel name a constant instead of ↵gab@chromium.org2013-06-214-11/+37
| | | | | | | | | | | | | hardcoding it in a few places and passing it via a flag. Supporting a more generic use case via flags was making things more complicated for no apparent reason (other than perhaps one day supporting a random-channel-id -- I removed that TODO in this CL). This simplification will make it easier to introduce some sort of --viewer-launch-via-appid-and-connect flag for https://codereview.chromium.org/16022003/ BUG=179830 TEST=Can still launch Ash in Metro. Review URL: https://chromiumcodereview.appspot.com/15731003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207750 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in url/, win8/.avi@chromium.org2013-06-112-2/+2
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15709011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205663 0039d316-1c4b-4281-b951-d872f2087c98
* Support searching through the Windows 8 Search charm and url navigations ↵ananta@chromium.org2013-06-052-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | from the Start menu in Windows 8 ASH. Changes as below:- 1. In the metro driver we need to handle the search and protocol activation requests. Search requests when Chrome ASH is not running result in ASH being launched by Windows without going through the normal delegate execute mechanism. This means that the browser process will not be running to service the viewer ASH process. We need to launch the server via ShellExecute to ensure that it launches in desktop mode. If the search/protocol requests are received when Chrome ASH is being launched we ensure that the IPC messages to service these requests are sent out after the MetroViewerHostMsg_SetTargetSurface IPC. If Chrome ASH is running when we receive these requests we send out the search/navigation IPCs to Chrome. 2. Added the following IPC messages to metro_viewer_messages.h 1. MetroViewerHostMsg_SearchRequest 2. MetroViewerHostMsg_OpenURL The handling for these messages is implemented via virtual functions OnOpenURL and OnHandleSearchRequest in the MetroViewerProcessHost interface with the ChromeMetroViewerProcessHost overriding this to ensure that the URL is opened. 3. Added a switch kWindows8MetroSearch to chrome_switches.cc/.h. This is passed in from the metro driver on Windows 8 if we are launched to service a search request from the start screen. We don't attempt to create a browser or run the session restore code in the NOTIFICATION_ASH_SESSION_STARTED notification if this switch exists. The desired browser window for the search is created in the MetroViewerHostMsg_SearchRequest IPC. BUG=245899 R=cpu@chromium.org, jschuh@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/16282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204344 0039d316-1c4b-4281-b951-d872f2087c98
* Create MetroViewerProcessHost as a common base for ↵gab@chromium.org2013-05-242-0/+202
| | | | | | | | | | | | | | | | | TestMetroViewerProcessHost and ChromeMetroViewerProcessHost Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests). BUG=179830 1st Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201806 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=201966 R=robertshield@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14629025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 201806 "Create MetroViewerProcessHost as a common base fo..."dbeam@chromium.org2013-05-242-202/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke ash_unittests on Win8 Aura: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/6316 [ RUN ] AcceleratorControllerTest.Register [912:1324:0523/094526:1371217:INFO:test_metro_viewer_process_host.cc(42)] ash::test::TestMetroViewerProcessHost::OnSetTargetSurface, target_surface = 131580 [912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly(). Backtrace: base::debug::StackTrace::StackTrace [0x100839F1+33] logging::LogMessage::~LogMessage [0x100F6FCE+94] ash::test::AshTestBase::TearDown [0x006DC397+471] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319] testing::Test::Run [0x0072A525+229] testing::TestInfo::Run [0x0072AF4D+221] testing::TestCase::Run [0x0072B71F+239] testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327] testing::UnitTest::Run [0x00730BB0+192] base::TestSuite::Run [0x00756AE0+240] main [0x0058AFA4+100] __tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76D78543+14] RtlInitializeExceptionChain [0x7775AC69+133] RtlInitializeExceptionChain [0x7775AC3C+88] (No symbol) [0x00000000] [912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly(). Backtrace: base::debug::StackTrace::StackTrace [0x100839F1+33] logging::LogMessage::~LogMessage [0x100F6FCE+94] ash::test::AshTestBase::TearDown [0x006DC397+471] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319] testing::Test::Run [0x0072A525+229] testing::TestInfo::Run [0x0072AF4D+221] testing::TestCase::Run [0x0072B71F+239] testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327] testing::UnitTest::Run [0x00730BB0+192] base::TestSuite::Run [0x00756AE0+240] main [0x0058AFA4+100] __tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76D78543+14] RtlInitializeExceptionChain [0x7775AC69+133] RtlInitializeExceptionChain [0x7775AC3C+88] (No symbol) [0x00000000] > Create MetroViewerProcessHost as a common base for TestMetroViewerProcessHost and ChromeMetroViewerProcessHost > > Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests). > > BUG=179830 > > Review URL: https://chromiumcodereview.appspot.com/14629025 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/15966003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201966 0039d316-1c4b-4281-b951-d872f2087c98
* Create MetroViewerProcessHost as a common base for ↵gab@chromium.org2013-05-232-0/+202
TestMetroViewerProcessHost and ChromeMetroViewerProcessHost Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests). BUG=179830 Review URL: https://chromiumcodereview.appspot.com/14629025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201806 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-19 09:34:46 +0000