| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trying to launch a browser process back.
scottmg did the necessary plumbing to make this true for ash_unittests (via "test_open"), but it should be true for all users of this path (i.e., currently that's only ash_unittests and browser_tests --ash-browsertests).
This CL also adds the 'metro_viewer_constants' target to avoid having to depend on the 'metro_viewer' target itself in various other targets.
BUG=286205
TEST=No more pipe errors on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Aura%20Ash%20(1)
Review URL: https://codereview.chromium.org/98853005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a cleanup CL that never changes current behavior.
This CL uses CComObjectRootEx to avoid boilerplate COM implementation code
BUG=326912
TEST=manually done on Windows 8.1
Review URL: https://codereview.chromium.org/109723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a preparation CL to implement 'locale' property proposed in UI Events (formerly called d4e).
http://www.w3.org/TR/uievents/#idl-def-KeyboardEventInit
On Windows 8/8.1, a user can still choose per-process IME/keyboard layout model. Thus, we need to tell the browser process what IME/keyboard layout is used in the metro_driver process whenever it is changed.
BUG=168971
TEST=manually done on Windows 8.1
Review URL: https://codereview.chromium.org/109683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switches to desktop mode while opening the
downloads folder.
The current behavior is that the downloads folder is opened on the desktop while the user continues to stay in ASH mode
leading to confusion.
To fix this we reuse the ActivateDesktopHelper function in application_lifetime_win.cc. This function takes a boolean parameter
now which indicates if we should be exiting ash after activating the desktop. This flag is true when we launch desktop chrome from
ASH and is false when invoked to open the downloads folder via the functions in platform_util_win.cc. The MetroViewerHostMsg_ActivateDesktop
IPC now has a flag which indicates if we should exit ash after activating desktop. If this flag is false we terminate the
delegate_execute process which was launched to switch to desktop.
Fixes bug https://code.google.com/p/chromium/issues/detail?id=324252
BUG=324252
R=cpu@chromium.org, jschuh@chromium.org, sky@chromium.org, cpu
Review URL: https://codereview.chromium.org/102603006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, IMEs become functional under Ash environment on Windows.
Some optional features for Chromium internal use (e.g., IME popup window detection, RTL language detection) will be covered by subsequent CLs.
DesignDoc:
https://docs.google.com/a/chromium.org/document/d/14TBE0LoamQz_MImcNWzeTIW_lo5EUrLJwNwmCi20V1o/edit#
Note:
In this CL, ui/base/ime/win/tsf_text_store.* is not moved but copied to win8/metro_driver/ime/text_store.* in order not to break non-Aura build. That said, hereafter we will use win8/metro_driver/ime/text_store.* as primary implementation of TSF TextStore. Anyway, ui/base/ime/win/tsf_text_store.* will be removed when Aura transition is successfully completed.
I also found some style issues in win8/metro_driver/ime/text_store.cc but I'd like to fix them in subsequent CLs to keep this CL as minimum as possible.
BUG=164964
TEST=manually done on Windows 8.1
Review URL: https://codereview.chromium.org/83233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On a window sizing event from the metro viewer, we were previously
only updating the aura root window. We also need to update the
ash DisplayManager data so that the wallpaper and docking behaviour
work correctly when going e.g. from a portrait display to a
landscape display.
R=ananta@chromium.org, sky@chromium.org
BUG=306629, 319051
Review URL: https://codereview.chromium.org/102783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The point of this change is remove compilation of content_switches.cc
that was done in installer_util target. This is a static library
that other parts of chrome pull in and that makes the Chrome code that
references those switches compile even if the switches itself are
not exported.
Installer_util doesn't even seem to uses those switches AFAIK.
Dropped compilation of these files so these problems are actually
exposed and addressed by the person adding the switch. The main
offender that referenced those switches was chrome's about_flags.cc.
This is based off rchlodnicki@opera.com's patch from https://codereview.chromium.org/24994002/
R=rchlodnicki@opera.com, robertshield@chromium.org
Review URL: https://codereview.chromium.org/85333008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/90593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803
TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/90963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=321694
Review URL: https://codereview.chromium.org/79033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Rename RootWindowHost* to WindowTreeHost*
>
> TBR=sky@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/76583003
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/77203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/76583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
you can go into fullscreen via he wrench menu but cannot go out of fullscreen because the edge allowance is not enough.
This btw the same behavior we have since m26 for metro.
BUG=174738
Review URL: https://codereview.chromium.org/73063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This basically brings the code we have for m28 chrome that
uses alt-f4 trick to kill the metro viewer without leaving
the strange thumbnail window in the desktop left corner.
BUG=315919
TEST=see bug
Review URL: https://codereview.chromium.org/67633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ash_unittests, TestMetroViewerProcessHost launches the metro viewer,
and the metro viewer is expected to connect back to it. By default
though, it launches chrome because it normally needs to do that to
have something to connect to.
Normally, ash_unittests creates the pipe, so chrome.exe's pipe creation
fails, and then chrome.exe shuts down when the viewer shuts down. If,
however, chrome takes longer to start, then the ash_unittests test
may finish, try to kill chrome.exes, then chrome.exe starts up and
creates the host pipe, then the next ash_unittest test starts up, and
fails because it will fail to create the pipe.
To avoid this race, pass an argument to the viewer (normally "open",
now in tests "test_open") that inhibits it from starting chrome.exe
R=ananta@chromium.org
TBR=sky@chromium.org
BUG=303478,316012
Review URL: https://codereview.chromium.org/65623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$./tools/resources/optimize-png-files.sh -o2 -r10000 ui/webui/ win8
Processed 62 files (out of 69 files) in 00:24:44s
Result : 85472 => 68772 bytes (16700 bytes : 19 %)
BUG=313729
TBR=xiyuan@chromium.org,cpu@chromium.org
Review URL: https://codereview.chromium.org/57563008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed launch mode decision based on touch screen capability.
BUG=314818
R=ananta@chromium.org, ananta, cpu
TESTS=Please see bug description for steps.
Review URL: https://codereview.chromium.org/50883005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with new menu:
1. When in desktop mode, you should see "Relaunch Chrome in Windows 8 mode", if clicked it will kill current browser process and relaunches all open tabs in Windows 8 mode.
2. When in Windows 8 mode, menu is "Relaunch Chrome in desktop mode", if clicked it will kill current browser process (gets user out of Ash shell) and relaunches all tabs in desktop mode.
Once we select to launch in different mode through these menu items we store new mode in registry and use this mode as default mode for next time launch. This means even if you click on desktop icon and last mode stored is metro, user will be switched to metro mode.
BUG=280823
R=cpu@chromium.org, jschuh@chromium.org, sky@chromium.org, ananta, cpu
Review URL: https://codereview.chromium.org/32843009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
determine that Ash is the active desktop on Win8.
This is better than the VisibilityChanged event as it also handles the dual monitor case where Ash isn't hidden yet is no longer active (and Chrome desktop window can thus steal the "active desktop" state which was then not given back to the Ash desktop when re-focusing it. The WindowActivated event gets a CoreWindowActivationState_PointerActivated state for this specific case; which we treat the same as CoreWindowActivationState_CodeActivated for now.
Also remove the hooks for VisibilityChanged as they were only used for this purpose, i.e.:
https://code.google.com/p/chromium/codesearch#search/&q=OnRootWindowActivated&sq=package:chromium&type=cs
Called from: https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/env.cc&l=83
Called from: https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/root_window.cc&l=988
Called from: https://code.google.com/p/chromium/codesearch#chromium/src/ui/aura/remote_root_window_host_win.cc&l=463
BUG=177489
TEST=
The most reliable test I could find that would repro this is to:
1) Open Ash
2) Open Chrome on desktop on a 2nd monitor
3) Refocus Ash on first monitor
4) Signin with an account which will sync extensions (at least one of which opens a tab on install, e.g., https://chrome.google.com/webstore/detail/reload-all-tabs/midkcinmplflbiflboepnahkboeonkam).
Without this CL, this will result in the extension's tab opening on the desktop Chrome's window.
With this CL, the tab correctly opens in Ash as it was the last desktop focused.
Also make sure the regular use cases still work using the same test under:
A) Only Ash open
B) Ash open, but active desktop is native desktop.
Also confirmed using Sawbuck and some logging that the following is how OnWindowActivated() reports its state:
CoreWindowActivationState_CodeActivated == 0
- First activation
- Activated when hidden (either from Start Screen or Windows app switcher while viewing another app).
CoreWindowActivationState_Deactivated == 1
- All deactivations (including focusing a desktop app on the 2nd monitor while Ash remains open on 1st monitor)
CoreWindowActivationState_PointerActivated
- Ash is focused again after a window on another monitor had been focused while Ash stayed visible on its monitor.
R=cdn@chromium.org, grt@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/27058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By doing this we ensure any where in chrome (such as tooltips) that
query for keyboard state using windows api get consistent results for
metro-ash.
BUG=306048
TEST=none
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/26990004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landed previously in r225857, which was reverted in r225859 because it broke android tests.
BUG=103304
R=ben@chromium.org
Review URL: https://codereview.chromium.org/25015003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> gfx: Create a separate gfx component out of ui.
>
> BUG=103304
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/25015003
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/25161002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103304
R=ben@chromium.org
Review URL: https://codereview.chromium.org/25015003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/24413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no need to deactivate and reactivate the window. The Focus()
in particular is wrong in so far as we don't want focus to go to the
rootwindow.
BUG=284411
TEST=see bug
R=ananta@chromium.org
TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/23851042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
arguments from the metro driver on startup.
This is ok, because the command line processing code handles multiple requests to launch the viewer connection process
and ensures that there is only one channel created.
This handles the case where chrome is forcibly terminated on the desktop via Exit or a crash. Clicking on the metro chrome
tile which shows up at the top left should relaunch chrome ASH. This should also fix the search charm on Windows 8.
BUG=288033
R=cpu@chromium.org, cpu
Review URL: https://codereview.chromium.org/23464072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org,
Review URL: https://codereview.chromium.org/23851041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See the linked bug for more information about this change.
BUG=273248
gab: chrome/installer/*
ananta, cpu: win8/
Review URL: https://chromiumcodereview.appspot.com/23258005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browsers can force a metro -> desktop transition by calling ShellExecuteEx
with a special argument. However, the process that calls ShellExecute must
itself be a metro process. This change implements that behavior. Without
this change, triggering a relaunch in desktop mode while in ash would
launch chrome in the desktop mode, but it would not automatically transition
from metro to desktop.
cpu@:*metro*
bauerb@:chrome\browser\plugins\*
sky@:ui\aura\*
jschuh@:security review for ipc messages in ui\metro_viewer
BUG=280377
Review URL: https://chromiumcodereview.appspot.com/23592024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will launch into immersive.
BUG=278324
R=ananta
TBR=cpu
TEST=Please follow steps as mentioned in the bug description.
Review URL: https://chromiumcodereview.appspot.com/23301022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=grt@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23319004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=0
Review URL: https://chromiumcodereview.appspot.com/22861009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes bug https://code.google.com/p/chromium/issues/detail?id=271604 where Ctrl click on a url
would open it in the current tab on windows 8 ASH.
BUG=271604
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/22973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=242290
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/20106004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=242290
TBR=mad@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19672020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19510006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directories.
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18919005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/18286004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.
Collateral changes:
- base::win::MessageWindow registes a single window class used by all message-only windows it creates. The class is registered via base::LazyInstance.
- Added base::win::MessageWindow::FindWindow() wrapper used to find other message-only windows, including the other created by a different process.
- Removed chrome::kMessageWindowClass constant.
- chrome_frame_test::ContextMenuTest destroys the clipboard during the test teardown.
Review URL: https://chromiumcodereview.appspot.com/18348025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the save as operation is invoked.
The suggested file name is actually the path of the file. We need to get the name from there and display it in
the file save picker. This is done in the metro driver in the SaveFilePickerSession::StartFilePicker function.
cpu, please review everything.
sky, for owners review in ui\aura.
BUG=256424
R=cpu@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/18943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This might introduce some problem as per original comment, so please let me know if you remember any such issues.
But ideally I think we should pass metro keyboard flags without modifications.)
BUG=254697
R=ananta,cpu
TEST=Please follow steps as described in the bug.
Review URL: https://chromiumcodereview.appspot.com/18584005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> ProcessSingleton now uses base::win::MessageWindow to create a message-only window.
>
> Collateral changes:
> - base::win::MessageWindow registes a single window class used by all message-only windows it creates. The class is registered via base::LazyInstance.
> - Added base::win::MessageWindow::FindWindow() wrapper used to find other message-only windows, including the other created by a different process.
> - Removed chrome::kMessageWindowClass constant.
>
> Review URL: https://chromiumcodereview.appspot.com/17615003
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/18040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18029013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.
Collateral changes:
- base::win::MessageWindow registes a single window class used by all message-only windows it creates. The class is registered via base::LazyInstance.
- Added base::win::MessageWindow::FindWindow() wrapper used to find other message-only windows, including the other created by a different process.
- Removed chrome::kMessageWindowClass constant.
Review URL: https://chromiumcodereview.appspot.com/17615003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update all callers of InitLogging() to use LoggingSettings, only
setting fields that need a non-default value.
Turn LoggingDestination enum into a bit field and define add
LOG_DEFAULT and LOG_ALL constants.
Fix erroneous comment saying that the default was to not lock
the log file.
BUG=247594
TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/16519003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hardcoding it in a few places and passing it via a flag.
Supporting a more generic use case via flags was making things more complicated for no apparent reason (other than perhaps one day supporting a random-channel-id -- I removed that TODO in this CL). This simplification will make it easier to introduce some sort of --viewer-launch-via-appid-and-connect flag for https://codereview.chromium.org/16022003/
BUG=179830
TEST=Can still launch Ash in Metro.
Review URL: https://chromiumcodereview.appspot.com/15731003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch is unchanged but the previously failing multi-monitor test has been disabled since WinAsh doesn't support simultaneous multi-monitors (this patch just makes moving the single-monitor Ash desktop between different monitors).
TBR=cpu,cevans
Original description:
> Fix Ash on Windows multi-monitor support and snap-view sizing.
>
> Plumb through window size events to the remote root window host.
> Also add an initial sizing message to get Ash's initial state to be correct.
>
> BUG=236379
> TEST=Move Ash from one monitor to another with a different size, observe that things resize themselves correctly. Also, snap Ash, observe similar goodness.
>
> Review URL: https://chromiumcodereview.appspot.com/15599002
BUG=236379
TEST=ash_unittests
Review URL: https://chromiumcodereview.appspot.com/16267004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15709011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205663 0039d316-1c4b-4281-b951-d872f2087c98
|