From 04b8358f3650f0bf5e2250b89d0ef1be6c151e13 Mon Sep 17 00:00:00 2001
From: vmpstr <vmpstr@chromium.org>
Date: Thu, 25 Feb 2016 17:38:29 -0800
Subject: printing: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=thestig@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1731423002

Cr-Commit-Position: refs/heads/master@{#377762}
---
 printing/backend/print_backend.cc | 5 +++++
 printing/backend/print_backend.h  | 2 ++
 printing/page_setup.cc            | 2 ++
 printing/page_setup.h             | 1 +
 printing/print_settings.cc        | 2 ++
 printing/print_settings.h         | 1 +
 6 files changed, 13 insertions(+)

diff --git a/printing/backend/print_backend.cc b/printing/backend/print_backend.cc
index fefa789..6c43b64 100644
--- a/printing/backend/print_backend.cc
+++ b/printing/backend/print_backend.cc
@@ -10,6 +10,8 @@ PrinterBasicInfo::PrinterBasicInfo()
     : printer_status(0),
       is_default(false) {}
 
+PrinterBasicInfo::PrinterBasicInfo(const PrinterBasicInfo& other) = default;
+
 PrinterBasicInfo::~PrinterBasicInfo() {}
 
 PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults()
@@ -28,6 +30,9 @@ PrinterSemanticCapsAndDefaults::~PrinterSemanticCapsAndDefaults() {}
 
 PrinterCapsAndDefaults::PrinterCapsAndDefaults() {}
 
+PrinterCapsAndDefaults::PrinterCapsAndDefaults(
+    const PrinterCapsAndDefaults& other) = default;
+
 PrinterCapsAndDefaults::~PrinterCapsAndDefaults() {}
 
 PrintBackend::~PrintBackend() {}
diff --git a/printing/backend/print_backend.h b/printing/backend/print_backend.h
index a812332..621278b 100644
--- a/printing/backend/print_backend.h
+++ b/printing/backend/print_backend.h
@@ -23,6 +23,7 @@ namespace printing {
 
 struct PRINTING_EXPORT PrinterBasicInfo {
   PrinterBasicInfo();
+  PrinterBasicInfo(const PrinterBasicInfo& other);
   ~PrinterBasicInfo();
 
   std::string printer_name;
@@ -65,6 +66,7 @@ struct PRINTING_EXPORT PrinterSemanticCapsAndDefaults {
 
 struct PRINTING_EXPORT PrinterCapsAndDefaults {
   PrinterCapsAndDefaults();
+  PrinterCapsAndDefaults(const PrinterCapsAndDefaults& other);
   ~PrinterCapsAndDefaults();
 
   std::string printer_capabilities;
diff --git a/printing/page_setup.cc b/printing/page_setup.cc
index f0ea223..69442b0 100644
--- a/printing/page_setup.cc
+++ b/printing/page_setup.cc
@@ -41,6 +41,8 @@ PageSetup::PageSetup() {
   Clear();
 }
 
+PageSetup::PageSetup(const PageSetup& other) = default;
+
 PageSetup::~PageSetup() {}
 
 void PageSetup::Clear() {
diff --git a/printing/page_setup.h b/printing/page_setup.h
index 568b708..4126bea 100644
--- a/printing/page_setup.h
+++ b/printing/page_setup.h
@@ -36,6 +36,7 @@ class PRINTING_EXPORT PageMargins {
 class PRINTING_EXPORT PageSetup {
  public:
   PageSetup();
+  PageSetup(const PageSetup& other);
   ~PageSetup();
 
   void Clear();
diff --git a/printing/print_settings.cc b/printing/print_settings.cc
index 159cfa5..98dc0a8 100644
--- a/printing/print_settings.cc
+++ b/printing/print_settings.cc
@@ -125,6 +125,8 @@ PrintSettings::PrintSettings() {
   Clear();
 }
 
+PrintSettings::PrintSettings(const PrintSettings& other) = default;
+
 PrintSettings::~PrintSettings() {
 }
 
diff --git a/printing/print_settings.h b/printing/print_settings.h
index 6c4f8e7..29c0ced 100644
--- a/printing/print_settings.h
+++ b/printing/print_settings.h
@@ -48,6 +48,7 @@ class PRINTING_EXPORT PrintSettings {
   };
 
   PrintSettings();
+  PrintSettings(const PrintSettings& other);
   ~PrintSettings();
 
   // Reinitialize the settings to the default values.
-- 
cgit v1.1