From 10b945fdc76c0627e8863c2f8bce42dc563cae8d Mon Sep 17 00:00:00 2001 From: yusufo Date: Tue, 27 Oct 2015 16:18:03 -0700 Subject: Revert "Revert of Roll android_tools deps (patchset #4 id:60001 of https://codereview.chromium.org/1419533002/ )" Relanding CL after fixing lint errors for system_webview_apk This reverts commit de6b09140fd5cbf679ddbbe37d206848ab15d421. BUG=537270 Review URL: https://codereview.chromium.org/1403353004 Cr-Commit-Position: refs/heads/master@{#356426} --- DEPS | 2 +- .../android/webview/chromium/WebMessagePortAdapter.java | 3 +++ .../src/com/android/webview/chromium/WebViewChromium.java | 3 +++ .../webview/chromium/WebViewContentsClientAdapter.java | 1 + build/android/pylib/constants/__init__.py | 2 +- build/common.gypi | 2 +- build/config/android/config.gni | 2 +- build/secondary/third_party/android_tools/BUILD.gn | 1 + chrome/android/java/res/drawable-hdpi/ic_collapse.png | Bin 218 -> 0 bytes chrome/android/java/res/drawable-hdpi/ic_collapsed.png | Bin 0 -> 218 bytes chrome/android/java/res/drawable-hdpi/ic_expand.png | Bin 219 -> 0 bytes chrome/android/java/res/drawable-hdpi/ic_expanded.png | Bin 0 -> 219 bytes chrome/android/java/res/drawable-mdpi/ic_collapse.png | Bin 130 -> 0 bytes chrome/android/java/res/drawable-mdpi/ic_collapsed.png | Bin 0 -> 130 bytes chrome/android/java/res/drawable-mdpi/ic_expand.png | Bin 128 -> 0 bytes chrome/android/java/res/drawable-mdpi/ic_expanded.png | Bin 0 -> 128 bytes chrome/android/java/res/drawable-xhdpi/ic_collapse.png | Bin 176 -> 0 bytes chrome/android/java/res/drawable-xhdpi/ic_collapsed.png | Bin 0 -> 176 bytes chrome/android/java/res/drawable-xhdpi/ic_expand.png | Bin 179 -> 0 bytes chrome/android/java/res/drawable-xhdpi/ic_expanded.png | Bin 0 -> 179 bytes chrome/android/java/res/drawable-xxhdpi/ic_collapse.png | Bin 204 -> 0 bytes chrome/android/java/res/drawable-xxhdpi/ic_collapsed.png | Bin 0 -> 204 bytes chrome/android/java/res/drawable-xxhdpi/ic_expand.png | Bin 206 -> 0 bytes chrome/android/java/res/drawable-xxhdpi/ic_expanded.png | Bin 0 -> 206 bytes chrome/android/java/res/drawable-xxxhdpi/ic_collapse.png | Bin 263 -> 0 bytes chrome/android/java/res/drawable-xxxhdpi/ic_collapsed.png | Bin 0 -> 263 bytes chrome/android/java/res/drawable-xxxhdpi/ic_expand.png | Bin 255 -> 0 bytes chrome/android/java/res/drawable-xxxhdpi/ic_expanded.png | Bin 0 -> 255 bytes .../chromium/chrome/browser/ntp/RecentTabsGroupView.java | 4 ++-- .../chrome/browser/omnibox/LocationBarLayout.java | 11 +++++++---- .../browser/preferences/privacy/PrivacyPreferences.java | 2 +- .../preferences/website/SingleCategoryPreferences.java | 4 ++-- .../chromium/chrome/browser/toolbar/CustomTabToolbar.java | 9 +++++++-- 33 files changed, 31 insertions(+), 15 deletions(-) delete mode 100644 chrome/android/java/res/drawable-hdpi/ic_collapse.png create mode 100644 chrome/android/java/res/drawable-hdpi/ic_collapsed.png delete mode 100644 chrome/android/java/res/drawable-hdpi/ic_expand.png create mode 100644 chrome/android/java/res/drawable-hdpi/ic_expanded.png delete mode 100644 chrome/android/java/res/drawable-mdpi/ic_collapse.png create mode 100644 chrome/android/java/res/drawable-mdpi/ic_collapsed.png delete mode 100644 chrome/android/java/res/drawable-mdpi/ic_expand.png create mode 100644 chrome/android/java/res/drawable-mdpi/ic_expanded.png delete mode 100644 chrome/android/java/res/drawable-xhdpi/ic_collapse.png create mode 100644 chrome/android/java/res/drawable-xhdpi/ic_collapsed.png delete mode 100644 chrome/android/java/res/drawable-xhdpi/ic_expand.png create mode 100644 chrome/android/java/res/drawable-xhdpi/ic_expanded.png delete mode 100644 chrome/android/java/res/drawable-xxhdpi/ic_collapse.png create mode 100644 chrome/android/java/res/drawable-xxhdpi/ic_collapsed.png delete mode 100644 chrome/android/java/res/drawable-xxhdpi/ic_expand.png create mode 100644 chrome/android/java/res/drawable-xxhdpi/ic_expanded.png delete mode 100644 chrome/android/java/res/drawable-xxxhdpi/ic_collapse.png create mode 100644 chrome/android/java/res/drawable-xxxhdpi/ic_collapsed.png delete mode 100644 chrome/android/java/res/drawable-xxxhdpi/ic_expand.png create mode 100644 chrome/android/java/res/drawable-xxxhdpi/ic_expanded.png diff --git a/DEPS b/DEPS index 7330ab3..8f9ac6a 100644 --- a/DEPS +++ b/DEPS @@ -424,7 +424,7 @@ deps_os = { Var('chromium_git') + '/external/android_protobuf.git' + '@' + '999188d0dc72e97f7fe08bb756958a2cf090f4e7', 'src/third_party/android_tools': - Var('chromium_git') + '/android_tools.git' + '@' + '4238a28593b7e6178c95431f91ca8c24e45fa7eb', + Var('chromium_git') + '/android_tools.git' + '@' + '54492f99c84cab0826a8e656efeb33a1b1bf5a04', 'src/third_party/apache-mime4j': Var('chromium_git') + '/chromium/deps/apache-mime4j.git' + '@' + '28cb1108bff4b6cf0a2e86ff58b3d025934ebe3a', diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java index 6e9d65a..7cf2cb4 100644 --- a/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java +++ b/android_webview/glue/java/src/com/android/webview/chromium/WebMessagePortAdapter.java @@ -4,6 +4,8 @@ package com.android.webview.chromium; +import android.annotation.TargetApi; +import android.os.Build; import android.os.Handler; import android.webkit.WebMessage; import android.webkit.WebMessagePort; @@ -14,6 +16,7 @@ import org.chromium.android_webview.AwMessagePort; * This class is used to convert a WebMessagePort to a MessagePort in chromium * world. */ +@TargetApi(Build.VERSION_CODES.M) public class WebMessagePortAdapter extends WebMessagePort { private AwMessagePort mPort; diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java index 50fc242..866262b 100644 --- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java +++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java @@ -1376,6 +1376,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate } @Override + @TargetApi(Build.VERSION_CODES.M) public void postMessageToMainFrame(final WebMessage message, final Uri targetOrigin) { if (checkNeedsPost()) { mRunQueue.addTask(new Runnable() { @@ -1544,6 +1545,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate return mAwContents.getAccessibilityNodeProvider(); } + @TargetApi(Build.VERSION_CODES.M) @Override public void onProvideVirtualStructure(final ViewStructure structure) { mFactory.startYourEngines(false); @@ -1574,6 +1576,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate // When creating the Assist structure, the left and top are relative to the parent node, and // scroll offsets are not needed. + @TargetApi(Build.VERSION_CODES.M) private void createAssistStructure(ViewStructure viewNode, AccessibilitySnapshotNode node, int parentX, int parentY) { viewNode.setClassName(node.className); diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java index 98013c9..d521003 100644 --- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java +++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java @@ -275,6 +275,7 @@ public class WebViewContentsClientAdapter extends AwContentsClient { } } + @TargetApi(Build.VERSION_CODES.M) private static class WebResourceErrorImpl extends WebResourceError { private final AwWebResourceError mError; diff --git a/build/android/pylib/constants/__init__.py b/build/android/pylib/constants/__init__.py index 6be2efb..0b61403 100644 --- a/build/android/pylib/constants/__init__.py +++ b/build/android/pylib/constants/__init__.py @@ -156,7 +156,7 @@ DEVICE_PERF_OUTPUT_DIR = ( SCREENSHOTS_DIR = os.path.join(DIR_SOURCE_ROOT, 'out_screenshots') ANDROID_SDK_VERSION = version_codes.MARSHMALLOW -ANDROID_SDK_BUILD_TOOLS_VERSION = '23.0.0' +ANDROID_SDK_BUILD_TOOLS_VERSION = '23.0.1' ANDROID_SDK_ROOT = os.path.join(DIR_SOURCE_ROOT, 'third_party', 'android_tools', 'sdk') ANDROID_SDK_TOOLS = os.path.join(ANDROID_SDK_ROOT, diff --git a/build/common.gypi b/build/common.gypi index 21fadf6..0c629f5 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1718,7 +1718,7 @@ 'android_host_arch%': '