From 1e37f3ec5e4c273e2332327058b205f635bd8ae3 Mon Sep 17 00:00:00 2001 From: "ojan@chromium.org" Date: Sat, 10 Oct 2009 00:48:21 +0000 Subject: Fix double page generation bug. Now that we use onhashchange, there's no need to call handleLocationChange manually. Review URL: http://codereview.chromium.org/267044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28643 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/tools/layout_tests/dashboards/dashboard_base.js | 2 ++ webkit/tools/layout_tests/flakiness_dashboard.html | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/webkit/tools/layout_tests/dashboards/dashboard_base.js b/webkit/tools/layout_tests/dashboards/dashboard_base.js index 134b672..57db3d1 100644 --- a/webkit/tools/layout_tests/dashboards/dashboard_base.js +++ b/webkit/tools/layout_tests/dashboards/dashboard_base.js @@ -248,6 +248,8 @@ function appendJSONScriptElements() { var hasDoneInitialPageGeneration = false; function handleResourceLoad() { + // In case we load a results.json that's not in the list of builders, + // make sure to only call handleLocationChange once from the resource loads. if (!hasDoneInitialPageGeneration) handleLocationChange(); } diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html index 8bc07dd..1e46f84 100644 --- a/webkit/tools/layout_tests/flakiness_dashboard.html +++ b/webkit/tools/layout_tests/flakiness_dashboard.html @@ -1808,7 +1808,6 @@ * pairs. */ function setState(var_args) { - var shouldRegeneratePage = true; for (var i = 0; i < arguments.length; i += 2) { var key = arguments[i]; @@ -1827,9 +1826,6 @@ // Set all the custom state for this dashboard before calling // setQueryParameter since setQueryParameter updates the location bar. setQueryParameter.apply(null, arguments); - - if (shouldRegeneratePage) - handleLocationChange(); } function hideLegend() { -- cgit v1.1