From 2e9f7de1ed39e2748f2ca9dc5f4209671d4c4712 Mon Sep 17 00:00:00 2001 From: "msw@chromium.org" Date: Fri, 31 May 2013 18:03:36 +0000 Subject: Revert 193202 "Reland: Use Views Omnibox and Textfields by defau..." These Views Textfield issues are blocking M-28, there may even be more: 1) http://crbug.com/239690 - Native Text Views: TSF stuff seems not working on metro mode. 2) http://crbug.com/242831 - Textfield Views: Caret moving is affected by font-kerning 3) http://crbug.com/242500 - Chrome crashes @ ScriptAnalyzeCluster(... So, this reverts to the native Windows Omnibox and Textfield controls on M-28. Everyone, please help verify that this eliminates related blocking issues for M-28. > Reland: Use Views Omnibox and Textfields by default on non-Aura Win. > > This CL was originally landed as: http://crrev.com/192702 > That was reverted for failures in: http://crrev.com/192766 > The test failure investigation is: http://crbug.com/227444 > The test failure was silenced by: http://crrev.com/193161 > The original CL description follows. > > Enable by default to expand dogfooding for release. > Users can --disable-views-textfield via commandline or about:flags. > > File related Chrome UI (not web content) bugs against msw. Known issues: > http://crbug.com/?q=owner=msw@chromium.org > > BUG=131660 > TEST=Textfields work well enough on non-Aura Win. > TBR=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/13771018 TBR=msw@chromium.org Review URL: https://codereview.chromium.org/15647016 git-svn-id: svn://svn.chromium.org/chrome/branches/1500/src@203437 0039d316-1c4b-4281-b951-d872f2087c98 --- ui/views/controls/textfield/textfield.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc index 2c1863e..29148e7 100644 --- a/ui/views/controls/textfield/textfield.cc +++ b/ui/views/controls/textfield/textfield.cc @@ -59,6 +59,7 @@ bool Textfield::IsViewsTextfieldEnabled() { // The new dialog style cannot host native Windows textfield controls. if (command_line->HasSwitch(switches::kEnableNewDialogStyle)) return true; + return false; #endif return true; } -- cgit v1.1