From 31d71b0e8b1b04c12e6ec654d9deca49f6303a6e Mon Sep 17 00:00:00 2001 From: "jochen@chromium.org" Date: Thu, 26 Jan 2012 03:42:31 +0000 Subject: Add an empty ShellRenderViewObserver. I plan to add IPCs so the content_shell can request a text dump of a given render view. BUG=111316 TEST=none Review URL: http://codereview.chromium.org/9113057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119188 0039d316-1c4b-4281-b951-d872f2087c98 --- content/content_shell.gypi | 2 ++ content/shell/shell_content_renderer_client.cc | 2 ++ content/shell/shell_render_view_observer.cc | 20 ++++++++++++++++++ content/shell/shell_render_view_observer.h | 29 ++++++++++++++++++++++++++ 4 files changed, 53 insertions(+) create mode 100644 content/shell/shell_render_view_observer.cc create mode 100644 content/shell/shell_render_view_observer.h diff --git a/content/content_shell.gypi b/content/content_shell.gypi index 997958e..bfed4b5 100644 --- a/content/content_shell.gypi +++ b/content/content_shell.gypi @@ -66,6 +66,8 @@ 'shell/shell_download_manager_delegate.h', 'shell/shell_main_delegate.cc', 'shell/shell_main_delegate.h', + 'shell/shell_render_view_observer.cc', + 'shell/shell_render_view_observer.h', 'shell/shell_resource_context.cc', 'shell/shell_resource_context.h', 'shell/shell_url_request_context_getter.cc', diff --git a/content/shell/shell_content_renderer_client.cc b/content/shell/shell_content_renderer_client.cc index b1f0d41..0ec2adb 100644 --- a/content/shell/shell_content_renderer_client.cc +++ b/content/shell/shell_content_renderer_client.cc @@ -4,6 +4,7 @@ #include "content/shell/shell_content_renderer_client.h" +#include "content/shell/shell_render_view_observer.h" #include "v8/include/v8.h" namespace content { @@ -15,6 +16,7 @@ void ShellContentRendererClient::RenderThreadStarted() { } void ShellContentRendererClient::RenderViewCreated(RenderView* render_view) { + new content::ShellRenderViewObserver(render_view); } void ShellContentRendererClient::SetNumberOfViews(int number_of_views) { diff --git a/content/shell/shell_render_view_observer.cc b/content/shell/shell_render_view_observer.cc new file mode 100644 index 0000000..942f601 --- /dev/null +++ b/content/shell/shell_render_view_observer.cc @@ -0,0 +1,20 @@ +// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "content/shell/shell_render_view_observer.h" + +namespace content { + +ShellRenderViewObserver::ShellRenderViewObserver(RenderView* render_view) + : RenderViewObserver(render_view) { +} + +ShellRenderViewObserver::~ShellRenderViewObserver() { +} + +bool ShellRenderViewObserver::OnMessageReceived(const IPC::Message& message) { + return false; +} + +} // namespace content diff --git a/content/shell/shell_render_view_observer.h b/content/shell/shell_render_view_observer.h new file mode 100644 index 0000000..c1d963f --- /dev/null +++ b/content/shell/shell_render_view_observer.h @@ -0,0 +1,29 @@ +// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef CONTENT_SHELL_SHELL_RENDER_VIEW_OBSERVER_H_ +#define CONTENT_SHELL_SHELL_RENDER_VIEW_OBSERVER_H_ +#pragma once + +#include "content/public/renderer/render_view_observer.h" + +namespace content { + +// This class holds the content_shell specific parts of RenderView, and has the +// same lifetime. +class ShellRenderViewObserver : public RenderViewObserver { + public: + explicit ShellRenderViewObserver(RenderView* render_view); + virtual ~ShellRenderViewObserver(); + + // RenderViewObserver implementation. + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; + + private: + DISALLOW_COPY_AND_ASSIGN(ShellRenderViewObserver); +}; + +} // namespace content + +#endif // CONTENT_SHELL_SHELL_RENDER_VIEW_OBSERVER_H_ -- cgit v1.1