From 44d28d7eeafa1f91a1a947f750e9ffd46ce49ceb Mon Sep 17 00:00:00 2001 From: philipj Date: Tue, 17 Nov 2015 11:59:27 -0800 Subject: Remove navigator.getStorageUpdates() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ak1kVjiX9T4/mo1rqcyQAQAJ navigator.yieldForStorageUpdates() will be removed from the spec: https://github.com/whatwg/html/pull/342 BUG=465255 Review URL: https://codereview.chromium.org/1439973005 Cr-Commit-Position: refs/heads/master@{#360140} --- .../test/webexposed/global-interface-listing-expected.txt | 1 - .../virtual/stable/webexposed/global-interface-listing-expected.txt | 1 - .../LayoutTests/webexposed/global-interface-listing-expected.txt | 1 - third_party/WebKit/Source/core/frame/Navigator.cpp | 5 ----- third_party/WebKit/Source/core/frame/Navigator.h | 3 --- third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl | 2 -- third_party/WebKit/Source/core/frame/UseCounter.h | 1 - 7 files changed, 14 deletions(-) diff --git a/android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt b/android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt index 35175f6..71a46cc 100644 --- a/android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt +++ b/android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt @@ -3001,7 +3001,6 @@ interface Navigator method constructor method getBattery method getGamepads - method getStorageUpdates method javaEnabled method requestMIDIAccess method requestMediaKeySystemAccess diff --git a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt index 4311a8b..689838d 100644 --- a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt +++ b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt @@ -3003,7 +3003,6 @@ interface Navigator method constructor method getBattery method getGamepads - method getStorageUpdates method javaEnabled method registerProtocolHandler method requestMIDIAccess diff --git a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt index 33088f5..2a22fe9 100644 --- a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt +++ b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt @@ -3468,7 +3468,6 @@ interface Navigator method constructor method getBattery method getGamepads - method getStorageUpdates method getVRDevices method isProtocolHandlerRegistered method javaEnabled diff --git a/third_party/WebKit/Source/core/frame/Navigator.cpp b/third_party/WebKit/Source/core/frame/Navigator.cpp index 379afd2..fcf0089 100644 --- a/third_party/WebKit/Source/core/frame/Navigator.cpp +++ b/third_party/WebKit/Source/core/frame/Navigator.cpp @@ -85,11 +85,6 @@ bool Navigator::cookieEnabled() const return cookiesEnabled(m_frame->document()); } -void Navigator::getStorageUpdates() -{ - // FIXME: Remove this method or rename to yieldForStorageUpdates. -} - Vector Navigator::languages() { Vector languages; diff --git a/third_party/WebKit/Source/core/frame/Navigator.h b/third_party/WebKit/Source/core/frame/Navigator.h index a3129e0..9351b69 100644 --- a/third_party/WebKit/Source/core/frame/Navigator.h +++ b/third_party/WebKit/Source/core/frame/Navigator.h @@ -63,9 +63,6 @@ public: String userAgent() const override; - // Relinquishes the storage lock, if one exists. - void getStorageUpdates(); - // NavigatorLanguage Vector languages() override; diff --git a/third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl b/third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl index e41b602..b408dc7 100644 --- a/third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl +++ b/third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl @@ -8,6 +8,4 @@ NoInterfaceObject, // Always used on target of 'implements' ] interface NavigatorStorageUtils { readonly attribute boolean cookieEnabled; - // TODO(philipj): This is called yieldForStorageUpdates() in the spec. - [Measure] void getStorageUpdates(); }; diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h b/third_party/WebKit/Source/core/frame/UseCounter.h index 895bda7..7197833 100644 --- a/third_party/WebKit/Source/core/frame/UseCounter.h +++ b/third_party/WebKit/Source/core/frame/UseCounter.h @@ -684,7 +684,6 @@ public: V8IDBDatabase_ObjectStoreNames_AttributeGetter = 824, V8IDBObjectStore_IndexNames_AttributeGetter = 825, V8IDBTransaction_ObjectStoreNames_AttributeGetter = 826, - V8Navigator_GetStorageUpdates_Method = 827, TextInputFired = 830, V8TextEvent_Data_AttributeGetter = 831, V8TextEvent_InitTextEvent_Method = 832, -- cgit v1.1