From 4bc89b1cb0014b007e6dd3c38da2f012191b96d0 Mon Sep 17 00:00:00 2001 From: "aa@chromium.org" Date: Thu, 9 Apr 2009 01:18:15 +0000 Subject: TBR: Skip ExtensionContentScriptInjectTest.Simple in purify. I give up. Not sure why the filters aren't working, but I suspect that even if I get them working, they will be becoming invalid all the time anyway as the codebase changes. Too bad, because the information we got from purify was useful (it found a couple memory leaks in other parts of Chrome) but I really need to get back to work. And I think that having this unit test running, even without purify, is more valuable than not. I created a bug on this and assigned it to myself. Hopefully as more people do high-level tests like this, the bugs will slowly be worked out. Otherwise, I'll eventualy get back to it. Review URL: http://codereview.chromium.org/62173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13403 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/data/purify/unit_tests.exe.gtest.txt | 3 + chrome/test/data/purify/unit_tests.exe_MLK.txt | 75 ------------------- chrome/test/data/purify/unit_tests.exe_UMR.txt | 92 ------------------------ 3 files changed, 3 insertions(+), 167 deletions(-) diff --git a/chrome/test/data/purify/unit_tests.exe.gtest.txt b/chrome/test/data/purify/unit_tests.exe.gtest.txt index 081eb0b..4f09b7d 100644 --- a/chrome/test/data/purify/unit_tests.exe.gtest.txt +++ b/chrome/test/data/purify/unit_tests.exe.gtest.txt @@ -16,3 +16,6 @@ IPCSyncChannelTest.ChattyServer # issue 8362 ExtensionViewTest.Index + +# issue 9897 +ExtensionContentScriptInjectTest.Simple diff --git a/chrome/test/data/purify/unit_tests.exe_MLK.txt b/chrome/test/data/purify/unit_tests.exe_MLK.txt index 2327072..e69de29 100644 --- a/chrome/test/data/purify/unit_tests.exe_MLK.txt +++ b/chrome/test/data/purify/unit_tests.exe_MLK.txt @@ -1,75 +0,0 @@ -c:\program files\microsoft visual studio 8\vc\include\xmemory. -Alloc Location - ... - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::SecurityState::GrantScheme(basic_string::std const&) - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::GrantRequestURL(int,GURL const&) - chrome/browser/renderer_host/render_view_host.cc RenderViewHost::NavigateToEntry(NavigationEntry const&,bool) - chrome/browser/tab_contents/web_contents.cc WebContents::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadEntry(NavigationEntry *) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadURL(GURL const&,GURL const&,UINT) - chrome/browser/browser.cc Browser::OpenURLFromTab(TabContents *,GURL const&,GURL const&,WindowOpenDisposition,UINT) - chrome/test/ui_test_utils.cc ui_test_utils::NavigateToURL(Browser *,GURL const&) - chrome/browser/extensions/extension_content_script_inject_unittest.cc ExtensionContentScriptInjectTest_Simple_Test::RunTestOnMainThread(void) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -RendererSecurityPolicy::Add(int) [unit_tests.exe] -Alloc Location - ... - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::Add(int) - chrome/browser/renderer_host/browser_render_process_host.cc BrowserRenderProcessHost::Init(void) - chrome/browser/renderer_host/render_view_host.cc RenderViewHost::CreateRenderView(void) - chrome/browser/tab_contents/web_contents.cc WebContents::CreateRenderViewForRenderManager(RenderViewHost *) - chrome/browser/tab_contents/render_view_host_manager.cc RenderViewHostManager::Navigate(NavigationEntry const&) - chrome/browser/tab_contents/web_contents.cc WebContents::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadEntry(NavigationEntry *) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadURL(GURL const&,GURL const&,UINT) - chrome/browser/browser.cc Browser::CreateTabContentsForURL(GURL const&,GURL const&,Profile *,UINT,bool,SiteInstance *)const - chrome/browser/browser.cc Browser::AddTabWithURL(GURL const&,GURL const&,UINT,bool,int,SiteInstance *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -?_Allocate@U_Node@?$_Tree_nod@V?$_Tset_traits@VFilePath@@U?$less@VFilePath@@@std@@V?$allocator@VFilePath@@@3@$0A@@std@@@std@@@std@@YAPAU_Node@?$_Tree_nod@V?$_Tset_traits@VFilePath@@U?$less@VFilePath@@@std@@V?$allocator@VFilePath@@@3@$0A@@std@@@0@IPAU120@@Z [unit_tests.exe] -Alloc Location - ... - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::SecurityState::SecurityState(void) - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::Add(int) - chrome/browser/renderer_host/browser_render_process_host.cc BrowserRenderProcessHost::Init(void) - chrome/browser/renderer_host/render_view_host.cc RenderViewHost::CreateRenderView(void) - chrome/browser/tab_contents/web_contents.cc WebContents::CreateRenderViewForRenderManager(RenderViewHost *) - chrome/browser/tab_contents/render_view_host_manager.cc RenderViewHostManager::Navigate(NavigationEntry const&) - chrome/browser/tab_contents/web_contents.cc WebContents::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadEntry(NavigationEntry *) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadURL(GURL const&,GURL const&,UINT) - chrome/browser/browser.cc Browser::CreateTabContentsForURL(GURL const&,GURL const&,Profile *,UINT,bool,SiteInstance *)const - chrome/browser/browser.cc Browser::AddTabWithURL(GURL const&,GURL const&,UINT,bool,int,SiteInstance *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -c:\program files\microsoft visual studio 8\vc\include\xmemory. -Alloc Location - ... - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::SecurityState::SecurityState(void) - chrome/browser/renderer_host/renderer_security_policy.cc RendererSecurityPolicy::Add(int) - chrome/browser/renderer_host/browser_render_process_host.cc BrowserRenderProcessHost::Init(void) - chrome/browser/renderer_host/render_view_host.cc RenderViewHost::CreateRenderView(void) - chrome/browser/tab_contents/web_contents.cc WebContents::CreateRenderViewForRenderManager(RenderViewHost *) - chrome/browser/tab_contents/render_view_host_manager.cc RenderViewHostManager::Navigate(NavigationEntry const&) - chrome/browser/tab_contents/web_contents.cc WebContents::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::NavigateToPendingEntry(bool) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadEntry(NavigationEntry *) - chrome/browser/tab_contents/navigation_controller.cc NavigationController::LoadURL(GURL const&,GURL const&,UINT) - chrome/browser/browser.cc Browser::CreateTabContentsForURL(GURL const&,GURL const&,Profile *,UINT,bool,SiteInstance *)const - chrome/browser/browser.cc Browser::AddTabWithURL(GURL const&,GURL const&,UINT,bool,int,SiteInstance *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ diff --git a/chrome/test/data/purify/unit_tests.exe_UMR.txt b/chrome/test/data/purify/unit_tests.exe_UMR.txt index 81a1a78..e69de29 100644 --- a/chrome/test/data/purify/unit_tests.exe_UMR.txt +++ b/chrome/test/data/purify/unit_tests.exe_UMR.txt @@ -1,92 +0,0 @@ -Uninitialized memory read in AutocompleteEditViewWin::SetSelectionRange(_charrange const&) -Error Location - chrome/browser/autocomplete/autocomplete_edit_view_win.h AutocompleteEditViewWin::SetSelectionRange(_charrange const&) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::EmphasizeURLComponents(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::TextChanged(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::RevertAll(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::Update(TabContents const*) - chrome/browser/views/location_bar_view.cc LocationBarView::Update(TabContents const*) - chrome/browser/views/toolbar_view.cc BrowserToolbarView::Update(TabContents *,bool) - chrome/browser/views/frame/browser_view.cc BrowserView::UpdateToolbar(TabContents *,bool) - chrome/browser/browser.cc Browser::UpdateToolbar(bool) - chrome/browser/browser.cc Browser::ScheduleUIUpdate(TabContents const*,UINT) - chrome/browser/browser.cc Browser::OpenURLFromTab(TabContents *,GURL const&,GURL const&,WindowOpenDisposition,UINT) - chrome/test/ui_test_utils.cc ui_test_utils::NavigateToURL(Browser *,GURL const&) - chrome/browser/extensions/extension_content_script_inject_unittest.cc ExtensionContentScriptInjectTest_Simple_Test::RunTestOnMainThread(void) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -Uninitialized memory read in AutocompleteEditViewWin::SetSelectionRange(_charrange const&) -Error Location - chrome/browser/autocomplete/autocomplete_edit_view_win.h AutocompleteEditViewWin::SetSelectionRange(_charrange const&) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::EmphasizeURLComponents(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::TextChanged(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::RevertAll(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::Update(TabContents const*) - chrome/browser/views/location_bar_view.cc LocationBarView::Update(TabContents const*) - chrome/browser/views/toolbar_view.cc BrowserToolbarView::Update(TabContents *,bool) - chrome/browser/views/frame/browser_view.cc BrowserView::UpdateToolbar(TabContents *,bool) - chrome/browser/browser.cc Browser::UpdateToolbar(bool) - chrome/browser/browser.cc Browser::TabSelectedAt(TabContents *,TabContents *,int,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::ChangeSelectedContentsFrom(TabContents *,int,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::InsertTabContentsAt(int,TabContents *,bool,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::AddTabContents(TabContents *,int,UINT,bool) - chrome/browser/browser.cc Browser::AddTabWithURL(GURL const&,GURL const&,UINT,bool,int,SiteInstance *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -Uninitialized memory read in AutocompleteEditViewWin::SetSelectionRange(_charrange const&) -Error Location - chrome/browser/autocomplete/autocomplete_edit_view_win.h AutocompleteEditViewWin::SetSelectionRange(_charrange const&) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::EmphasizeURLComponents(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::TextChanged(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::RevertAll(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::Update(TabContents const*) - chrome/browser/views/location_bar_view.cc LocationBarView::Update(TabContents const*) - chrome/browser/views/toolbar_view.cc BrowserToolbarView::Update(TabContents *,bool) - chrome/browser/views/frame/browser_view.cc BrowserView::UpdateToolbar(TabContents *,bool) - chrome/browser/views/frame/browser_view.cc BrowserView::TabSelectedAt(TabContents *,TabContents *,int,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::ChangeSelectedContentsFrom(TabContents *,int,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::InsertTabContentsAt(int,TabContents *,bool,bool) - chrome/browser/tabs/tab_strip_model.cc TabStripModel::AddTabContents(TabContents *,int,UINT,bool) - chrome/browser/browser.cc Browser::AddTabWithURL(GURL const&,GURL const&,UINT,bool,int,SiteInstance *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ - -Uninitialized memory read in AutocompleteEditViewWin::SetSelectionRange(_charrange const&) -Error Location - chrome/browser/autocomplete/autocomplete_edit_view_win.h AutocompleteEditViewWin::SetSelectionRange(_charrange const&) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::EmphasizeURLComponents(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::TextChanged(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::RevertAll(void) - chrome/browser/autocomplete/autocomplete_edit_view_win.cc AutocompleteEditViewWin::Update(TabContents const*) - chrome/browser/views/location_bar_view.cc LocationBarView::Update(TabContents const*) - chrome/browser/views/location_bar_view.cc LocationBarView::Init(void) - chrome/browser/views/toolbar_view.cc BrowserToolbarView::CreateCenterStack(Profile *) - chrome/browser/views/toolbar_view.cc BrowserToolbarView::Init(Profile *) - chrome/browser/views/frame/browser_view.cc BrowserView::Init(void) - chrome/browser/views/frame/browser_view.cc BrowserView::ViewHierarchyChanged(bool,View::views *,View::views *) - chrome/views/view.cc views::View::ViewHierarchyChangedImpl(bool,bool,View::views *,View::views *) - chrome/views/view.cc views::View::PropagateAddNotifications(View::views *,View::views *) - chrome/views/view.cc views::View::AddChildView(int,View::views *,bool) - chrome/views/view.cc views::View::AddChildView(int,View::views *) - chrome/views/window/non_client_view.cc views::NonClientView::ViewHierarchyChanged(bool,View::views *,View::views *) - chrome/views/view.cc views::View::ViewHierarchyChangedImpl(bool,bool,View::views *,View::views *) - chrome/views/view.cc views::View::PropagateAddNotifications(View::views *,View::views *) - chrome/views/view.cc views::View::AddChildView(int,View::views *,bool) - chrome/views/view.cc views::View::AddChildView(View::views *) - chrome/views/widget/widget_win.cc views::WidgetWin::SetContentsView(View::views *) - chrome/views/window/window_win.cc views::WindowWin::Init(HWND__ *,Rect::gfx const&) - chrome/browser/views/frame/browser_frame.cc BrowserFrame::Init(void) - chrome/browser/views/frame/browser_view.cc BrowserWindow::CreateBrowserWindow(Browser *) - chrome/browser/browser.cc Browser::CreateBrowserWindow(void) - chrome/browser/browser.cc Browser::Create(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::CreateBrowser(Profile *) - chrome/test/in_process_browser_test.cc InProcessBrowserTest::RunTestOnMainThreadLoop(void) - base/tuple.h ?DispatchToMethod@VInProcessBrowserTest@@P81@AEXXZ@@YAXPAVInProcessBrowserTest@@P80@AEXXZABUTuple0@@@Z - ^^^ -- cgit v1.1