From 4caa7300f49f5f0d30c8880bacf14a064fed51d5 Mon Sep 17 00:00:00 2001 From: "erg@chromium.org" Date: Fri, 21 May 2010 22:15:29 +0000 Subject: GTK: Prevent double free by not deleting gconf object we don't own. BUG=none TEST=Set to GTK+ theme and then try to change the system theme 4 times to 4 different themes. It shouldn't crash on the 2nd, 3rd or 4th time. Review URL: http://codereview.chromium.org/2070020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47953 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/gtk/gconf_titlebar_listener.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/chrome/browser/gtk/gconf_titlebar_listener.cc b/chrome/browser/gtk/gconf_titlebar_listener.cc index 0eeef8e..109ed996 100644 --- a/chrome/browser/gtk/gconf_titlebar_listener.cc +++ b/chrome/browser/gtk/gconf_titlebar_listener.cc @@ -86,8 +86,6 @@ void GConfTitlebarListener::OnChangeNotification(GConfClient* client, if (strcmp(gconf_entry_get_key(entry), kButtonLayoutKey) == 0) { GConfValue* gconf_value = gconf_entry_get_value(entry); ParseAndStoreValue(gconf_value); - if (gconf_value) - gconf_value_free(gconf_value); // Broadcast the new configuration to all windows: for (std::set::const_iterator it = titlebars_.begin(); -- cgit v1.1