From 57b531b405a961a7af36a54b9956c5514212ac53 Mon Sep 17 00:00:00 2001 From: "asvitkine@chromium.org" Date: Thu, 29 Nov 2012 18:17:55 +0000 Subject: Add temporary UMA histogram to understand how trials are getting disabled. Only checks the uniformity 1 percent trial to avoid noise from other trials, some of which should be legitimately expiring. This temporary histogram can be removed once we understand the issue. BUG=none TEST=no visible changes Review URL: https://chromiumcodereview.appspot.com/11412227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170223 0039d316-1c4b-4281-b951-d872f2087c98 --- base/metrics/field_trial.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc index 0088103..de95c41 100644 --- a/base/metrics/field_trial.cc +++ b/base/metrics/field_trial.cc @@ -279,8 +279,12 @@ FieldTrial* FieldTrialList::FactoryGetFieldTrial( FieldTrial* field_trial = new FieldTrial(name, total_probability, default_group_name); - if (GetBuildTime() > CreateTimeFromParams(year, month, day_of_month)) + if (GetBuildTime() > CreateTimeFromParams(year, month, day_of_month)) { + // TODO(asvitkine): Temporary histogram. Remove this once it is not needed. + if (name == "UMA-Uniformity-Trial-1-Percent") + UMA_HISTOGRAM_BOOLEAN("Variations.UniformityTrialExpired", true); field_trial->Disable(); + } FieldTrialList::Register(field_trial); return field_trial; } -- cgit v1.1