From 64ec639d3feceeb6735831ed8eff34ebb07a8d1d Mon Sep 17 00:00:00 2001 From: "estade@chromium.org" Date: Wed, 22 Jul 2009 01:34:25 +0000 Subject: Don't create new tabs for middle clicks on bookmark items when the user releases off the item. BUG=14518 TEST=see bug Review URL: http://codereview.chromium.org/155902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21254 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/gtk/bookmark_bar_gtk.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/chrome/browser/gtk/bookmark_bar_gtk.cc b/chrome/browser/gtk/bookmark_bar_gtk.cc index 4c94148..c8f9cc6 100644 --- a/chrome/browser/gtk/bookmark_bar_gtk.cc +++ b/chrome/browser/gtk/bookmark_bar_gtk.cc @@ -558,6 +558,12 @@ gboolean BookmarkBarGtk::OnButtonReleased(GtkWidget* sender, return FALSE; } + // Don't take any action if the user releases outside the button. + if (event->x < 0 || event->y < 0 || event->x >= sender->allocation.width || + event->y >= sender->allocation.height) { + return FALSE; + } + const BookmarkNode* node = bar->GetNodeForToolButton(sender); DCHECK(node); DCHECK(bar->page_navigator_); -- cgit v1.1