From 68342e72e530f4b38957cb1b62f67602f867f1c8 Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Wed, 17 Dec 2008 22:25:13 +0000 Subject: Rebaseling differences in error messages. Review URL: http://codereview.chromium.org/14811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7173 0039d316-1c4b-4281-b951-d872f2087c98 --- .../LayoutTests/fast/js/large-expressions-expected.txt | 13 +++++++++++++ .../fast/js/modify-non-references-expected.txt | 15 +++++++++++++++ .../LayoutTests/fast/js/large-expressions-expected.txt | 4 ++-- .../fast/js/modify-non-references-expected.txt | 12 ++++++------ webkit/tools/layout_tests/test_lists/tests_fixable.txt | 3 +-- 5 files changed, 37 insertions(+), 10 deletions(-) create mode 100644 webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/large-expressions-expected.txt create mode 100644 webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/modify-non-references-expected.txt diff --git a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/large-expressions-expected.txt b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/large-expressions-expected.txt new file mode 100644 index 0000000..ab6a2e5 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/large-expressions-expected.txt @@ -0,0 +1,13 @@ +This test checks behavior with expressions that create deep parse trees. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS eval(repeatedExpression("letterA", "+", 100)) is repeatedString("a", 100) +PASS eval(repeatedExpression("letterA", "+", 1000)) is repeatedString("a", 1000) +FAIL eval(repeatedExpression("letterA", "+", 10000)) should throw SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. +FAIL eval(repeatedExpression("letterA", "+", 100000)) should throw SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. +PASS successfullyParsed is true + +TEST COMPLETE + diff --git a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/modify-non-references-expected.txt b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/modify-non-references-expected.txt new file mode 100644 index 0000000..204f376 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/modify-non-references-expected.txt @@ -0,0 +1,15 @@ +PASS function f() { g()++; } f.toString() is 'function f() { g()++; }' +PASS function f() { g()--; } f.toString() is 'function f() { g()--; }' +PASS function f() { ++g(); } f.toString() is 'function f() { ++g(); }' +PASS function f() { --g(); } f.toString() is 'function f() { --g(); }' +PASS function f() { g() = 1; } f.toString() is 'function f() { g() = 1; }' +PASS function f() { g() += 1; } f.toString() is 'function f() { g() += 1; }' +FAIL g()++ should throw ReferenceError: Postfix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. +FAIL g()-- should throw ReferenceError: Postfix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. +FAIL ++g() should throw ReferenceError: Prefix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. +FAIL --g() should throw ReferenceError: Prefix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. +FAIL g() = 1 should throw ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. +FAIL g() += 1 should throw ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. +PASS successfullyParsed is true + +TEST COMPLETE diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/large-expressions-expected.txt b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/large-expressions-expected.txt index c928207..ab6a2e5 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/large-expressions-expected.txt +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/large-expressions-expected.txt @@ -5,8 +5,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE PASS eval(repeatedExpression("letterA", "+", 100)) is repeatedString("a", 100) PASS eval(repeatedExpression("letterA", "+", 1000)) is repeatedString("a", 1000) -FAIL eval(repeatedExpression("letterA", "+", 10000)) should throw exception SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. -FAIL eval(repeatedExpression("letterA", "+", 100000)) should throw exception SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. +FAIL eval(repeatedExpression("letterA", "+", 10000)) should throw SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. +FAIL eval(repeatedExpression("letterA", "+", 100000)) should throw SyntaxError: Expression too deep. Threw exception RangeError: Maximum call stack size exceeded. PASS successfullyParsed is true TEST COMPLETE diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/modify-non-references-expected.txt b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/modify-non-references-expected.txt index a213edf..204f376 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/modify-non-references-expected.txt +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/modify-non-references-expected.txt @@ -4,12 +4,12 @@ PASS function f() { ++g(); } f.toString() is 'function f() { ++g(); }' PASS function f() { --g(); } f.toString() is 'function f() { --g(); }' PASS function f() { g() = 1; } f.toString() is 'function f() { g() = 1; }' PASS function f() { g() += 1; } f.toString() is 'function f() { g() += 1; }' -FAIL g()++ should throw exception ReferenceError: Postfix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. -FAIL g()-- should throw exception ReferenceError: Postfix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. -FAIL ++g() should throw exception ReferenceError: Prefix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. -FAIL --g() should throw exception ReferenceError: Prefix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. -FAIL g() = 1 should throw exception ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. -FAIL g() += 1 should throw exception ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. +FAIL g()++ should throw ReferenceError: Postfix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. +FAIL g()-- should throw ReferenceError: Postfix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in postfix operation. +FAIL ++g() should throw ReferenceError: Prefix ++ operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. +FAIL --g() should throw ReferenceError: Prefix -- operator applied to value that is not a reference.. Threw exception ReferenceError: Invalid left-hand side expression in prefix operation. +FAIL g() = 1 should throw ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. +FAIL g() += 1 should throw ReferenceError: Left side of assignment is not a reference.. Threw exception ReferenceError: Invalid left-hand side in assignment. PASS successfullyParsed is true TEST COMPLETE diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt index c88ad44..809fd38 100644 --- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt +++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt @@ -1780,8 +1780,7 @@ LayoutTests/wml/go-task-get-method-external-deck-with-href.html = FAIL // WebKit Merge 39100:39141 regressions: LayoutTests/fast/css/font-face-descriptor-multiple-values-parsing.html = FAIL -LayoutTests/fast/js/large-expressions.html = FAIL -LayoutTests/fast/js/modify-non-references.html = FAIL +// We don't appear to be throwing an exception on super long regexps. LayoutTests/fast/js/regexp-overflow.html = FAIL // Windows pixeltest failure: alpha=0.5 red does not come out blended. -- cgit v1.1