From 6e8e6bdd05fbd91a25157c5f6c83e54d8e6369b3 Mon Sep 17 00:00:00 2001 From: "mpcomplete@chromium.org" Date: Mon, 4 Apr 2011 19:04:16 +0000 Subject: Fix WebRequestEvents test flakiness. Ignore type="other" webrequest events (like favicon fetches). BUG=78139 TEST=automated Review URL: http://codereview.chromium.org/6759079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80348 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/data/extensions/api_test/webrequest/events/test.html | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/chrome/test/data/extensions/api_test/webrequest/events/test.html b/chrome/test/data/extensions/api_test/webrequest/events/test.html index dadce3f..72688d7 100644 --- a/chrome/test/data/extensions/api_test/webrequest/events/test.html +++ b/chrome/test/data/extensions/api_test/webrequest/events/test.html @@ -40,9 +40,10 @@ function checkExpectations() { } function captureEvent(name, details) { - // Ignore system-level requests like safebrowsing updates since they are - // unpredictable. - if (details.tabId == -1) + // Ignore system-level requests like safebrowsing updates and favicon fetches + // since they are unpredictable. + if (details.tabId == -1 || details.type == "other" || + details.url.match(/\/favicon.ico$/)) return; delete details.requestId; -- cgit v1.1