From 7e894073084371a6c8c31827a0f0c9cdb37d4ed6 Mon Sep 17 00:00:00 2001 From: horo Date: Mon, 23 Mar 2015 16:45:16 -0700 Subject: Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1027743004/) Reason for revert: Failing on Android One perf bot which doesn't have "screenrecord". http://crbug.com/469841 Original issue's description: > Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/959793002/) > > Reason for revert: > avconv is available on Nexus 10. > https://code.google.com/p/chromium/issues/detail?id=433943#c37 > > Original issue's description: > > Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/954663002/) > > > > Reason for revert: > > Failing on Nexus 10. > > > > Original issue's description: > > > Enable ServiceWorkerPerfTest (service_worker.service_worker) > > > > > > I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. > > > > > > BUG=433943 > > > TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker > > > > > > Committed: https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186 > > > Cr-Commit-Position: refs/heads/master@{#317807} > > > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,horo@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=433943 > > > > Committed: https://crrev.com/6aa34fa4e41d77e92d86f3f0c5f80fab9bdda749 > > Cr-Commit-Position: refs/heads/master@{#318066} > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=433943 > > Committed: https://crrev.com/e3f37ac21edb64dcf805007a382aff9405642948 > Cr-Commit-Position: refs/heads/master@{#321759} TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433943 Review URL: https://codereview.chromium.org/1000273003 Cr-Commit-Position: refs/heads/master@{#321897} --- tools/perf/benchmarks/service_worker.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/benchmarks/service_worker.py b/tools/perf/benchmarks/service_worker.py index 29cbecb..427198c 100644 --- a/tools/perf/benchmarks/service_worker.py +++ b/tools/perf/benchmarks/service_worker.py @@ -172,6 +172,8 @@ class _ServiceWorkerMicroBenchmarkMeasurement(page_test.PageTest): browser_process, 'IOThread', filter_text , results) +# TODO(simonhatch): Temporarily disabling (http://crbug.com/433943) +@benchmark.Disabled class ServiceWorkerPerfTest(benchmark.Benchmark): """Performance test on public applications using ServiceWorker""" test = _ServiceWorkerMeasurement -- cgit v1.1