From 81c05e116617d13b4b708792f0d2eb21ede1c829 Mon Sep 17 00:00:00 2001 From: "raphael.kubo.da.costa" Date: Tue, 24 Feb 2015 04:13:04 -0800 Subject: FileSystemUsageCache: Remove bogus unsigned integer comparisons. Stop performing an invalid comparison (twice in a row): |dirty| is an unsigned integer, so there is no point in comparing it to < 0. Review URL: https://codereview.chromium.org/944873002 Cr-Commit-Position: refs/heads/master@{#317785} --- storage/browser/fileapi/file_system_usage_cache.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/storage/browser/fileapi/file_system_usage_cache.cc b/storage/browser/fileapi/file_system_usage_cache.cc index 880985b..c6baa7a 100644 --- a/storage/browser/fileapi/file_system_usage_cache.cc +++ b/storage/browser/fileapi/file_system_usage_cache.cc @@ -95,10 +95,7 @@ bool FileSystemUsageCache::DecrementDirty( bool is_valid = true; uint32 dirty = 0; int64 usage = 0; - if (!Read(usage_file_path, &is_valid, &dirty, &usage) || dirty <= 0) - return false; - - if (dirty <= 0) + if (!Read(usage_file_path, &is_valid, &dirty, &usage) || dirty == 0) return false; return Write(usage_file_path, is_valid, dirty - 1, usage); -- cgit v1.1