From 9284f2966beccfd017f3f85809375508412fe0e2 Mon Sep 17 00:00:00 2001
From: "tony@chromium.org"
<tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon, 21 Sep 2009 17:04:02 +0000
Subject: Shift+PageUp and Shift+PageDown should not scroll the web page.
Alt and Ctrl already don't scroll. Win+PageUp/PageDown does scroll.
This matches Firefox. It doesn't match IE; IE lets you scroll
using ctrl, shift or win.
I'm doing this so the standard GTK+ key binding for
ctrl+shift+page{up/down} can be used on linux to move tabs left/right
(otherwise, the page scrolls and eats the key before we get to it).
BUG=21594
Review URL: http://codereview.chromium.org/214026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26692 0039d316-1c4b-4281-b951-d872f2087c98
---
webkit/glue/webview_impl.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc
index 278b115..89f7e2c 100644
--- a/webkit/glue/webview_impl.cc
+++ b/webkit/glue/webview_impl.cc
@@ -848,7 +848,7 @@ bool WebViewImpl::KeyEventDefault(const WebKeyboardEvent& event) {
return false;
}
}
- if (!event.isSystemKey) {
+ if (!event.isSystemKey && !(event.modifiers & WebInputEvent::ShiftKey)) {
return ScrollViewWithKeyboard(event.windowsKeyCode, event.modifiers);
}
break;
--
cgit v1.1