From 9db08db3002dd85167577fabeee0cbe9d8361bed Mon Sep 17 00:00:00 2001 From: "eroman@chromium.org" Date: Fri, 20 Jan 2012 21:49:14 +0000 Subject: Revert 118074 - Disable FPO throughout client_socket_pool_base.cc. This will help track down the origin of a use-after-free bug. BUG=109876 Review URL: http://codereview.chromium.org/9240036 TBR=eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/9271013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118510 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket/client_socket_pool_base.cc | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc index 6b2a75d..e67b4e7 100644 --- a/net/socket/client_socket_pool_base.cc +++ b/net/socket/client_socket_pool_base.cc @@ -22,14 +22,6 @@ using base::TimeDelta; -// Disable FPO for all the functions in this file. This is to help track down -// http://crbug.com/109876. With FPO enabled, the stacktrace capture is -// unreliable, and we can't see the specific deletion point of the Group. -// TODO(eroman): Remove it when done investigating. -#if defined(COMPILER_MSVC) -#pragma optimize("y", off) -#endif - namespace { // Indicate whether we should enable idle socket cleanup timer. When timer is @@ -1263,8 +1255,3 @@ void ClientSocketPoolBaseHelper::Group::RemoveAllJobs() { } // namespace internal } // namespace net - -// Restore default optimization settings. -#if defined(COMPILER_MSVC) -#pragma optimize("", on) -#endif -- cgit v1.1