From b4015eaaa7cad8c56fd29d5fc5e3b7e1e88cbbec Mon Sep 17 00:00:00 2001
From: "wtc@chromium.org"
 <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri, 26 Jun 2009 18:55:57 +0000
Subject: Add DCHECKs to the states that should be entered only when the
 previous state succeeded.

R=ibrar,phajdan.jr
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/149013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19394 0039d316-1c4b-4281-b951-d872f2087c98
---
 net/ftp/ftp_network_transaction.cc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/net/ftp/ftp_network_transaction.cc b/net/ftp/ftp_network_transaction.cc
index 098cbd0..248b716 100644
--- a/net/ftp/ftp_network_transaction.cc
+++ b/net/ftp/ftp_network_transaction.cc
@@ -239,6 +239,7 @@ int FtpNetworkTransaction::DoLoop(int result) {
         rv = DoCtrlConnectComplete(rv);
         break;
       case STATE_CTRL_READ:
+        DCHECK(rv == OK);
         rv = DoCtrlRead();
         break;
       case STATE_CTRL_READ_COMPLETE:
@@ -281,19 +282,24 @@ int FtpNetworkTransaction::DoLoop(int result) {
         rv = DoCtrlWriteSIZE();
         break;
       case STATE_CTRL_WRITE_CWD:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteCWD();
         break;
       case STATE_CTRL_WRITE_LIST:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteLIST();
         break;
       case STATE_CTRL_WRITE_MDTM:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteMDTM();
         break;
       case STATE_CTRL_WRITE_QUIT:
+        DCHECK(rv == OK);
         rv = DoCtrlWriteQUIT();
         break;
 
       case STATE_DATA_RESOLVE_HOST:
+        DCHECK(rv == OK);
         rv = DoDataResolveHost();
         break;
       case STATE_DATA_RESOLVE_HOST_COMPLETE:
@@ -307,6 +313,7 @@ int FtpNetworkTransaction::DoLoop(int result) {
         rv = DoDataConnectComplete(rv);
         break;
       case STATE_DATA_READ:
+        DCHECK(rv == OK);
         rv = DoDataRead();
         break;
       case STATE_DATA_READ_COMPLETE:
-- 
cgit v1.1