From ba499d9817d195225d7a4f00596e164f5e2b1ee6 Mon Sep 17 00:00:00 2001 From: "senorblanco@chromium.org" Date: Fri, 15 May 2009 09:21:22 +0000 Subject: This is some more cleanup and triage after the skia merge. All layout tests that were minor pixel changes (or major ones that bring us closer to webkit mac results) have been rebaselined. The rest have been sorted by probable cause and assigned bugs. glyph-orientation-rounding-test.xhtml is from http://crbug.com/11502, whose crash I couldn't reproduce (seems to be also passing on the buildbots). Review URL: http://codereview.chromium.org/113416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16151 0039d316-1c4b-4281-b951-d872f2087c98 --- .../fast/borders/border-image-01-expected.checksum | 1 + .../fast/borders/border-image-01-expected.png | Bin 0 -> 17231 bytes ...border-image-omit-right-slice-expected.checksum | 1 + .../border-image-omit-right-slice-expected.png | Bin 0 -> 18383 bytes .../circular-marker-reference-3-expected.txt | 8 ++--- .../editing/inserting/4960120-1-expected.checksum | 2 +- .../editing/inserting/4960120-1-expected.png | Bin 3963 -> 3959 bytes .../forms/textarea-scrollbar-expected.checksum | 2 +- .../fast/forms/textarea-scrollbar-expected.png | Bin 4316 -> 4317 bytes .../forms/textarea-scrolled-type-expected.checksum | 2 +- .../fast/forms/textarea-scrolled-type-expected.png | Bin 4712 -> 4710 bytes .../layers/self-painting-outline-expected.checksum | 2 +- .../fast/layers/self-painting-outline-expected.png | Bin 3979 -> 3947 bytes .../overflow/overflow-focus-ring-expected.checksum | 2 +- .../fast/overflow/overflow-focus-ring-expected.png | Bin 4650 -> 4648 bytes .../fast/repaint/layer-outline-expected.checksum | 2 +- .../fast/repaint/layer-outline-expected.png | Bin 5620 -> 5593 bytes .../layer-outline-horizontal-expected.checksum | 2 +- .../repaint/layer-outline-horizontal-expected.png | Bin 5620 -> 5593 bytes webkit/tools/layout_tests/test_expectations.txt | 34 +++++++-------------- 20 files changed, 24 insertions(+), 34 deletions(-) create mode 100644 webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.checksum create mode 100644 webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.png create mode 100644 webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.checksum create mode 100644 webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.png diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.checksum b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.checksum new file mode 100644 index 0000000..eca4a18 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.checksum @@ -0,0 +1 @@ +b789002d250a0dde8046da9e9ac5d461 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.png b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.png new file mode 100644 index 0000000..79f610d Binary files /dev/null and b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-01-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.checksum b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.checksum new file mode 100644 index 0000000..c79ae44 --- /dev/null +++ b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.checksum @@ -0,0 +1 @@ +4811908e5ed875bb7241730ad8c3486e \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.png b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.png new file mode 100644 index 0000000..49dc381 Binary files /dev/null and b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-omit-right-slice-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/circular-marker-reference-3-expected.txt b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/circular-marker-reference-3-expected.txt index 51d8478..af91366 100644 --- a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/circular-marker-reference-3-expected.txt +++ b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/custom/circular-marker-reference-3-expected.txt @@ -2,8 +2,8 @@ KCanvasResource {id="mark" [type=MARKER] [angle=0.00] [ref x=4.00 y=4.00]} layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x600 - RenderSVGRoot {svg} at (235,345) size 330x30 [start marker=mark] [middle marker=mark] [end marker=mark] + RenderSVGRoot {svg} at (235,345) size 14985x8985 [start marker=mark] [middle marker=mark] [end marker=mark] RenderSVGHiddenContainer {defs} at (0,0) size 0x0 [start marker=mark] [middle marker=mark] [end marker=mark] - RenderSVGViewportContainer {marker} at (-2.06,-0.94) size 4.12x0.38 [start marker=mark] [middle marker=mark] [end marker=mark] - RenderPath {path} at (-2.06,-0.94) size 4.12x0.38 [stroke={[type=SOLID] [color=#000000] [line cap=ROUND]}] [fill={[type=SOLID] [color=#000000]}] [start marker=mark] [middle marker=mark] [end marker=mark] [data="M-5.00,-2.00 L0.00,-2.00 L5.00,-2.00"] - RenderPath {path} at (235,345) size 330x30 [stroke={[type=SOLID] [color=#000000] [line cap=ROUND]}] [fill={[type=SOLID] [color=#000000]}] [start marker=mark] [middle marker=mark] [end marker=mark] [data="M-5.00,2.00 L0.00,2.00 L5.00,2.00"] + RenderSVGViewportContainer {marker} at (-2.06,-0.94) size 185.44x113.81 [start marker=mark] [middle marker=mark] [end marker=mark] + RenderPath {path} at (-2.06,-0.94) size 185.44x113.81 [stroke={[type=SOLID] [color=#000000] [line cap=ROUND]}] [fill={[type=SOLID] [color=#000000]}] [start marker=mark] [middle marker=mark] [end marker=mark] [data="M-5.00,-2.00 L0.00,-2.00 L5.00,-2.00"] + RenderPath {path} at (235,345) size 14985x8985 [stroke={[type=SOLID] [color=#000000] [line cap=ROUND]}] [fill={[type=SOLID] [color=#000000]}] [start marker=mark] [middle marker=mark] [end marker=mark] [data="M-5.00,2.00 L0.00,2.00 L5.00,2.00"] diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.checksum index ff97e00..ee00011 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.checksum @@ -1 +1 @@ -bc30e20a43060be9ea3a287410c5a280 \ No newline at end of file +16ba500b5616d5e2a453dabb7c22f1ac \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.png index 94d3df0..6b7958b 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/4960120-1-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.checksum index ee0ec97..6a17d13 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.checksum @@ -1 +1 @@ -588dec46fd0f5be936c0b644f43421aa \ No newline at end of file +bcca7a1ce619e4fc3fa0f7e7970812f0 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.png index 80a34890..8c0fb21 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrollbar-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.checksum index 433e9ca..ffb42cc 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.checksum @@ -1 +1 @@ -f06de0532c7fa8c7d16451f5eb65f18a \ No newline at end of file +0d4c69ae370cebe680ef46550684cbed \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.png index 5242755..8887334 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/textarea-scrolled-type-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.checksum index 6ccfe66..6201ffc 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.checksum @@ -1 +1 @@ -cbdf04fad73afde9177bea4c79417d68 \ No newline at end of file +8ee1716a20c5372bbc52dfc67c593a68 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.png index f9689a2..f8802d6 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/layers/self-painting-outline-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum index 5492039..f4f01fe 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.checksum @@ -1 +1 @@ -d3a195006a2017f67ad1c0e3996e1d28 \ No newline at end of file +013c053ef8ddc7304ec95cbd25083c84 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.png index b609a53..87f5719 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-focus-ring-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.checksum index f451a12..b389271 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.checksum @@ -1 +1 @@ -4002c26094e6e2b405bd8509cb388565 \ No newline at end of file +a33391e15753b1f825ea14a5cd843281 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.png index 5aa24ba..46ab6a2 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-expected.png differ diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.checksum b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.checksum index f451a12..b389271 100644 --- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.checksum +++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.checksum @@ -1 +1 @@ -4002c26094e6e2b405bd8509cb388565 \ No newline at end of file +a33391e15753b1f825ea14a5cd843281 \ No newline at end of file diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.png b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.png index 5aa24ba..46ab6a2 100644 Binary files a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.png and b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-outline-horizontal-expected.png differ diff --git a/webkit/tools/layout_tests/test_expectations.txt b/webkit/tools/layout_tests/test_expectations.txt index 2052d0a..5b824e3 100644 --- a/webkit/tools/layout_tests/test_expectations.txt +++ b/webkit/tools/layout_tests/test_expectations.txt @@ -2358,9 +2358,6 @@ BUG11483 LINUX : LayoutTests/fast/forms/input-text-double-click.html = FAIL BUG11483 LINUX : LayoutTests/editing/spelling/spellcheck-attribute.html = FAIL BUG11483 LINUX : LayoutTests/svg/text/foreignObject-repaint.xml = FAIL -// Other regresssions from WebKit Merge 43114:43242 -BUG11502 WIN : LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml = CRASH PASS - // Regressions from WebKit merge 43242:43321. These just need to re-baselining: BUG_DARIN LINUX : LayoutTests/editing/pasteboard/5027857.html = FAIL BUG_DARIN LINUX : LayoutTests/editing/pasteboard/paste-pre-002.html = FAIL @@ -2638,26 +2635,17 @@ BUG11613 WIN : LayoutTests/http/tests/navigation/anchor-frames.html = FAIL BUG11613 WIN : LayoutTests/http/tests/navigation/javascriptlink-frames.html = FAIL BUG11613 WIN : LayoutTests/http/tests/navigation/relativeanchor-frames.html = FAIL -// These tests were broken by the latest skia drop (masks and opacity). -BUG_SENORBLANCO WIN LINUX : LayoutTests/fast/reflections/reflection-masks-opacity.html = FAIL -BUG_SENORBLANCO WIN LINUX : LayoutTests/fast/reflections/reflection-masks.html = FAIL -BUG_SENORBLANCO WIN LINUX : LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/svg/custom/circular-marker-reference-3.svg = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/svg/custom/js-late-marker-creation.svg = FAIL -BUG_SENORBLANCO WIN : LayoutTests/svg/custom/gradient-stop-corner-cases.svg = FAIL -BUG_SENORBLANCO WIN : LayoutTests/svg/custom/grayscale-gradient-mask.svg = FAIL -BUG_SENORBLANCO WIN : LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg = FAIL -BUG_SENORBLANCO WIN : LayoutTests/editing/inserting/4960120-1.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/forms/textarea-scrollbar.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/forms/textarea-scrolled-type.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/layers/self-painting-outline.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/overflow/overflow-focus-ring.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/repaint/layer-outline-horizontal.html = FAIL -BUG_SENORBLANCO WIN : LayoutTests/fast/repaint/layer-outline.html = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/fast/borders/border-image-01.html = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/fast/borders/border-image-omit-right-slice.html = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/transitions/transition-end-event-multiple-03.html = FAIL -BUG_SENORBLANCO LINUX : LayoutTests/transitions/transition-end-event-set-none.html = FAIL +// These tests were broken by skia r171: +// These ones seem to be mask/opacity-related: +BUG12002 WIN LINUX : LayoutTests/fast/reflections/reflection-masks-opacity.html = FAIL +BUG12002 WIN LINUX : LayoutTests/fast/reflections/reflection-masks.html = FAIL +BUG12002 WIN LINUX : LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg = FAIL +BUG12002 WIN : LayoutTests/svg/custom/gradient-stop-corner-cases.svg = FAIL +BUG12002 WIN : LayoutTests/svg/custom/grayscale-gradient-mask.svg = FAIL +// This one seems to have patterned stroke issues: +BUG12003 WIN : LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg = FAIL +// This one is flaky on Linux +BUG12004 LINUX : LayoutTests/svg/custom/js-late-marker-creation.svg = FAIL PASS // This needs to be rebaselined. See http://trac.webkit.org/changeset/43378 BUG11669 LINUX : LayoutTests/fast/layers/remove-only-this-layer-update.html = FAIL -- cgit v1.1