From c02ab3838f371010565d7cac859dca493160a85a Mon Sep 17 00:00:00 2001 From: "piman@chromium.org" Date: Fri, 14 Feb 2014 23:45:22 +0000 Subject: Remove Tabpose feature on mac, and supporting infrastructure (PaintAtSize) Tabpose has been behind a flag for 3 years, and UMA shows usage is very low. It is the unique user of the RenderWidgetSnapshotTaker, and the only user of RWH::PaintAtSize, which we want to remove. XIB changes: * Remove Tabpose menu entry "Show Tab Overview..." BUG=251960, 223336 R=cevans@chromium.org, jamesr@chromium.org, sky@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/154083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251439 0039d316-1c4b-4281-b951-d872f2087c98 --- build/ios/grit_whitelist.txt | 2 - chrome/app/chrome_command_ids.h | 1 - chrome/app/generated_resources.grd | 9 - chrome/app/nibs/MainMenu.xib | 41 - .../default_100_percent/common/tabpose_close.png | Bin 603 -> 0 bytes .../default_100_percent/mac/tabpose_close.png | Bin 652 -> 0 bytes .../default_200_percent/mac/tabpose_close.png | Bin 1221 -> 0 bytes chrome/app/theme/theme_resources.grd | 1 - chrome/browser/about_flags.cc | 12 - chrome/browser/app_controller_mac.h | 3 - chrome/browser/app_controller_mac.mm | 5 - chrome/browser/browser_process.h | 3 - chrome/browser/browser_process_impl.cc | 6 - chrome/browser/browser_process_impl.h | 5 - .../thumbnails/render_widget_snapshot_taker.cc | 195 --- .../thumbnails/render_widget_snapshot_taker.h | 89 -- .../render_widget_snapshot_taker_unittest.cc | 86 - chrome/browser/thumbnails/thumbnail_tab_helper.cc | 4 - chrome/browser/ui/browser_command_controller.cc | 5 - chrome/browser/ui/browser_commands.cc | 14 - chrome/browser/ui/browser_commands.h | 1 - chrome/browser/ui/browser_window.h | 3 - chrome/browser/ui/cocoa/accelerators_cocoa.mm | 1 - chrome/browser/ui/cocoa/browser_window_cocoa.h | 1 - chrome/browser/ui/cocoa/browser_window_cocoa.mm | 4 - .../browser/ui/cocoa/browser_window_controller.h | 3 - .../browser/ui/cocoa/browser_window_controller.mm | 43 - chrome/browser/ui/cocoa/tabpose_window.h | 103 -- chrome/browser/ui/cocoa/tabpose_window.mm | 1664 -------------------- chrome/browser/ui/cocoa/tabpose_window_unittest.mm | 126 -- chrome/chrome_browser.gypi | 2 - chrome/chrome_browser_ui.gypi | 2 - chrome/chrome_tests_unit.gypi | 2 - chrome/common/chrome_switches.cc | 3 - chrome/common/chrome_switches.h | 1 - chrome/test/base/test_browser_window.h | 1 - chrome/test/base/testing_browser_process.cc | 14 - chrome/test/base/testing_browser_process.h | 2 - chrome/test/base/ui_test_utils.cc | 1 - chrome/test/base/ui_test_utils.h | 6 - .../renderer_host/render_widget_host_impl.cc | 20 - .../renderer_host/render_widget_host_impl.h | 5 - .../renderer_host/render_widget_host_unittest.cc | 62 - content/common/swapped_out_messages.cc | 1 - content/common/view_messages.h | 21 - content/public/browser/notification_types.h | 5 - content/public/browser/render_widget_host.h | 14 - content/public/test/render_widget_test.cc | 116 -- content/public/test/render_widget_test.h | 24 - content/renderer/render_widget.cc | 81 - content/renderer/render_widget.h | 4 - content/renderer/render_widget_browsertest.cc | 4 - ui/surface/transport_dib.h | 21 - 53 files changed, 2842 deletions(-) delete mode 100644 chrome/app/theme/default_100_percent/common/tabpose_close.png delete mode 100644 chrome/app/theme/default_100_percent/mac/tabpose_close.png delete mode 100644 chrome/app/theme/default_200_percent/mac/tabpose_close.png delete mode 100644 chrome/browser/thumbnails/render_widget_snapshot_taker.cc delete mode 100644 chrome/browser/thumbnails/render_widget_snapshot_taker.h delete mode 100644 chrome/browser/thumbnails/render_widget_snapshot_taker_unittest.cc delete mode 100644 chrome/browser/ui/cocoa/tabpose_window.h delete mode 100644 chrome/browser/ui/cocoa/tabpose_window.mm delete mode 100644 chrome/browser/ui/cocoa/tabpose_window_unittest.mm diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt index 9ec8fe2..0f0949f 100644 --- a/build/ios/grit_whitelist.txt +++ b/build/ios/grit_whitelist.txt @@ -553,8 +553,6 @@ IDS_FLAGS_SPELLCHECK_AUTOCORRECT_DESCRIPTION IDS_FLAGS_STACKED_TAB_STRIP_DESCRIPTION IDS_FLAGS_STACKED_TAB_STRIP_NAME IDS_FLAGS_TABLE_TITLE -IDS_FLAGS_TABPOSE_DESCRIPTION -IDS_FLAGS_TABPOSE_NAME IDS_FLAGS_TAB_GROUPS_CONTEXT_MENU_DESCRIPTION IDS_FLAGS_TAB_GROUPS_CONTEXT_MENU_NAME IDS_FLAGS_THREADED_COMPOSITING_MODE_DESCRIPTION diff --git a/chrome/app/chrome_command_ids.h b/chrome/app/chrome_command_ids.h index 1c7a5921e..157c2e8 100644 --- a/chrome/app/chrome_command_ids.h +++ b/chrome/app/chrome_command_ids.h @@ -61,7 +61,6 @@ #define IDC_MOVE_TAB_NEXT 34032 #define IDC_MOVE_TAB_PREVIOUS 34033 #define IDC_SEARCH 34035 -#define IDC_TABPOSE 34036 #define IDC_DEBUG_FRAME_TOGGLE 34038 #define IDC_PRESENTATION_MODE 34039 #define IDC_METRO_SNAP_ENABLE 34040 diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd index 2f772bb..2d22ce0 100644 --- a/chrome/app/generated_resources.grd +++ b/chrome/app/generated_resources.grd @@ -5549,12 +5549,6 @@ Keep your key file in a safe place. You will need it to create new versions of y Enable - - Tab Overview - - - Swipe down with three fingers on your trackpad while holding the option key to see an overview of all your tabs. Click on a thumbnail to select it. Works great in fullscreen mode. - Stacked Tabs @@ -13250,9 +13244,6 @@ Some features may be unavailable. Please check that the profile exists and you Select Previous Tab - - Show Tab Overview... - Downloads diff --git a/chrome/app/nibs/MainMenu.xib b/chrome/app/nibs/MainMenu.xib index 9609e95..072920c 100644 --- a/chrome/app/nibs/MainMenu.xib +++ b/chrome/app/nibs/MainMenu.xib @@ -1128,16 +1128,6 @@ 34017 - - - ^IDS_SHOW_TABPOSE_MAC - t - 1310720 - 2147483647 - - - 34036 - YES @@ -1781,14 +1771,6 @@ commandDispatch: - - - 684 - - - - commandDispatch: - 693 @@ -1874,14 +1856,6 @@ 667 - - tabposeMenuItem_ - - - - 685 - - toggleConfirmToQuit: @@ -2305,7 +2279,6 @@ - @@ -2732,11 +2705,6 @@ - 682 - - - - 636 @@ -2922,7 +2890,6 @@ 672.IBPluginDependency 674.IBPluginDependency 676.IBPluginDependency - 682.IBPluginDependency 686.IBPluginDependency 687.IBPluginDependency 689.IBPluginDependency @@ -3080,7 +3047,6 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin @@ -3149,14 +3115,12 @@ closeTabMenuItem_ closeWindowMenuItem_ helpMenu_ - tabposeMenuItem_ YES NSMenuItem NSMenuItem NSMenu - NSMenuItem @@ -3166,7 +3130,6 @@ closeTabMenuItem_ closeWindowMenuItem_ helpMenu_ - tabposeMenuItem_ YES @@ -3182,10 +3145,6 @@ helpMenu_ NSMenu - - tabposeMenuItem_ - NSMenuItem - diff --git a/chrome/app/theme/default_100_percent/common/tabpose_close.png b/chrome/app/theme/default_100_percent/common/tabpose_close.png deleted file mode 100644 index 69a907a..0000000 Binary files a/chrome/app/theme/default_100_percent/common/tabpose_close.png and /dev/null differ diff --git a/chrome/app/theme/default_100_percent/mac/tabpose_close.png b/chrome/app/theme/default_100_percent/mac/tabpose_close.png deleted file mode 100644 index 40ed668..0000000 Binary files a/chrome/app/theme/default_100_percent/mac/tabpose_close.png and /dev/null differ diff --git a/chrome/app/theme/default_200_percent/mac/tabpose_close.png b/chrome/app/theme/default_200_percent/mac/tabpose_close.png deleted file mode 100644 index 7fefa32..0000000 Binary files a/chrome/app/theme/default_200_percent/mac/tabpose_close.png and /dev/null differ diff --git a/chrome/app/theme/theme_resources.grd b/chrome/app/theme/theme_resources.grd index 378f102..61fc58f 100644 --- a/chrome/app/theme/theme_resources.grd +++ b/chrome/app/theme/theme_resources.grd @@ -1075,7 +1075,6 @@ -