From cabf453e023d5c636384cf673e2f418aebac3a64 Mon Sep 17 00:00:00 2001 From: sammc Date: Sun, 13 Mar 2016 23:04:42 -0700 Subject: Remove a debugging CHECK from MimeHandlerViewGuest. With https://crrev.com/366034, the guest will be destroyed if it's detached so DocumentOnLoadCompletedInMainFrame() will only be called in a state where embedder_web_contents() is valid. BUG=569990 Review URL: https://codereview.chromium.org/1798663003 Cr-Commit-Position: refs/heads/master@{#380932} --- .../mime_handler_view/mime_handler_view_guest.cc | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc index d704b9f..27297f3 100644 --- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc +++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc @@ -227,18 +227,12 @@ bool MimeHandlerViewGuest::SaveFrame(const GURL& url, } void MimeHandlerViewGuest::DocumentOnLoadCompletedInMainFrame() { - // Assume the embedder WebContents is valid here. Change this to a DCHECK - // after verifying https://crbug.com/569990. - CHECK(owner_web_contents()); - - // Although we should always be attached before loading is complete, the - // MimeHandlerViewGuest may become detached in some cases so we still need - // to check whether we're attached here. - if (attached()) { - embedder_web_contents()->Send( - new ExtensionsGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted( - element_instance_id())); - } + // Assume the embedder WebContents is valid here. + DCHECK(embedder_web_contents()); + + embedder_web_contents()->Send( + new ExtensionsGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted( + element_instance_id())); } base::WeakPtr MimeHandlerViewGuest::GetStream() const { -- cgit v1.1