From ce8a9ca8389aa6a39c5622653e4ff9266cc0be18 Mon Sep 17 00:00:00 2001 From: "finnur@chromium.org" Date: Wed, 24 Nov 2010 15:41:17 +0000 Subject: Readd two dlls to the blacklist for demonstration purposes. To be removed shortly. TBR=huanr BUG=None TEST=None Review URL: http://codereview.chromium.org/5310004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67266 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/enumerate_modules_model_win.cc | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc index 9645d3c..5f72312 100644 --- a/chrome/browser/enumerate_modules_model_win.cc +++ b/chrome/browser/enumerate_modules_model_win.cc @@ -61,10 +61,11 @@ struct FindModule { public: explicit FindModule(const ModuleEnumerator::Module& x) : module(x) {} - bool operator()(ModuleEnumerator::Module module_in) const { + // Coverity issue 13896. + bool operator()(const ModuleEnumerator::Module& module_in) const { return (module.type == module_in.type) && - (module.location == module_in.location) && - (module.name == module_in.name); + (module.location == module_in.location) && + (module.name == module_in.name); } const ModuleEnumerator::Module& module; @@ -83,6 +84,13 @@ struct FindModule { // Entries without any Description, Signer info, or Location will never be // marked as confirmed bad (only as suspicious). const ModuleEnumerator::BlacklistEntry ModuleEnumerator::kModuleBlacklist[] = { + // Test DLLs, to demonstrate the feature. Will be removed soon. + { // apphelp.dll, "%systemroot%\\system32\\" + "f5fda581", "23d01d5b", "", "", "", NONE + }, { // rsaenh.dll, "%systemroot%\\system32\\", "Microsoft Windows" + "6af212cb", "23d01d5b", "7b47bf79", "", "", + static_cast(UPDATE | DISABLE | SEE_LINK) + }, // NOTE: Please keep this list sorted by dll name, then location. -- cgit v1.1