From d7828c27c67a11e316b6ba8679ac91300715d97e Mon Sep 17 00:00:00 2001 From: "viettrungluu@chromium.org" Date: Sat, 21 Aug 2010 16:42:35 +0000 Subject: Remove obviously unneeded forward declarations from headers under src/{app,base,net}. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3136025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98 --- app/l10n_util.h | 4 +--- app/surface/transport_dib.h | 5 ----- app/x11_util.h | 5 ----- base/file_version_info_mac.h | 4 +--- base/file_version_info_win.h | 4 +--- base/histogram.h | 5 ----- base/linux_util.h | 2 -- net/base/host_resolver.h | 3 --- net/base/sdch_filter.h | 4 +--- net/base/transport_security_state.h | 4 +--- net/disk_cache/block_files.h | 2 -- net/disk_cache/storage_block.h | 2 -- net/ftp/ftp_network_layer.h | 1 - net/http/http_auth_controller.h | 1 - net/http/http_auth_gssapi_posix.h | 4 ---- net/http/http_auth_handler.h | 2 -- net/http/http_auth_handler_mock.h | 2 ++ net/http/http_auth_sspi_win.h | 3 --- net/http/http_network_layer.h | 1 - net/http/http_network_transaction.h | 4 ---- net/http/http_proxy_client_socket_pool.h | 3 --- net/http/http_stream_factory.h | 3 --- net/proxy/proxy_config_service_common_unittest.h | 2 -- net/proxy/proxy_info.h | 4 +--- net/proxy/proxy_resolver_js_bindings.h | 2 -- net/proxy/proxy_resolver_v8.h | 5 +---- net/socket/socket_test_util.h | 2 -- net/socket/socks_client_socket_pool.h | 1 - net/tools/flip_server/epoll_server.h | 3 +-- net/url_request/url_request_context.h | 1 - net/url_request/url_request_ftp_job.h | 4 ---- 31 files changed, 10 insertions(+), 82 deletions(-) diff --git a/app/l10n_util.h b/app/l10n_util.h index 4bc3ba8..ec1da75 100644 --- a/app/l10n_util.h +++ b/app/l10n_util.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -26,8 +26,6 @@ #include "app/l10n_util_mac.h" #endif // OS_MACOSX -class PrefService; - namespace l10n_util { // This method is responsible for determining the locale as defined below. In diff --git a/app/surface/transport_dib.h b/app/surface/transport_dib.h index 4de1df4..6606c2b 100644 --- a/app/surface/transport_dib.h +++ b/app/surface/transport_dib.h @@ -18,9 +18,6 @@ #include "app/x11_util.h" #endif -namespace gfx { -class Size; -} namespace skia { class PlatformCanvas; } @@ -177,6 +174,4 @@ class TransportDIB { DISALLOW_COPY_AND_ASSIGN(TransportDIB); }; -class MessageLoop; - #endif // APP_SURFACE_TRANSPORT_DIB_H_ diff --git a/app/x11_util.h b/app/x11_util.h index 3e4c7e1..8ebed23 100644 --- a/app/x11_util.h +++ b/app/x11_util.h @@ -24,13 +24,8 @@ typedef unsigned long XID; typedef unsigned long XSharedMemoryId; // ShmSeg in the X headers. typedef struct _XDisplay Display; -namespace base { -class Thread; -} - namespace gfx { class Rect; -class Size; } namespace x11_util { diff --git a/base/file_version_info_mac.h b/base/file_version_info_mac.h index 6f94baa..d66c4e6 100644 --- a/base/file_version_info_mac.h +++ b/base/file_version_info_mac.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -18,8 +18,6 @@ class NSBundle; #endif -class FilePath; - // Provides a way to access the version information for a file. // This is the information you access when you select a file in the Windows // explorer, right-click select Properties, then click the Version tab. diff --git a/base/file_version_info_win.h b/base/file_version_info_win.h index c2bde77..3d60d69 100644 --- a/base/file_version_info_win.h +++ b/base/file_version_info_win.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -15,8 +15,6 @@ struct tagVS_FIXEDFILEINFO; typedef tagVS_FIXEDFILEINFO VS_FIXEDFILEINFO; -class FilePath; - // Provides a way to access the version information for a file. // This is the information you access when you select a file in the Windows // explorer, right-click select Properties, then click the Version tab. diff --git a/base/histogram.h b/base/histogram.h index 1d13544..adf673c 100644 --- a/base/histogram.h +++ b/base/histogram.h @@ -222,11 +222,6 @@ class Histogram; class LinearHistogram; class Pickle; -namespace disk_cache { - class StatsHistogram; -}; // namespace disk_cache - - class Histogram : public base::RefCountedThreadSafe { public: typedef int Sample; // Used for samples (and ranges of samples). diff --git a/base/linux_util.h b/base/linux_util.h index 45887db..91cb113 100644 --- a/base/linux_util.h +++ b/base/linux_util.h @@ -11,8 +11,6 @@ #include -class FilePath; - namespace base { static const char kFindInodeSwitch[] = "--find-inode"; diff --git a/net/base/host_resolver.h b/net/base/host_resolver.h index ff0ce24..a41b226 100644 --- a/net/base/host_resolver.h +++ b/net/base/host_resolver.h @@ -14,13 +14,10 @@ #include "net/base/completion_callback.h" #include "net/base/request_priority.h" -class MessageLoop; - namespace net { class AddressList; class BoundNetLog; -class HostCache; class HostResolverImpl; // This class represents the task of resolving hostnames (or IP address diff --git a/net/base/sdch_filter.h b/net/base/sdch_filter.h index 4c96f49..963cf32 100644 --- a/net/base/sdch_filter.h +++ b/net/base/sdch_filter.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -21,8 +21,6 @@ #include "net/base/filter.h" #include "net/base/sdch_manager.h" -class SafeOutputStringInterface; - namespace open_vcdiff { class VCDiffStreamingDecoder; } diff --git a/net/base/transport_security_state.h b/net/base/transport_security_state.h index 67c47e3..3b67c98 100644 --- a/net/base/transport_security_state.h +++ b/net/base/transport_security_state.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -15,8 +15,6 @@ #include "base/ref_counted.h" #include "base/time.h" -class GURL; - namespace net { // TransportSecurityState diff --git a/net/disk_cache/block_files.h b/net/disk_cache/block_files.h index 2fe41ad..2c01906 100644 --- a/net/disk_cache/block_files.h +++ b/net/disk_cache/block_files.h @@ -17,8 +17,6 @@ namespace disk_cache { -class EntryImpl; - // This class handles the set of block-files open by the disk cache. class BlockFiles { public: diff --git a/net/disk_cache/storage_block.h b/net/disk_cache/storage_block.h index ab7cd41..49694c6 100644 --- a/net/disk_cache/storage_block.h +++ b/net/disk_cache/storage_block.h @@ -13,8 +13,6 @@ namespace disk_cache { -class EntryImpl; - // This class encapsulates common behavior of a single "block" of data that is // stored on a block-file. It implements the FileBlock interface, so it can be // serialized directly to the backing file. diff --git a/net/ftp/ftp_network_layer.h b/net/ftp/ftp_network_layer.h index ea99257..a4191f9 100644 --- a/net/ftp/ftp_network_layer.h +++ b/net/ftp/ftp_network_layer.h @@ -12,7 +12,6 @@ namespace net { class FtpNetworkSession; -class FtpAuthCache; class HostResolver; class FtpNetworkLayer : public FtpTransactionFactory { diff --git a/net/http/http_auth_controller.h b/net/http/http_auth_controller.h index cb2c444..721bce9 100644 --- a/net/http/http_auth_controller.h +++ b/net/http/http_auth_controller.h @@ -21,7 +21,6 @@ namespace net { class AuthChallengeInfo; -class HostResolver; class HttpAuthHandler; class HttpNetworkSession; class HttpRequestHeaders; diff --git a/net/http/http_auth_gssapi_posix.h b/net/http/http_auth_gssapi_posix.h index 71ff555..4748c13 100644 --- a/net/http/http_auth_gssapi_posix.h +++ b/net/http/http_auth_gssapi_posix.h @@ -16,12 +16,8 @@ #define GSS_USE_FUNCTION_POINTERS #include "net/third_party/gssapi/gssapi.h" -class GURL; - namespace net { -struct HttpRequestInfo; - extern gss_OID CHROME_GSS_C_NT_HOSTBASED_SERVICE_X; extern gss_OID CHROME_GSS_C_NT_HOSTBASED_SERVICE; extern gss_OID CHROME_GSS_KRB5_MECH_OID_DESC; diff --git a/net/http/http_auth_handler.h b/net/http/http_auth_handler.h index 9b092cf..2895387 100644 --- a/net/http/http_auth_handler.h +++ b/net/http/http_auth_handler.h @@ -18,8 +18,6 @@ class Histogram; namespace net { -class HostResolver; -class ProxyInfo; struct HttpRequestInfo; // HttpAuthHandler is the interface for the authentication schemes diff --git a/net/http/http_auth_handler_mock.h b/net/http/http_auth_handler_mock.h index a6b0d48..618ec7a 100644 --- a/net/http/http_auth_handler_mock.h +++ b/net/http/http_auth_handler_mock.h @@ -16,6 +16,8 @@ namespace net { +class HostResolver; + // MockAuthHandler is used in tests to reliably trigger edge cases. class HttpAuthHandlerMock : public HttpAuthHandler { public: diff --git a/net/http/http_auth_sspi_win.h b/net/http/http_auth_sspi_win.h index bf1778f..1c8b741 100644 --- a/net/http/http_auth_sspi_win.h +++ b/net/http/http_auth_sspi_win.h @@ -22,9 +22,6 @@ namespace net { -struct HttpRequestInfo; -class ProxyInfo; - // SSPILibrary is introduced so unit tests can mock the calls to Windows' SSPI // implementation. The default implementation simply passes the arguments on to // the SSPI implementation provided by Secur32.dll. diff --git a/net/http/http_network_layer.h b/net/http/http_network_layer.h index c812302..f4ce1f1 100644 --- a/net/http/http_network_layer.h +++ b/net/http/http_network_layer.h @@ -21,7 +21,6 @@ class HttpAuthHandlerFactory; class HttpNetworkDelegate; class HttpNetworkSession; class NetLog; -class ProxyInfo; class ProxyService; class SpdySessionPool; class SSLConfigService; diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h index a010f1b..9677275 100644 --- a/net/http/http_network_transaction.h +++ b/net/http/http_network_transaction.h @@ -24,14 +24,10 @@ namespace net { -class ClientSocketFactory; -class ClientSocketHandle; class HttpAuthController; class HttpNetworkSession; -class HttpRequestHeaders; class HttpStream; class HttpStreamHandle; -class HttpStreamRequest; class IOBuffer; class HttpNetworkTransaction : public HttpTransaction, diff --git a/net/http/http_proxy_client_socket_pool.h b/net/http/http_proxy_client_socket_pool.h index 2a18086..3e3df7c 100644 --- a/net/http/http_proxy_client_socket_pool.h +++ b/net/http/http_proxy_client_socket_pool.h @@ -20,10 +20,7 @@ namespace net { -class ClientSocketFactory; -class ConnectJobFactory; class HostResolver; -class HttpAuthController; class HttpNetworkSession; class TCPClientSocketPool; class TCPSocketParams; diff --git a/net/http/http_stream_factory.h b/net/http/http_stream_factory.h index bddac83..8b64cda 100644 --- a/net/http/http_stream_factory.h +++ b/net/http/http_stream_factory.h @@ -22,10 +22,7 @@ namespace net { -class ClientSocketHandle; -class HttpAuthController; class HttpNetworkSession; -class HttpStreamRequest; class HttpStreamFactory : public StreamFactory, public base::RefCounted { diff --git a/net/proxy/proxy_config_service_common_unittest.h b/net/proxy/proxy_config_service_common_unittest.h index 2a10489..d6b40cd 100644 --- a/net/proxy/proxy_config_service_common_unittest.h +++ b/net/proxy/proxy_config_service_common_unittest.h @@ -14,8 +14,6 @@ namespace net { -class ProxyBypassRules; - // This structure contains our expectations on what values the ProxyRules // should have. struct ProxyRulesExpectation { diff --git a/net/proxy/proxy_info.h b/net/proxy/proxy_info.h index 8d799e2..69c87c8 100644 --- a/net/proxy/proxy_info.h +++ b/net/proxy/proxy_info.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -13,8 +13,6 @@ #include "net/proxy/proxy_retry_info.h" #include "net/proxy/proxy_server.h" -class GURL; - namespace net { // This object holds proxy information returned by ResolveProxy. diff --git a/net/proxy/proxy_resolver_js_bindings.h b/net/proxy/proxy_resolver_js_bindings.h index e69109b..e3939c38 100644 --- a/net/proxy/proxy_resolver_js_bindings.h +++ b/net/proxy/proxy_resolver_js_bindings.h @@ -10,8 +10,6 @@ #include "base/string16.h" -class MessageLoop; - namespace net { class HostResolver; diff --git a/net/proxy/proxy_resolver_v8.h b/net/proxy/proxy_resolver_v8.h index 70a31c2..7345f45 100644 --- a/net/proxy/proxy_resolver_v8.h +++ b/net/proxy/proxy_resolver_v8.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -9,11 +9,8 @@ #include "base/scoped_ptr.h" #include "net/proxy/proxy_resolver.h" -class MessageLoop; - namespace net { -class HostResolver; class ProxyResolverJSBindings; // Implementation of ProxyResolver that uses V8 to evaluate PAC scripts. diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h index 0904dbe..ad30353 100644 --- a/net/socket/socket_test_util.h +++ b/net/socket/socket_test_util.h @@ -45,8 +45,6 @@ enum { }; class ClientSocket; -class HttpRequestHeaders; -class HttpResponseHeaders; class MockClientSocket; class SSLClientSocket; diff --git a/net/socket/socks_client_socket_pool.h b/net/socket/socks_client_socket_pool.h index ae30d9f..3735aa3 100644 --- a/net/socket/socks_client_socket_pool.h +++ b/net/socket/socks_client_socket_pool.h @@ -21,7 +21,6 @@ namespace net { -class ClientSocketFactory; class ConnectJobFactory; class TCPClientSocketPool; class TCPSocketParams; diff --git a/net/tools/flip_server/epoll_server.h b/net/tools/flip_server/epoll_server.h index 2ada5a9..bbcb188 100644 --- a/net/tools/flip_server/epoll_server.h +++ b/net/tools/flip_server/epoll_server.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -44,7 +44,6 @@ namespace net { class EpollServer; class EpollAlarmCallbackInterface; class ReadPipeCallback; -class WatchDogToken; struct EpollEvent { EpollEvent(int events, bool is_epoll_wait) diff --git a/net/url_request/url_request_context.h b/net/url_request/url_request_context.h index 94cc29f..e72d27f 100644 --- a/net/url_request/url_request_context.h +++ b/net/url_request/url_request_context.h @@ -27,7 +27,6 @@ class FtpTransactionFactory; class HttpAuthHandlerFactory; class HttpNetworkDelegate; class HttpTransactionFactory; -class SocketStream; } class URLRequest; diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h index c614554..48f963d 100644 --- a/net/url_request/url_request_ftp_job.h +++ b/net/url_request/url_request_ftp_job.h @@ -17,10 +17,6 @@ class URLRequestContext; -namespace net { -struct list_state; -} - // A URLRequestJob subclass that is built on top of FtpTransaction. It // provides an implementation for FTP. class URLRequestFtpJob : public URLRequestJob { -- cgit v1.1