From d83d2819d0d4d1f74abce9b802b36ce007956c54 Mon Sep 17 00:00:00 2001 From: "vollick@chromium.org" Date: Thu, 17 Oct 2013 14:52:56 +0000 Subject: Revert "Revert 159282 "Refactor fixed layout mode"" This reverts commit 22b76d037bbee7ffff5c06765d5675d60ec1ae85. This was a speculative revert, but it turned out not to be the problem. Relanding. TBR=bokan@chromium.org BUG=306566 Review URL: https://codereview.chromium.org/27697004 git-svn-id: svn://svn.chromium.org/blink/trunk@159880 bbb929c8-8fbe-4397-9dbb-9b2b20218538 --- third_party/WebKit/LayoutTests/TestExpectations | 2 - .../css3/device-adapt/viewport-delete-rule.html | 3 +- .../device-adapt/viewport-invalid-values-001.html | 1 - .../device-adapt/viewport-user-agent-style.html | 3 +- .../fast/events/resize-events-expected.txt | 2 +- .../events/resize-events-fixed-layout-expected.txt | 6 - .../fast/events/resize-events-fixed-layout.html | 64 ----------- .../LayoutTests/fast/events/resize-events.html | 7 +- .../fast/repaint/fixed-layout-360x240-expected.txt | 5 - .../fast/repaint/fixed-layout-360x240.html | 14 --- .../fast/viewport/viewport-enabled.html | 1 - .../fast/viewport/viewport-legacy-ordering-10.html | 2 +- third_party/WebKit/Source/core/dom/Element.cpp | 4 +- third_party/WebKit/Source/core/frame/Frame.cpp | 7 +- third_party/WebKit/Source/core/frame/Frame.h | 2 +- third_party/WebKit/Source/core/frame/FrameView.cpp | 52 +++++++-- third_party/WebKit/Source/core/frame/FrameView.h | 16 ++- .../WebKit/Source/core/platform/ScrollView.cpp | 69 +++--------- .../WebKit/Source/core/platform/ScrollView.h | 20 +--- .../WebKit/Source/core/platform/ScrollableArea.cpp | 2 +- .../WebKit/Source/core/platform/ScrollableArea.h | 4 +- .../core/platform/chromium/FramelessScrollView.cpp | 2 +- .../core/platform/chromium/FramelessScrollView.h | 2 +- .../core/rendering/RenderLayerCompositor.cpp | 6 + .../Source/core/rendering/RenderLayerCompositor.h | 1 + .../core/rendering/RenderLayerScrollableArea.cpp | 2 +- .../core/rendering/RenderLayerScrollableArea.h | 2 +- .../WebKit/Source/core/rendering/RenderView.cpp | 20 ++-- .../WebKit/Source/core/rendering/RenderView.h | 8 +- third_party/WebKit/Source/web/ChromeClientImpl.cpp | 2 +- third_party/WebKit/Source/web/WebFrameImpl.cpp | 2 +- third_party/WebKit/Source/web/WebViewImpl.cpp | 86 ++++++-------- third_party/WebKit/Source/web/WebViewImpl.h | 14 ++- .../Source/web/tests/ScrollAnimatorNoneTest.cpp | 2 +- .../WebKit/Source/web/tests/WebFrameTest.cpp | 124 +++++++++------------ .../web/tests/WebInputEventConversionTest.cpp | 1 - 36 files changed, 219 insertions(+), 341 deletions(-) delete mode 100644 third_party/WebKit/LayoutTests/fast/events/resize-events-fixed-layout-expected.txt delete mode 100644 third_party/WebKit/LayoutTests/fast/events/resize-events-fixed-layout.html delete mode 100644 third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240-expected.txt delete mode 100644 third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240.html diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index c11376b..3c3aa10 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1008,8 +1008,6 @@ crbug.com/280554 css3/filters/custom/custom-filter-clamp-css-color-matrix.html [ crbug.com/280554 css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html [ ImageOnlyFailure Pass ] crbug.com/280554 css3/filters/custom/custom-filter-clamp-css-mix-color.html [ ImageOnlyFailure Pass ] -Bug(bokan) fast/dynamic/window-resize-scrollbars-test.html [ NeedsRebaseline ] - crbug.com/280658 [ Win7 ] inspector-protocol/layers/get-layers.html [ Pass Failure ] crbug.com/280342 [ Win Release ] http/tests/media/progress-events-generated-correctly.html [ Failure Pass ] crbug.com/280698 inspector/styles/multiple-imports-edit-crash.html [ Pass Failure ] diff --git a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-delete-rule.html b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-delete-rule.html index 0013233..159f35269 100644 --- a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-delete-rule.html +++ b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-delete-rule.html @@ -9,7 +9,6 @@ - +
diff --git a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-invalid-values-001.html b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-invalid-values-001.html index c7a7422..7753560 100644 --- a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-invalid-values-001.html +++ b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-invalid-values-001.html @@ -6,7 +6,6 @@ diff --git a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-user-agent-style.html b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-user-agent-style.html index d0d9d6f..9b71239 100644 --- a/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-user-agent-style.html +++ b/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-user-agent-style.html @@ -6,7 +6,6 @@ @@ -14,7 +13,7 @@ html, body { width: 100%; height: 100%; margin: 0 } - +
- - - diff --git a/third_party/WebKit/LayoutTests/fast/events/resize-events.html b/third_party/WebKit/LayoutTests/fast/events/resize-events.html index c5ca3d1..b6f8b72 100644 --- a/third_party/WebKit/LayoutTests/fast/events/resize-events.html +++ b/third_party/WebKit/LayoutTests/fast/events/resize-events.html @@ -7,7 +7,7 @@
- Following actions must not emit resize events: page load, dynamic content generation, page scaling and changing fixed layout size.
+ Following actions must not emit resize events: page load, dynamic content generation, and page scaling.
The spec DOM Level 2 Events states that the resize event occurs when document view size (a.k.a layout size) is changed. Refer to http://www.w3.org/TR/DOM-Level-2-Events/events.html
However, showing/hiding scrollbars shouldn't be considered a layout size change. Refer to webkit.org/b/80242
@@ -41,11 +41,6 @@ function scalePage() { if (window.eventSender) window.eventSender.setPageScaleFactor(3, 0, 0); - setTimeout(changeFixedLayoutSize, 20); - } - function changeFixedLayoutSize() { - if (window.testRunner) - testRunner.setFixedLayoutSize(1600, 1600); setTimeout(finish, 20); } function finish() { diff --git a/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240-expected.txt b/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240-expected.txt deleted file mode 100644 index 70bacae..0000000 --- a/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240-expected.txt +++ /dev/null @@ -1,5 +0,0 @@ -layer at (0,0) size 360x240 - RenderView at (0,0) size 360x240 -layer at (0,0) size 360x240 - RenderBlock {HTML} at (0,0) size 360x240 - RenderBody {BODY} at (8,8) size 344x224 [bgcolor=#008000] diff --git a/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240.html b/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240.html deleted file mode 100644 index 0801299..0000000 --- a/third_party/WebKit/LayoutTests/fast/repaint/fixed-layout-360x240.html +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - diff --git a/third_party/WebKit/LayoutTests/fast/viewport/viewport-enabled.html b/third_party/WebKit/LayoutTests/fast/viewport/viewport-enabled.html index b6d43a3..e3726bd 100644 --- a/third_party/WebKit/LayoutTests/fast/viewport/viewport-enabled.html +++ b/third_party/WebKit/LayoutTests/fast/viewport/viewport-enabled.html @@ -7,7 +7,6 @@ document.write("Width with viewport disabled. (should be 800): " + document.documentElement.offsetWidth + "
"); - testRunner.enableFixedLayoutMode(true); internals.settings.setViewportEnabled(true); document.write("Width from meta viewport (should be 320): " + document.documentElement.offsetWidth); diff --git a/third_party/WebKit/LayoutTests/fast/viewport/viewport-legacy-ordering-10.html b/third_party/WebKit/LayoutTests/fast/viewport/viewport-legacy-ordering-10.html index 578f23e..14971e8 100644 --- a/third_party/WebKit/LayoutTests/fast/viewport/viewport-legacy-ordering-10.html +++ b/third_party/WebKit/LayoutTests/fast/viewport/viewport-legacy-ordering-10.html @@ -13,7 +13,7 @@ - +