From de5c041e67fa5abee83359b9346ca4896f1723ca Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 1 Jan 2016 13:54:36 -0500 Subject: mac and ios: Build third-party code with -Wall. This lands the mac and ios build/common.gypi bits of https://codereview.chromium.org/1551753002/ (reviewed there) BUG=573250 R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc Cr-Commit-Position: refs/heads/master@{#367255} Review URL: https://codereview.chromium.org/1555843002 . Cr-Commit-Position: refs/heads/master@{#367263} --- build/common.gypi | 2 +- third_party/class-dump/class-dump.gyp | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/build/common.gypi b/build/common.gypi index 9296ae9..ae65c06 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -3206,7 +3206,7 @@ [ 'OS=="mac" or OS=="ios"', { 'xcode_settings': { - 'WARNING_CFLAGS!': ['-Wall', '-Wextra'], + 'WARNING_CFLAGS!': ['-Wextra'], }, 'conditions': [ ['buildtype=="Official"', { diff --git a/third_party/class-dump/class-dump.gyp b/third_party/class-dump/class-dump.gyp index 876f3a5..be24b30 100644 --- a/third_party/class-dump/class-dump.gyp +++ b/third_party/class-dump/class-dump.gyp @@ -168,6 +168,12 @@ 'src/Source/ULEB128.m', 'src/Source/cd_objc2.h', ], + 'variables': { + 'clang_warning_flags': [ + # e.g. CDRebaseTypeDescription in CDLCDyldInfo.m + '-Wno-unused-function', + ], + }, 'link_settings': { 'libraries': [ '$(SDKROOT)/System/Library/Frameworks/Foundation.framework', -- cgit v1.1