From e4d7096ca0d34bd5db54b8b956cc2be938d22af4 Mon Sep 17 00:00:00 2001 From: "wtc@chromium.org" Date: Thu, 21 Jul 2011 20:16:11 +0000 Subject: Cleanup for r93201. The initializer for watcher_ in the FileDescriptorWatcher constructor was deleted accidentally. USE_SYSTEM_LIBEVENT is defined by the build system, so we don't need to include "build/build_config.h". R=willchan@chromium.org BUG=88134 TEST=MessagePumpLibeventTest.* Review URL: http://codereview.chromium.org/7473017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93460 0039d316-1c4b-4281-b951-d872f2087c98 --- base/message_pump_libevent.cc | 4 +++- base/message_pump_libevent_unittest.cc | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/base/message_pump_libevent.cc b/base/message_pump_libevent.cc index 3e3facf..1b4c023 100644 --- a/base/message_pump_libevent.cc +++ b/base/message_pump_libevent.cc @@ -54,6 +54,7 @@ MessagePumpLibevent::FileDescriptorWatcher::FileDescriptorWatcher() : is_persistent_(false), event_(NULL), pump_(NULL), + watcher_(NULL), ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) { } @@ -350,7 +351,8 @@ void MessagePumpLibevent::OnLibeventNotification(int fd, short flags, if (flags & EV_WRITE) { controller->OnFileCanWriteWithoutBlocking(fd, pump); } - // Check |controller| in case it's been deleted in this callback. + // Check |controller| in case it's been deleted in + // controller->OnFileCanWriteWithoutBlocking(). if (controller.get() && flags & EV_READ) { controller->OnFileCanReadWithoutBlocking(fd, pump); } diff --git a/base/message_pump_libevent_unittest.cc b/base/message_pump_libevent_unittest.cc index 2a6d7bc..9ec78de 100644 --- a/base/message_pump_libevent_unittest.cc +++ b/base/message_pump_libevent_unittest.cc @@ -8,7 +8,6 @@ #include "base/message_loop.h" #include "base/threading/thread.h" -#include "build/build_config.h" #include "testing/gtest/include/gtest/gtest.h" #if defined(USE_SYSTEM_LIBEVENT) -- cgit v1.1