From ebdb684a77d95889be31d09df5973297ca4decce Mon Sep 17 00:00:00 2001 From: brucedawson Date: Fri, 25 Mar 2016 17:38:36 -0700 Subject: Disable incremental linking for gn osmesa Due to a VS 2015 linker bug the linker sometimes crashes when incrementally linking osmesa.dll. The bug is understood by Microsoft and will be fixed but while waiting for the fix it would be nice to avoid the crash. This disables incremental linking for gn builds only. I could not get disabling for gyp builds to work so this is a partial fix. gn FTW! BUG=440500,482671 Review URL: https://codereview.chromium.org/1833263002 Cr-Commit-Position: refs/heads/master@{#383420} --- third_party/mesa/BUILD.gn | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/third_party/mesa/BUILD.gn b/third_party/mesa/BUILD.gn index 31df76a..5108af1 100644 --- a/third_party/mesa/BUILD.gn +++ b/third_party/mesa/BUILD.gn @@ -713,6 +713,11 @@ loadable_module("osmesa") { if (is_win) { ldflags = [ "/DEF:" + rebase_path("src/src/mesa/drivers/osmesa/osmesa.def", root_build_dir) ] + + # TODO(brucedawson) : remove when crbug.com/482671 is resolved by + # Microsoft. + configs -= [ "//build/config/win:default_incremental_linking" ] + configs += [ "//build/config/win:no_incremental_linking" ] } deps = [ -- cgit v1.1