From 331580b5a604f073f4afabd21537d42de3732178 Mon Sep 17 00:00:00 2001 From: "ali.akbar@gmail.com" Date: Fri, 12 Aug 2011 20:13:20 +0000 Subject: Fixes a corner case bug in the HexStringToInt conversion function which caused the string "0x" to be treated as a valid hexadecimal number. Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2 If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result Changed the condition from "greater than or equal to" to "greater than" Added another test cases which now properly treats "0x" as an invalid hex string Contributed by ali.akbar@gmail.com BUG=92054 Review URL: http://codereview.chromium.org/7584031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98 --- AUTHORS | 1 + 1 file changed, 1 insertion(+) (limited to 'AUTHORS') diff --git a/AUTHORS b/AUTHORS index 13158a8..818fe93 100644 --- a/AUTHORS +++ b/AUTHORS @@ -117,3 +117,4 @@ Torsten Kurbad Max Perepelitsyn Luke Zarko Felix H. Dahlke +Ali Vathi -- cgit v1.1