From 50c3009dad08aa2ef9ee1d1830585fd95e0beea0 Mon Sep 17 00:00:00 2001 From: "dbeam@chromium.org" Date: Wed, 15 Feb 2012 04:21:36 +0000 Subject: Add linux_clang to default try set so when one runs `git try` or `gcl try` it will add linux_clang automatically. TEST=Less tree breakage because of not trying changes on clang first. BUG=None NOTRY=true Review URL: http://codereview.chromium.org/9395027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98 --- PRESUBMIT.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index fd1df32..e6ef99b 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -334,13 +334,15 @@ def CheckChangeOnCommit(input_api, output_api): def GetPreferredTrySlaves(project, change): - only_objc_files = all( - f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) + affected_files = change.LocalPaths() + only_objc_files = all(f.endswith(('.mm', '.m')) for f in affected_files) if only_objc_files: return ['mac_rel'] preferred = ['win_rel', 'linux_rel', 'mac_rel'] + if any(f.endswith(('.h', '.cc', '.cpp', '.cxx')) for f in affected_files): + preferred.append('linux_clang') aura_re = '_aura[^/]*[.][^/]*' - if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()): + if any(re.search(aura_re, f) for f in affected_files): preferred.append('linux_chromeos') # For bringup (staging of upstream work) we must be careful to not # overload Android infrastructure. Keeping Android try decisions in a @@ -351,8 +353,8 @@ def GetPreferredTrySlaves(project, change): # android builder, use the android try server. android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/', '^build/common.gypi$') - for f in change.AffectedFiles(): - if any(re.search(r, f.LocalPath()) for r in android_re_list): + for f in affected_files: + if any(re.search(r, f) for r in android_re_list): preferred.append('android') break return preferred -- cgit v1.1