From a5f4d1f9eea8f431dc43ee562d7e79d1b4ea375a Mon Sep 17 00:00:00 2001 From: "mkosiba@chromium.org" Date: Fri, 30 Nov 2012 19:20:34 +0000 Subject: [android_webview] Fix use after free in intercepted requests. This fixes the use after free problem that can occur if the Seek or Read request on the worker thread runs after the job has been deleted. TEST=AndroidWebViewTests,android_webview_unittests BUG=None R=mnaganov@chromium.org Review URL: https://chromiumcodereview.appspot.com/11428052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170505 0039d316-1c4b-4281-b951-d872f2087c98 --- android_webview/native/intercepted_request_data_impl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'android_webview/native/intercepted_request_data_impl.cc') diff --git a/android_webview/native/intercepted_request_data_impl.cc b/android_webview/native/intercepted_request_data_impl.cc index 894eb7c..675d523 100644 --- a/android_webview/native/intercepted_request_data_impl.cc +++ b/android_webview/native/intercepted_request_data_impl.cc @@ -35,14 +35,14 @@ class StreamReaderJobDelegateImpl : virtual bool GetMimeType(JNIEnv* env, net::URLRequest* request, - const android_webview::InputStream& stream, + android_webview::InputStream* stream, std::string* mime_type) OVERRIDE { return intercepted_request_data_impl_->GetMimeType(env, mime_type); } virtual bool GetCharset(JNIEnv* env, net::URLRequest* request, - const android_webview::InputStream& stream, + android_webview::InputStream* stream, std::string* charset) OVERRIDE { return intercepted_request_data_impl_->GetCharset(env, charset); } -- cgit v1.1