From 55bb47d66ae62d025f47b1ae50678ef03922613d Mon Sep 17 00:00:00 2001 From: "viettrungluu@chromium.org" Date: Wed, 13 Nov 2013 19:32:37 +0000 Subject: Revert 234855 "Encrypt all stored cookies on selected operating ..." [Failed content_unittests on ASAN.] > Encrypt all stored cookies on selected operating systems. > > As part of the goal of protecting private user information, this encrypts the cookie values on operating systems with user-specific crypto APIs and that do not otherwise protect this data. > > Performance tests indicate a penalty of about 1ms per cookie (regardless of size) on a Mac and 0.1ms to 0.7ms (depending on the size) under Windows. This will be higher on older hardware but still insignificant. > > Encrypted data is binary (with an overhead of 128 bytes on Windows) and binary data must be stored in a BLOB so only one of two fields ("value" or "encrypted_value") will have data with the other being empty. Both values, however, need to be read & written when accessing a cookie because they are marked "non null"). > > BUG=313323 > > Review URL: https://codereview.chromium.org/24734007 TBR=bcwhite@chromium.org Review URL: https://codereview.chromium.org/70913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234873 0039d316-1c4b-4281-b951-d872f2087c98 --- android_webview/browser/aw_browser_context.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'android_webview') diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc index cd10e6a..70c2507 100644 --- a/android_webview/browser/aw_browser_context.cc +++ b/android_webview/browser/aw_browser_context.cc @@ -22,7 +22,6 @@ #include "components/user_prefs/user_prefs.h" #include "components/visitedlink/browser/visitedlink_master.h" #include "content/public/browser/browser_thread.h" -#include "content/public/browser/cookie_crypto_delegate.h" #include "content/public/browser/cookie_store_factory.h" #include "content/public/browser/resource_context.h" #include "content/public/browser/storage_partition.h" @@ -145,8 +144,7 @@ void AwBrowserContext::PreMainMessageLoopRun() { NULL, NULL, BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO), - background_task_runner, - scoped_ptr()); + background_task_runner); cookie_store_->GetCookieMonster()->SetPersistSessionCookies(true); url_request_context_getter_ = -- cgit v1.1