From 90ca4e6872835e8b117739081678d46b52db294f Mon Sep 17 00:00:00 2001 From: "ben@chromium.org" Date: Fri, 26 Jun 2009 00:11:01 +0000 Subject: Make omnibox2 dropdown not flash during result set transitions... - Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous. - Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in. - The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped). BUG=none TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters. Review URL: http://codereview.chromium.org/149030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19317 0039d316-1c4b-4281-b951-d872f2087c98 --- app/animation.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/animation.cc') diff --git a/app/animation.cc b/app/animation.cc index 59d3dea..1ef905d 100644 --- a/app/animation.cc +++ b/app/animation.cc @@ -87,7 +87,7 @@ void Animation::End() { } } -bool Animation::IsAnimating() { +bool Animation::IsAnimating() const { return animating_; } -- cgit v1.1